Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review136549 --- Master (692074c) is red with this patch. ./build-support/jenkins

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 7, 2016, 9:01 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47998: Converting resource counters to use new resource fields

> On June 7, 2016, 6:25 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/Utilization.java, lines > > 127-137 > > > > > > Feel free to punt on this, but maybe extract a private method that

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 7, 2016, 8:58 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review136514 --- Ship it! Feel free to ignore both comments below ;). src/main

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review136384 --- Ship it! Master (2e7b317) is green with this patch. ./build-s

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 6, 2016, 11:22 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- (Updated June 6, 2016, 11:13 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 47998: Converting resource counters to use new resource fields

> On May 28, 2016, 9:35 p.m., Stephan Erb wrote: > > The refactoring itself looks good. However, I am not sure if we should > > really opt for the metric name change. It will break external statistic > > scrapers without a great benefit for us. Correct, this will require adjusting scheduler me

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review135394 --- Fix it, then Ship it! The refactoring itself looks good. Howeve

Re: Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/#review135366 --- Ship it! Master (b76e38f) is green with this patch. ./build-s

Review Request 47998: Converting resource counters to use new resource fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47998/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: aurora D