Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/#review150463
---


Ship it!




Ship It!

- Zameer Manji


On Sept. 26, 2016, 2:16 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52276/
> ---
> 
> (Updated Sept. 26, 2016, 2:16 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1783
> https://issues.apache.org/jira/browse/AURORA-1783
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Last refactoring of Webhook did not correctly close out connections so some 
> webhook requests would not complete.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
> 66c134488f159fc25cfb2c1755b8fa23fbbdb613 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> 71aae983e9c2c34e106a931e4d25691977684b11 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> 6f37baaefb2910e688d7df90f3e94fc282cfb6b6 
> 
> Diff: https://reviews.apache.org/r/52276/diff/
> 
> 
> Testing
> ---
> 
> Verified in vagrant + added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/#review150460
---


Ship it!




Master (4ead189) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 26, 2016, 9:16 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52276/
> ---
> 
> (Updated Sept. 26, 2016, 9:16 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1783
> https://issues.apache.org/jira/browse/AURORA-1783
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Last refactoring of Webhook did not correctly close out connections so some 
> webhook requests would not complete.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
> 66c134488f159fc25cfb2c1755b8fa23fbbdb613 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> 71aae983e9c2c34e106a931e4d25691977684b11 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> 6f37baaefb2910e688d7df90f3e94fc282cfb6b6 
> 
> Diff: https://reviews.apache.org/r/52276/diff/
> 
> 
> Testing
> ---
> 
> Verified in vagrant + added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/
---

(Updated Sept. 26, 2016, 9:16 p.m.)


Review request for Aurora and Zameer Manji.


Bugs: AURORA-1783
https://issues.apache.org/jira/browse/AURORA-1783


Repository: aurora


Description
---

Last refactoring of Webhook did not correctly close out connections so some 
webhook requests would not complete.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
66c134488f159fc25cfb2c1755b8fa23fbbdb613 
  src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
71aae983e9c2c34e106a931e4d25691977684b11 
  src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
6f37baaefb2910e688d7df90f3e94fc282cfb6b6 

Diff: https://reviews.apache.org/r/52276/diff/


Testing
---

Verified in vagrant + added unit tests.


Thanks,

Dmitriy Shirchenko

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/#review150458
---



Master (4ead189) is red with this patch.
  ./build-support/jenkins/build.sh

:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74:
 Note: Wrote forwarder 
org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java
 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:27:8:
 error: Unused import - org.apache.http.HttpResponse.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:28:8:
 error: Unused import - org.apache.http.client.HttpClient.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:33:8:
 error: Unused import - org.apache.http.client.HttpClient.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 2 mins 30.899 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Sept. 26, 2016, 9:08 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52276/
> ---
> 
> (Updated Sept. 26, 2016, 9:08 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1783
> https://issues.apache.org/jira/browse/AURORA-1783
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Last refactoring of Webhook did not correctly close out connections so some 
> webhook requests would not complete.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
> 66c134488f159fc25cfb2c1755b8fa23fbbdb613 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> 71aae983e9c2c34e106a931e4d25691977684b11 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> 6f37baaefb2910e688d7df90f3e94fc282cfb6b6 
> 
> Diff: https://reviews.apache.org/r/52276/diff/
> 
> 
> Testing
> ---
> 
> Verified in vagrant + added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Re: Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/#review150457
---




src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 81)


Please leave a comment to explain what we are doing here. You can link to 
the documentation to explain that we need to consume the entity and ensure the 
response is closed to ensure the underlying connection is closed.


- Zameer Manji


On Sept. 26, 2016, 2:08 p.m., Dmitriy Shirchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52276/
> ---
> 
> (Updated Sept. 26, 2016, 2:08 p.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1783
> https://issues.apache.org/jira/browse/AURORA-1783
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Last refactoring of Webhook did not correctly close out connections so some 
> webhook requests would not complete.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
> 66c134488f159fc25cfb2c1755b8fa23fbbdb613 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> 71aae983e9c2c34e106a931e4d25691977684b11 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> 6f37baaefb2910e688d7df90f3e94fc282cfb6b6 
> 
> Diff: https://reviews.apache.org/r/52276/diff/
> 
> 
> Testing
> ---
> 
> Verified in vagrant + added unit tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Review Request 52276: Fixing connection leak in webhook by making sure stream is closed.

[Dmitriy Shirchenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52276/
---

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1783
https://issues.apache.org/jira/browse/AURORA-1783


Repository: aurora


Description
---

Last refactoring of Webhook did not correctly close out connections so some 
webhook requests would not complete.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/events/Webhook.java 
66c134488f159fc25cfb2c1755b8fa23fbbdb613 
  src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
71aae983e9c2c34e106a931e4d25691977684b11 
  src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
6f37baaefb2910e688d7df90f3e94fc282cfb6b6 

Diff: https://reviews.apache.org/r/52276/diff/


Testing
---

Verified in vagrant + added unit tests.


Thanks,

Dmitriy Shirchenko