Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/
---

(Updated May 4, 2018, 10:46 a.m.)


Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.


Changes
---

Removing comments from Vagrantfile.


Repository: aurora


Description
---

Changing Vagrant requirements to latest version for launching our local dev box.

Needed since we depend on the Vagrant Cloud instead of Atlas now.


Diffs (updated)
-

  Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 


Diff: https://reviews.apache.org/r/66922/diff/2/

Changes: https://reviews.apache.org/r/66922/diff/1-2/


Testing
---

Ran vagrant box with latest Vagrant version (2.0.4).


Thanks,

Renan DelValle

Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Renan DelValle 


> On May 2, 2018, 11:41 p.m., Jordan Ly wrote:
> > Vagrantfile
> > Lines 20-21 (original), 20-21 (patched)
> > 
> >
> > Should we need to update (or remove) this comment?

Good catch, I'll get rid of this.


- Renan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202343
---


On May 2, 2018, 3:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 3:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-04 Thread Santhosh Kumar Shanmugham 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202453
---


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On May 2, 2018, 3:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 3:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-03 Thread Jordan Ly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202343
---


Ship it!




LGTM.

I think the Webhook test is being flaky again :/


Vagrantfile
Lines 20-21 (original), 20-21 (patched)


Should we need to update (or remove) this comment?


- Jordan Ly


On May 2, 2018, 10:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 10:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Re: Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-02 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/#review202325
---



Master (a3d596e) is red with this patch.
  ./build-support/jenkins/build.sh

at 
org.apache.aurora.scheduler.TaskStatusHandlerImpl.lambda$run$0(TaskStatusHandlerImpl.java:158)
at 
org.apache.aurora.scheduler.storage.Storage$MutateWork$NoResult.apply(Storage.java:144)
at 
org.apache.aurora.scheduler.storage.Storage$MutateWork$NoResult.apply(Storage.java:139)
at 
org.apache.aurora.scheduler.storage.testing.StorageTestUtil.lambda$expectWrite$1(StorageTestUtil.java:83)
at org.easymock.internal.Result.answer(Result.java:106)
at org.easymock.internal.ReplayState.invokeInner(ReplayState.java:60)
at org.easymock.internal.ReplayState.invoke(ReplayState.java:46)
at 
org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:40)
at 
org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:94)
at com.sun.proxy.$Proxy20.write(Unknown Source)
at 
org.apache.aurora.scheduler.TaskStatusHandlerImpl.run(TaskStatusHandlerImpl.java:154)
at 
com.google.common.util.concurrent.AbstractExecutionThreadService$1$2.run(AbstractExecutionThreadService.java:66)
at com.google.common.util.concurrent.Callables$4.run(Callables.java:122)
at java.lang.Thread.run(Thread.java:748)



org.apache.aurora.scheduler.events.WebhookTest > 
testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:251
I0502 22:35:46.499 [ShutdownHook, SchedulerMain] Stopping scheduler services. 

1082 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: 
file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 7m 21s
45 actionable tasks: 36 executed, 9 up-to-date


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On May 2, 2018, 10:08 p.m., Renan DelValle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66922/
> ---
> 
> (Updated May 2, 2018, 10:08 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Changing Vagrant requirements to latest version for launching our local dev 
> box.
> 
> Needed since we depend on the Vagrant Cloud instead of Atlas now.
> 
> 
> Diffs
> -
> 
>   Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 
> 
> 
> Diff: https://reviews.apache.org/r/66922/diff/1/
> 
> 
> Testing
> ---
> 
> Ran vagrant box with latest Vagrant version (2.0.4).
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Review Request 66922: Changing Vagrant requirements to latest version for launching our local dev box.

2018-05-02 Thread Renan DelValle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66922/
---

Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.


Repository: aurora


Description
---

Changing Vagrant requirements to latest version for launching our local dev box.

Needed since we depend on the Vagrant Cloud instead of Atlas now.


Diffs
-

  Vagrantfile 76dfcaca08324a458d7ec45a85deb7a38d94b1f7 


Diff: https://reviews.apache.org/r/66922/diff/1/


Testing
---

Ran vagrant box with latest Vagrant version (2.0.4).


Thanks,

Renan DelValle