Re: Review Request 19143: Catch errors thrown by authentication modules.

2014-03-17 Thread Mark Chu-Carroll
> On March 13, 2014, 2:26 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 243 > > > > > > The broad catch below worries me a bit. Would it be feasible to have > > the v

Re: Review Request 19143: Catch errors thrown by authentication modules.

2014-03-17 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37392 --- Ship it! Ship It! - Brian Wickman On March 12, 2014, 10:59 p.m.,

Re: Review Request 19143: Catch errors thrown by authentication modules.

2014-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37409 --- Ship it! Ship It! - Kevin Sweeney On March 12, 2014, 3:59 p.m.,

Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.

2014-03-17 Thread Bill Farner
> On March 15, 2014, 1:40 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.java, > > line 90 > > > > > > Any chance this could be merged with the next statement? It

Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.

2014-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- (Updated March 17, 2014, 6:55 p.m.) Review request for Aurora. Bugs: AURORA-2

Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.

2014-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/#review37427 --- - Kevin Sweeney On March 17, 2014, 11:55 a.m., Bill Farner wrote:

Re: Review Request 19159: Add killall.

2014-03-17 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 17, 2014, 3:02 p.m.) Review request for Aurora, Kevin Sweeney an

Review Request 19313: added killall command

2014-03-17 Thread Tom Galloway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19313/ --- Review request for Aurora, Chris Lambert, Dave Lester, and Mark Chu-Carroll. Re

Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.

2014-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/#review37430 --- src/main/java/org/apache/aurora/scheduler/filter/ConstraintFilter.j

Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.

2014-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/ --- (Updated March 17, 2014, 7:14 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 19159: Add killall.

2014-03-17 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 17, 2014, 3:45 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18714: Disable log and initiate shutdown upon log storage failures.

2014-03-17 Thread Bill Farner
> On March 6, 2014, 7:05 p.m., Suman Karumuri wrote: > > If I remember the discussion correctly, there is a race condition here, > > where some actions could still be performed through the memory store, > > between the time the storage is shutdown and the shutdown actually happens. > > That pr

Review Request 19323: [BugFix] Added jobStats on old role page. Disabled job status badge.

2014-03-17 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 19323: [BugFix] Added jobStats on old role page. Disabled job status badge.

2014-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/#review37493 --- I started on this in parallel, and have a few additional changes i'd

Review Request 19331: Renaming packages to packagesDEPRECATED in client.

2014-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository: aurora

Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.

2014-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/#review37506 --- Should some of the user-facing things be updated to print metadata i

Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.

2014-03-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/#review37508 --- Ship it! Ship It! - Bill Farner On March 17, 2014, 11:26 p.m., M

Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.

2014-03-17 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/ --- (Updated March 17, 2014, 11:57 p.m.) Review request for Aurora, Kevin Sweeney a

Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.

2014-03-17 Thread Suman Karumuri
> On March 17, 2014, 10:26 p.m., Bill Farner wrote: > > I started on this in parallel, and have a few additional changes i'd like > > you to include. Please have a look at the tip commit on > > origin/wfarner/fix_jobs_page. (Convenience link: > > https://git-wip-us.apache.org/repos/asf?p=incu

Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.

2014-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- (Updated March 18, 2014, 12:03 a.m.) Review request for Aurora, Mark Chu-Carrol

Re: Review Request 19331: Renaming packages to packagesDEPRECATED in client.

2014-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19331/ --- (Updated March 18, 2014, 12:07 a.m.) Review request for Aurora, Mark Chu-Carrol

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

2014-03-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/ --- (Updated March 18, 2014, 12:55 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.

2014-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323/#review37524 --- build.gradle