Re: Review Request 19313: added killall command

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19313/#review38086 --- docs/README.md https://reviews.apache.org/r/19313/#comment70051

Re: Review Request 19519: Allow override of default RB server in shipits tool.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19519/#review38099 --- Ship it! Ship It! - Maxim Khutornenko On March 21, 2014, 2:48

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review38101 --- Jake - do you agree with discarding this in favor of

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-03-21 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- (Updated March 21, 2014, 2:59 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17293/#review38107 --- Looks like committers neglected to put this on master. It's now on

Re: Review Request 19207: Removed content about null-op {{#x}}

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19207/#review38110 --- The summary and description don't seem to match the diff here. Can

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-03-21 Thread Jake Farrell
On March 21, 2014, 2:52 p.m., Bill Farner wrote: Jake - do you agree with discarding this in favor of https://reviews.apache.org/r/17750/? Was waiting on Kevin to commit that and then was going to rebase the other changes that I did for this against his https://reviews.apache.org/r/17750

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38113 --- Ping, Bill? - Maxim Khutornenko On March 20, 2014, 12:20 a.m.,

Re: Review Request 19362: Changing from STARTING to RUNNING in job uptime calculations.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19362/#review38114 --- Ping. - Maxim Khutornenko On March 18, 2014, 6:16 p.m., Maxim

Review Request 19534: Fix line exceeding 100 cols.

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19534/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38123 --- Just to make things clear, this changelist is not addressing the

Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/ --- (Updated March 21, 2014, 2:21 p.m.) Review request for Aurora, Maxim

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38140 --- src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38147 --- Just FYI: the client unit tests weren't intended to detect stuff

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38148 --- Please update the end-to-end test - it will cheaply and

Re: Review Request 16630: Minor Constraint/order() correction 2

2014-03-21 Thread Tom Galloway
No, this one got shipped a while back. Tom On Fri, Mar 21, 2014 at 8:13 AM, Bill Farner wfar...@apache.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16630/ Is this review still relevant? If so, can you add some target reviewer

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-21 Thread Mark Chu-Carroll
On March 21, 2014, 2:44 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_restart.py, line 43 https://reviews.apache.org/r/19466/diff/1/?file=529930#file529930line43 Right, my comment was about the method in this class that still uses the old reference?

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38155 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/#review38159 --- Ship it! src/test/python/apache/aurora/client/cli/test_status.py

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38160 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-21 Thread Maxim Khutornenko
On March 21, 2014, 6:44 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 317 https://reviews.apache.org/r/19466/diff/1/?file=529926#file529926line317 I hear your point. However, it would be a departure from other places where we use batching

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38162 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16710/#review38166 --- you can pull me off this review as I think you have all bases

Re: Review Request 19362: Changing from STARTING to RUNNING in job uptime calculations.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19362/#review38167 --- Ship it! Ship It! - Brian Wickman On March 18, 2014, 6:16 p.m.,

Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38169 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 6:21 p.m.,

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/ --- (Updated March 21, 2014, 7:42 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 21, 2014, 3:56 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38196 --- src/main/python/apache/aurora/client/cli/options.py

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38198 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Suman Karumuri
On March 21, 2014, 11:58 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/quota.py, line 71 https://reviews.apache.org/r/19509/diff/1/?file=531021#file531021line71 Maybe I just read weird stuff, but this wording is uncomfortable: consumption is the historic

Review Request 19550: Filtering out non-prod tasks for domain sla calculations.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19550/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-287

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38205 --- Ship it! Ship It! - Mark Chu-Carroll On March 20, 2014, 10:39

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Suman Karumuri
On March 21, 2014, 6:27 p.m., Mark Chu-Carroll wrote: Just FYI: the client unit tests weren't intended to detect stuff like this. The intention of those tests is just to verify that the client logic works - meaning that the client sends the API calls that we expect it to. If an API

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/ --- (Updated March 21, 2014, 9:39 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078/#review38232 --- Ship it! Ship It! - Bill Farner On March 21, 2014, 9:39 p.m.,

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38235 --- src/test/python/apache/aurora/client/cli/test_quota.py

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38237 --- Ship it!

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Maxim Khutornenko
On March 22, 2014, 12:10 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line 573 https://reviews.apache.org/r/19436/diff/2/?file=531757#file531757line573 return previousState.getStatus().orNull() Ah, another good feature of

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/#review38240 ---

Re: Review Request 19436: Preserving sandbox deleted task history.

2014-03-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19436/ --- (Updated March 22, 2014, 12:30 a.m.) Review request for Aurora, Kevin Sweeney