Re: Review Request 19833: Migrated Job page to angular JS

2014-04-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/#review40748 --- Ship it! My only concern is I think the controller code can be

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/#review40749 --- Ship it! My only concern is I think the controller code can be

Re: Review Request 20490: Add a get version API method.

2014-04-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/ --- (Updated April 18, 2014, 12:29 p.m.) Review request for Aurora. Repository:

Re: Review Request 20490: Add a get version API method.

2014-04-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/ --- (Updated April 18, 2014, 1:30 p.m.) Review request for Aurora, Maxim

Re: Review Request 20377: Use git-describe to generate version number.

2014-04-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20377/#review40793 --- Ship it! Jake's comment deserves attention, but i'd be okay with

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 18, 2014, 6:47 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 18, 2014, 8:41 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20246/#review40811 --- Ping? Once this is in, i'll update and proceed with

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 18, 2014, 8:43 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40812 --- docs/tutorial.md https://reviews.apache.org/r/20238/#comment73979

Re: Review Request 20344: AURORA-267: Add container to popover to avoid clipping issue

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20344/#review40816 --- Ship it! Ship It! - Maxim Khutornenko On April 16, 2014, 9:40

Re: Review Request 20490: Add a get version API method.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/#review40818 --- Ship it! src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-18 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/ --- (Updated April 19, 2014, 2:04 a.m.) Review request for Aurora, David

Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-18 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20246/ --- (Updated April 19, 2014, 3:35 a.m.) Review request for Aurora and Bill Farner.