Re: Review Request 21848: Fix command typo

2014-05-23 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21848/#review43828 --- Ship it! Ship It! - Mark Chu-Carroll On May 23, 2014, 2:14 a.m.,

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/#review43850 --- File Attachment: completed tasks tab - Screen Shot 2014-05-22 at 6

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner
> On May 23, 2014, 12:07 a.m., Maxim Khutornenko wrote: > > This will not pass python tests as we reference resp.message in quite a few > > places. Doh! You're right, i published this in haste before leaving the office. I'll fix that up shortly. - Bill ---

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/#review43854 --- src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java <

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ --- (Updated May 23, 2014, 6:54 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Suman Karumuri
> On May 22, 2014, 11:37 p.m., David McLaughlin wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css, line 127 > > > > > > We should probably decide on a naming convention for custom CSS. I've

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/ --- (Updated May 23, 2014, 7:12 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/ --- (Updated May 23, 2014, 7:13 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/ --- (Updated May 23, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43868 --- Also passes old and new end-to-end tests. - Bill Farner On May 23

Re: Review Request 21830: Add support for multiple API response messages, only apply informative messages.

2014-05-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43870 --- Ship it! Ship It! - David McLaughlin On May 23, 2014, 7:30 p.m.,

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/#review43871 --- Ship it! Ship It! - David McLaughlin On May 23, 2014, 6:54 p.m.,

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-23 Thread Bill Farner
> On May 23, 2014, 6:53 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 45 > > > > > > Mixed final and non-final classes in this file - converge on one? Dropped th

Re: Review Request 21849: Enable some additional PMD rules, and fix sources to satisfy them.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21849/ --- (Updated May 23, 2014, 8:26 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/#review43875 --- Seems like the config bar should be above the tabs, or only on the '

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread David McLaughlin
> On May 23, 2014, 8:43 p.m., Bill Farner wrote: > > Seems like the config bar should be above the tabs, or only on the 'Active > > tasks' tab. > > > > Also, is it possible to include counts on the tab headings? I worry people > > will overlook problems if there's no call to action on complet

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ --- (Updated May 23, 2014, 8:54 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Suman Karumuri
> On May 23, 2014, 8:43 p.m., Bill Farner wrote: > > Seems like the config bar should be above the tabs, or only on the 'Active > > tasks' tab. > > > > Also, is it possible to include counts on the tab headings? I worry people > > will overlook problems if there's no call to action on complet

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ --- (Updated May 23, 2014, 9:16 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/ --- (Updated May 23, 2014, 9:17 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Bill Farner
> On May 23, 2014, 8:43 p.m., Bill Farner wrote: > > Seems like the config bar should be above the tabs, or only on the 'Active > > tasks' tab. > > > > Also, is it possible to include counts on the tab headings? I worry people > > will overlook problems if there's no call to action on complet

Re: Review Request 21825: Added tabs for active and completed tasks in Job page.

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/#review43882 --- Ship it! Ship It! - Bill Farner On May 23, 2014, 9:17 p.m., Suma

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/#review43883 --- Ship it! Ship It! - Bill Farner On May 23, 2014, 7:13 p.m., Suma

Re: Review Request 21848: Fix command typo

2014-05-23 Thread Joe Smith
> On May 23, 2014, 5:27 a.m., Mark Chu-Carroll wrote: > > Ship It! Any chance you could commit this for me? :) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21848/#review43828 ---

Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- Review request for Aurora. Repository: aurora Description --- AURORA-475

Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- Review request for Aurora. Repository: aurora Description --- AURORA-475

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- (Updated May 23, 2014, 11:38 p.m.) Review request for Aurora. Bugs: AURORA-47

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- (Updated May 23, 2014, 11:38 p.m.) Review request for Aurora. Bugs: AURORA-47

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- (Updated May 23, 2014, 11:39 p.m.) Review request for Aurora. Bugs: AURORA-47

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- (Updated May 23, 2014, 11:52 p.m.) Review request for Aurora. Changes ---

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-23 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285/#review43886 --- Ship it! Ship It! - David Robinson On May 21, 2014, 3:51 a.m., J

Re: Review Request 21386: Add support for custom project to list-missing-shipits

2014-05-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21386/#review43890 --- Kevin - can you take a look at this? - Bill Farner On May 15, 201

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- (Updated May 24, 2014, 5:40 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21882/ --- (Updated May 24, 2014, 5:44 a.m.) Review request for Aurora and Bill Farner.