Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21791/#review44340 --- Pushed to master. - Suman Karumuri On May 28, 2014, 8:32 p.m., Da

Re: Review Request 22065: Fix /cron endpoint.

2014-05-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/#review44341 --- Ship it! Ship It! - Suman Karumuri On May 30, 2014, 1:32 a.m., K

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Mark Chu-Carroll
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /v

Review Request 22082: Modify the way that config binding helpers get registered.

2014-05-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22082/ --- Review request for Aurora, Antoine Tollenaere and David McLaughlin. Bugs: auror

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Bill Farner
> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Mark Chu-Carroll
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /v

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Bill Farner
> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Mark Chu-Carroll
> On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /v

Re: Review Request 22082: Modify the way that config binding helpers get registered.

2014-05-30 Thread Antoine Tollenaere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22082/#review44379 --- Ship it! Ship It! - Antoine Tollenaere On May 30, 2014, 1:57 p.m

Re: Review Request 22082: Modify the way that config binding helpers get registered.

2014-05-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22082/#review44394 --- Mark - would you mind adding a committer to the People line? We don

Re: Review Request 22082: Modify the way that config binding helpers get registered.

2014-05-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22082/ --- (Updated May 30, 2014, 2:09 p.m.) Review request for Aurora, Antoine Tollenaere

Re: Review Request 22065: Fix /cron endpoint.

2014-05-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/#review44396 --- Ship it! Ship It! - David McLaughlin On May 30, 2014, 1:32 a.m.,

Re: Review Request 22082: Modify the way that config binding helpers get registered.

2014-05-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22082/#review44399 --- Ship it! Ship It! - David McLaughlin On May 30, 2014, 6:09 p.m.,

Review Request 22092: Added a comment to .gitignore.

2014-05-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22092/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-485 https://issues.

Re: Review Request 21994: Fixing incorrect .gitignore rule.

2014-05-30 Thread Suman Karumuri
> On May 29, 2014, 1:16 a.m., Bill Farner wrote: > > .gitignore, line 15 > > > > > > Please follow up with a comment explaining why this is necessary. > > Clearly it's important, so it's good form to call out why it's

Re: Review Request 22032: first draft of a "developing client v2" document.

2014-05-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44415 --- docs/developing-aurora-client.md

Re: Review Request 22032: first draft of a "developing client v2" document.

2014-05-30 Thread Mark Chu-Carroll
> On May 29, 2014, 5:10 p.m., Henry Saputra wrote: > > Small nits but looks good overall. Will also you add remote debugging info > > for the scheduler in the developing-aurora-scheduler.md doc? I'm afraid I'll have to defer to someone else for that - I haven't done it, so I have no idea what'

Re: Review Request 22032: first draft of a "developing client v2" document.

2014-05-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 30, 2014, 3:40 p.m.) Review request for Aurora, David McLaughlin a

Re: Review Request 22092: Added a comment to .gitignore.

2014-05-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22092/#review44417 --- It wasn't obvious, but in the last review i was subtly trying to nud

Re: Review Request 22032: first draft of a "developing client v2" document.

2014-05-30 Thread Kevin Sweeney
> On May 30, 2014, 12:38 p.m., Mark Chu-Carroll wrote: > > docs/developing-aurora-client.md, line 5 > > > > > > The executor is an important part of aurora - but how is it part of the > > client? The executor is entirel

Re: Review Request 22032: first draft of a "developing client v2" document.

2014-05-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- (Updated May 30, 2014, 4:14 p.m.) Review request for Aurora, David McLaughlin a

Review Request 22094: Updating vagrant cleanup steps.

2014-05-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22094/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-499 https://issues.

Re: Review Request 22094: Updating vagrant cleanup steps.

2014-05-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22094/#review44421 --- docs/vagrant.md

Re: Review Request 22094: Updating vagrant cleanup steps.

2014-05-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22094/ --- (Updated May 30, 2014, 9:08 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 22094: Updating vagrant cleanup steps.

2014-05-30 Thread Maxim Khutornenko
> On May 30, 2014, 8:54 p.m., Bill Farner wrote: > > docs/vagrant.md, line 17 > > > > > > Better advice is likely to advise removal of VM entries in virtualbox > > itself, through the GUI or VBoxManage. Sure, that's e

Re: Review Request 22094: Updating vagrant cleanup steps.

2014-05-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22094/#review44424 --- Ship it! docs/vagrant.md

Re: Review Request 22094: Updating vagrant cleanup steps.

2014-05-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22094/ --- (Updated May 30, 2014, 9:13 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Maxim Khutornenko
> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /

Re: Review Request 21440: Implementing parallel updater

2014-05-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 30, 2014, 10:08 p.m.) Review request for Aurora, Mark Chu-Carroll

Review Request 22097: Remove unused thrift flags from scheduler

2014-05-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22097/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository:

Re: Review Request 22032: first draft of a "developing client v2" document.

2014-05-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44436 --- Ship it! Ship It! - Kevin Sweeney On May 30, 2014, 1:14 p.m., Ma

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-30 Thread Bill Farner
> On May 29, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > Why? > > > > Right now, I do a lot of debugging of the client using vagrant. My typical > > workflow is: > > - Make the change in my git workspace. > > - Commit it to a branch. > > - vagrant ssh into the virtual cluster > > - git pull /