Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 1:01 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 268 > > > > > > Remember - javadoc is like html. These newlines are not preserved > > unl

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 23, 2014, 4:12 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 1:01 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1350 > > > > > > How about 'validateInstanceAddition'? I'm not tied to

Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 1:01 a.m., Bill Farner wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 547 > > > > > > Can you update JobUpdateControllerImpl to use this as well? > > > > Also, you shoul

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 23, 2014, 4:48 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25466/#review54282 --- psutil 2.1.2 now available, since we are upgrading here might as wel

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54315 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java <

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54316 --- LGTM with some additional test coverage for the new accounting. I t

Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 8:07 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 180 > > > > > > Unless I'm missing something here, this will throw when there are > > mu

Review Request 25953: Allow optional initial and desired states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-741 https://issues.

Re: Review Request 25953: Allow optional initial and desired states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/#review54328 --- Ship it! LGTM with a few minor changes. src/main/java/org/apache/

Re: Review Request 25953: Allow optional initial and desired states.

> On Sept. 23, 2014, 8:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, > > line 87 > > > > > > You should include a precondition check for desiredState being

Re: Review Request 25953: Allow optional initial and desired states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/ --- (Updated Sept. 23, 2014, 9:10 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 1:07 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 180 > > > > > > Unless I'm missing something here, this will throw when there are > > mu

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54334 --- Ship it! LGTM mod Bill's comments and Impl suggestion - Kevin Swee

Review Request 25955: Remove about plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25955/ --- Review request for Aurora and David McLaughlin. Repository: aurora Descriptio

Re: Review Request 25955: Remove about plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25955/#review54337 --- Ship it! Ship It! - David McLaughlin On Sept. 23, 2014, 9:35 p.m

Review Request 25958: Enable beta updater in example cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25958/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: auror

Re: Review Request 25958: Enable beta updater in example cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25958/#review54345 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 23, 2014, 10:08 p

Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 8:10 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 174 > > > > > > Accept JobUpdateStore here, that's all that is used. Done. > On Sept. 23

Re: Review Request 25812: Implementing quota checking for async job updates.

> On Sept. 23, 2014, 8:07 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1469 > > > > > > Refactor this to live outside the Impl class? Schedul

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 23, 2014, 11:08 p.m.) Review request for Aurora, David McLaughli

Review Request 25963: Expose in progress and recently completed updates in UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25963/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner. Bu

Re: Review Request 25963: Expose in progress and recently completed updates in UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25963/#review54363 --- I just realised, we might want to hide the nav if beta_updates_enabl

Re: Review Request 25963: Expose in progress and recently completed updates in UI

> On Sept. 23, 2014, 11:48 p.m., David McLaughlin wrote: > > I just realised, we might want to hide the nav if beta_updates_enabled is > > false. Don't worry abou that - we'll drop the flag entirely soon. Just wanted to put a gate in place for now. - Bill -

Review Request 25970: Adding support for retryable storage errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Bu

Review Request 25969: When creating an update, store only the delta between the initial and desired states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25969/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs: AURORA-71

Re: Review Request 25963: Expose in progress and recently completed updates in UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25963/#review54371 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 25958: Enable beta updater in example cluster.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25958/#review54372 --- Ship it! In the future, please allow everyone on the 'People' line

Review Request 25972: Make thermos more cognizant of user deletions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- Review request for Aurora, Joe Smith and Kevin Sweeney. Bugs: AURORA-175 ht

Re: Review Request 25963: Expose in progress and recently completed updates in UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25963/#review54373 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 23, 2014, 11:46 p

Review Request 25974: Prevent uncaught exceptions from killing the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs:

Re: Review Request 25974: Prevent uncaught exceptions from killing the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54378 --- I'm not sure a TASK_FAILED: KeyError: 'getpwuid() uid:0 not found' i