---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/
---
Review request for Aurora, David McLaughlin and Joshua Cohen.
Bugs: aurora-831
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/#review56541
---
This looks good to me, just a couple of questions about the tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/#review56545
---
src/test/python/apache/aurora/client/cli/test_help.py
On Oct. 14, 2014, 1 p.m., Mark Chu-Carroll wrote:
src/test/python/apache/aurora/client/cli/test_help.py, line 75
https://reviews.apache.org/r/26688/diff/1/?file=720844#file720844line75
Yes, they are guaranteed to be unique. The argparse framework that this
is built on checks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review56561
---
Mark?
- Maxim Khutornenko
On Oct. 8, 2014, 11:46 p.m., Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26478/#review56562
---
Ping? Any progress here?
- Bill Farner
On Oct. 9, 2014, 2:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26711/
---
Review request for Aurora, Joshua Cohen and Kevin Sweeney.
Bugs: AURORA-836
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26711/#review56594
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 14, 2014, 10:53 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26714/
---
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26664/#review56599
---
On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 183
https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183
Isn't this unsafe? Seems like we need to treat the state the same in
On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 183
https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183
Isn't this unsafe? Seems like we need to treat the state the same in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review56610
---
Ship it!
Sorry for the delay on this, i didn't realize i was on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/
---
Review request for Aurora.
Repository: aurora
Description
---
Use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/
---
(Updated Oct. 14, 2014, 5:23 p.m.)
Review request for Aurora, Kevin Sweeney
On Oct. 14, 2014, 11:26 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 183
https://reviews.apache.org/r/26664/diff/1/?file=719801#file719801line183
Isn't this unsafe? Seems like we need to treat the state the same in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26664/#review56621
---
Ship it!
src/main/python/apache/aurora/executor/gc_executor.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26720/
---
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26720/#review56632
---
Ship it!
build-support/thrift/Makefile
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26716/#review56631
---
Ship it!
Ship It!
- Bill Farner
On Oct. 15, 2014, 12:23 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26714/#review56633
---
Should we rather do it in 0.7.0 as deprecation warning suggests? If
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26478/
---
(Updated Oct. 14, 2014, 6:32 p.m.)
Review request for Aurora, David
On Oct. 9, 2014, 8:30 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java,
line 86
https://reviews.apache.org/r/26478/diff/2/?file=716376#file716376line86
Method interceptors should work fine for package-priviate methods [1].
On Oct. 15, 2014, 12:02 a.m., Bill Farner wrote:
Sorry for the delay on this, i didn't realize i was on the hook to commit.
Now on master:
$ git log -1
commit 72fed752fcdbacf0f29e7eaef56c177f5ec9fcf0
Author: Joshua Cohen jco...@twopensource.com
Date: Tue Oct 14
24 matches
Mail list logo