Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:02 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 3:35 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59771 --- Master (9ef905a) is red with this patch.

Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-456

Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59814 --- Ship it! Ship It! - Bill Farner On Nov. 3, 2014, 11:09 p.m.,

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59816 --- Ship it! Ship It! - Kevin Sweeney On Nov. 4, 2014, 11:55 a.m.,

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59821 --- Master (9ef905a) is red with this patch.

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 1:22 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59840 --- src/test/python/apache/aurora/client/commands/test_version.py

Review Request 27591: Remove --bind-var for cron deschedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-854

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59844 --- Ship it! Master (9ef905a) is green with this patch.

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

On Nov. 3, 2014, 11:40 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/async/KillRetry.java, lines 84-85 https://reviews.apache.org/r/27467/diff/3/?file=747840#file747840line84 Since you're not using atomic CAS operations here you don't gain anything by using

Re: Review Request 27591: Remove --bind-var for cron deschedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59851 --- Master (9847b7b) is red with this patch.

Review Request 27598: Fixing the log replay for the job update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-912

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59867 --- Ship it! Master (9847b7b) is green with this patch.

Re: Review Request 27591: Remove --bind-var for cron deschedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59869 --- Can you re-post your diff to prove a green response from the build

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59868 --- I'm not a fan of the refactor. For one, static analysis tools will

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 11:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 3:28 p.m., Bill Farner wrote: I'm not a fan of the refactor. For one, static analysis tools will no longer catch missing case coverage, and we have to expose the internal detail of this map. Instead, the unit test should self-check to make sure that it is

Review Request 27601: Adding resource consumption calculation for cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/ --- Review request for Aurora. Repository: aurora Description --- Fixing

Re: Review Request 27601: Adding resource consumption calculation for cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/ --- (Updated Nov. 5, 2014, 1:08 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27601: Adding resource consumption calculation for cron jobs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/#review59905 --- Master (9847b7b) is red with this patch.

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 4:43 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 318 https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318 why not initialize this inline? Maxim Khutornenko wrote: Not sure I

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27598/#review59917 --- Master (9847b7b) is red with this patch.

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/#review59918 --- Ship it!

Re: Review Request 27598: Fixing the log replay for the job update history pruner.

On Nov. 4, 2014, 4:43 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java, line 318 https://reviews.apache.org/r/27598/diff/1/?file=749747#file749747line318 why not initialize this inline? Maxim Khutornenko wrote: Not sure I

Re: Review Request 27591: Remove --bind-var for cron deschedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 6:52 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27591: Remove --bind-var for cron deschedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59923 --- Master (9847b7b) is red with this patch.

Re: Review Request 27591: Remove --bind-var for cron deschedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59924 --- Bill, what should I do now? - Zameer Manji On Nov. 4, 2014, 6:52

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/ --- (Updated Nov. 4, 2014, 7:34 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27586: Increase robustness when reading PEX-INFO

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27586/#review59927 --- Master (9847b7b) is red with this patch.

Re: Review Request 27591: Remove --bind-var for cron deschedule.

On Nov. 5, 2014, 3:12 a.m., Zameer Manji wrote: Bill, what should I do now? I'll run it locally to confirm the patch. - Bill --- This is an automatically generated e-mail. To reply, visit: