Re: Review Request 24982: Fixing checkstyle build break.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/#review51293 --- Ship it! - Zameer Manji On Aug. 22, 2014, 8:49 a.m., Maxim

Re: Review Request 25208: Increment Mesos version to 0.20.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52112 --- Ship it! Ship It! - Zameer Manji On Sept. 2, 2014, 5:45 p.m

Re: Review Request 25257: Add a separate main class that runs the scheduler in local mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25257/#review52119 --- Ship it! LGTM - Zameer Manji On Sept. 2, 2014, 4:39 p.m., Bill

Re: Review Request 25337: Preserve executor HealthCheckerThread name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52318 --- Ship it! Ship It! - Zameer Manji On Sept. 4, 2014, 3:50 a.m

Re: Review Request 25356: Add a factory to produce OneWayUpdate instances based on job state and update settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25356/#review52361 --- Ship it! Ship It! - Zameer Manji On Sept. 4, 2014, 2:19 p.m

Review Request 25366: Set principal field in FrameworkInfo struct.

: https://reviews.apache.org/r/25366/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e Diff: https://reviews.apache.org/r/25366/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 25337: Preserve executor HealthCheckerThread name

<https://reviews.apache.org/r/25337/#comment91167> I don't think this is supposed to be here. - Zameer Manji On Sept. 4, 2014, 5:24 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 25455: Deprecating PopulateJobResult.populated thrift field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25455/#review52642 --- Ship it! Ship It! - Zameer Manji On Sept. 8, 2014, 2:46 p.m

Review Request 25483: Transaction all SQL under MemStorage

) --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 25505: Make "aurora job status" JSON output more friendly.

tps://reviews.apache.org/r/25505/#comment92085> shouldn't this be true or false? - Zameer Manji On Sept. 10, 2014, 8:56 a.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 25519: Adding "get_scheduler" admin command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52929 --- Ship it! Thanks for doing this so quickly. - Zameer Manji On

Re: Review Request 25505: Make "aurora job status" JSON output more friendly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52930 --- Ship it! Ship It! - Zameer Manji On Sept. 10, 2014, 12:34 p.m

Re: Review Request 25543: Update to pants 0.0.23.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/#review53048 --- Ship it! Ship It! - Zameer Manji On Sept. 11, 2014, 9:13 a.m

Re: Review Request 25481: Adding JobUpdateRequest validation.

/SchedulerThriftInterface.java <https://reviews.apache.org/r/25481/#comment92464> I'm a little unfamilar with JobUpdateRequest and this RPC but it seems we should update "StartJobUpdateResult" to have a message field that we can surface to the user? - Zameer Manji On Sept. 9, 20

Re: Review Request 25529: Add a controller for job updates.

are these errors going to be surfaced to the user? - Zameer Manji On Sept. 10, 2014, 9:53 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-

Re: Review Request 25582: Fix error in client "task ssh" command when the job isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25582/#review53181 --- Ship it! Ship It! - Zameer Manji On Sept. 12, 2014, 7:34 a.m

Re: Review Request 25671: Instruct thrift to generate private fields in java.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25671/#review53435 --- Ship it! Ship It! - Zameer Manji On Sept. 15, 2014, 4:02 p.m

Re: Review Request 25529: Add a controller for job updates.

owledge to give a ship to this change. - Zameer Manji On Sept. 15, 2014, 5:39 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 25815: Improve performance of fetching host attributes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/#review53989 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2014, 11:42 a.m

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

onents/underscore/package.json > > 3rdparty/javascript/bower_components/underscore/underscore.js > > 3rdparty/javascript/thrift.js > > build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 392b4f7bc9d5352ed536ff83eafb4175e4860aa1 > > > src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora.png > > > > src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora_logo.png > > > src/main/resources/org/apache/aurora/scheduler/http/assets/images/viz.png > > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html > > > src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > > src/main/resources/org/apache/aurora/scheduler/http/ui/error.html > > > src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/home.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/index.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js > > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js > > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html > > > src/main/resources/org/apache/aurora/scheduler/http/ui/schedulingDetail.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/taskLink.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html > > src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html > > src/main/resources/scheduler/assets/index.html PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java > c2679c7f191bdf80ee9025e8cb3e078a4647fa4b > > > > Diff: https://reviews.apache.org/r/25835/diff/ > > > > > > Testing > > --- > > > > ./gradlew build -Pq > > > > Confirmed everything works in scheduler UI in vagrant image. > > > > One thing I've seen locally is lost tasks in vagrant, but I *think* > that's just due to my image being somehow misconfigured, and not these > changes. I'm going to destroy and rebuild the image to see if that cleans > things up. > > > > > > Thanks, > > > > Joshua Cohen > > > > > > -- Zameer Manji

Re: Review Request 25914: use javax.inject.Qualifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/#review54206 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 4:35 p.m

Re: Review Request 25918: Improve aurora command-line help using metavars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/#review54239 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 6:53 p.m

Review Request 25974: Prevent uncaught exceptions from killing the executor.

79a24855b2a68271b7478395dfdadab8755c3af2 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji

Re: Review Request 26004: Add "aurora update list" and "aurora update status" commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review54457 --- Ship it! Ship It! - Zameer Manji On Sept. 24, 2014, 1:24 p.m

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

er.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Z

Re: Review Request 25481: Adding JobUpdateRequest validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54613 --- Ship it! Ship It! - Zameer Manji On Sept. 25, 2014, 3:02 p.m

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

ommon/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54623 --- On Sept. 25, 2014, 2:39 p.m., Zameer Manji wrote: > > --- > This

Re: Review Request 26123: Fail the build on lack of test coverage.

these classes. - Zameer Manji On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 26123: Fail the build on lack of test coverage.

> On Sept. 27, 2014, 4:38 p.m., Zameer Manji wrote: > > Once this is commited, please make tickets for adding tests to these > > classes. > > Bill Farner wrote: > I'm not sure how to best do this without either creating a ton of tickets > that are bou

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54890 --- Pinging Brian and Kevin to this review. - Zameer Manji On Sept

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

ommon/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji

Re: Review Request 26137: Fix help for new update command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review54894 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2014, 8:05 a.m

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

pache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

g KeyErrors from > > make_serverset.) done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54916 --------

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

ommon/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing (updated) --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 26270: Make the client invocation code actually use the exit codes returned by the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26270/#review55217 --- Ship it! Ship It! - Zameer Manji On Oct. 2, 2014, 9:07 a.m

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

l. To reply, visit: https://reviews.apache.org/r/25974/#review55161 ------- On Sept. 30, 2014, 5:17 p.m., Zameer Manji wrote: > > --- > This is an automatic

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55158 ------- On Sept. 30, 2014, 5:17 p.m., Zameer Manji wrote: > > --- > This is an autom

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

ommon/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

ommon/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Review Request 26324: Increase timeout for PyPI HTTP fetches.

/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 26328: Add "aurora update list" and "aurora update status" commands.

tps://reviews.apache.org/r/26328/#comment95746> I think we should put an ISO formatted date like `datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d %H:%M:%S')`. - Zameer Manji On Oct. 3, 2014, 1:47 p.m., Mark C

Re: Review Request 26328: Add "aurora update list" and "aurora update status" commands.

> On Oct. 3, 2014, 1:56 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/client/cli/__init__.py, line 434 > > <https://reviews.apache.org/r/26328/diff/1/?file=713687#file713687line434> > > > > I think we should put an ISO formatted date like >

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55402 --- Pinging Kevin for final ship it and commit. - Zameer Manji On

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55520 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 7:57 a.m

Re: Review Request 26372: Update as property

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55521 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 9:55 a.m

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55541 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 9:58 a.m

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.

/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review3 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 11:55 a.m

Re: Review Request 26378: Upgrade to pants 0.0.24

interpreter enforcement. - Zameer Manji On Oct. 6, 2014, 12:47 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 26391: Remove special casing of 'rack' attribute.

mulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 Diff: https://reviews.apache.org/r/26391/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji

Re: Review Request 26417: Change JSON result of "job status" when job isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55664 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 10:12 a.m

Re: Review Request 26422: Drop syncrhonized from JobUpdateEventSubscriber

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/#review55700 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 12:28 p.m

Review Request 26430: Remove deprecated configuration options.

/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review55750 --- Ping Kevin. - Zameer Manji On Oct. 6, 2014, 12:02 p.m., Zameer

Re: Review Request 26448: Move the error-log seed file to a user specified directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26448/#review55838 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 10:32 a.m

Re: Review Request 26445: Fix error in incorrect deprecation warning on v1 "ssh" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26445/#review55840 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 8:58 a.m

Re: Review Request 26430: Remove deprecated configuration options.

onfig/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 26430: Remove deprecated configuration options.

/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Review Request 26464: Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no coverage.

/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/#review55916 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 5:15 p.m

Re: Review Request 26383: Health Check Disabler

cutor/common/health_checker.py <https://reviews.apache.org/r/26383/#comment96297> Why add a default here? - Zameer Manji On Oct. 8, 2014, 5:46 p.m., David Pan wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 26383: Health Check Disabler

> On Oct. 8, 2014, 6:09 p.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py, line 41 > > <https://reviews.apache.org/r/26383/diff/2/?file=716291#file716291line41> > > > > Why add a default value here? > >

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review55943 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 7:39 p.m

Re: Review Request 26383: Health Check Disabler

ally generated e-mail. To reply, visit: > https://reviews.apache.org/r/26383/ > --- > > (Updated Oct. 8, 2014, 6:56 p.m.) > > > Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. > > > Repo

Re: Review Request 26504: Restore JDK8 compatibility

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/#review56012 --- Ship it! Ship It! - Zameer Manji On Oct. 9, 2014, 9:50 a.m

Re: Review Request 26383: Health Check Disabler

ze has no concept of time > > at all. If the file is there, don't perform health checks. When you want > > to re-enable health checks, delete the file. Happy to hear what others > > think about that. > > Zameer Manji wrote: > Doesn't this mean us

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

ocoTestReport'.> Thanks for adding the >>>> first test coverage to: >>>> org/apache/aurora/scheduler/async/OfferQueue$OfferQueueImpl$2 please >>>> remove it from the legacyClassesWithoutCoverage list. Expression: >>>> (coverage == 0). Valu

Re: Review Request 26430: Remove deprecated configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/#review56417 --- Pinging Mark and Wickman to this review. - Zameer Manji On Oct

Re: Review Request 26430: Remove deprecated configuration options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/#review56565 --- Ping Pong - Zameer Manji On Oct. 8, 2014, 3:29 p.m., Zameer

Review Request 26716: Use JobKey when getting roles to authenticate against.

--- Thanks, Zameer Manji

Re: Review Request 26716: Use JobKey when getting roles to authenticate against.

/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e Diff: https://reviews.apache.org/r/26716/diff/ Testing (updated) --- ./gradlew clean test Thanks, Zameer Manji

Re: Review Request 26720: Limit the amount of work done while bootstrapping thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26720/#review56627 --- Ship it! Ship It! - Zameer Manji On Oct. 14, 2014, 5:59 p.m

Re: Review Request 26688: Fix errors in help rendering:

<https://reviews.apache.org/r/26688/#comment97118> Is this a python standard for log levels? Could the help show all possible values? - Zameer Manji On Oct. 15, 2014, 9:46 a.m., Mark Chu-Carroll wrote: > > --- > This is a

Re: Review Request 26688: Fix errors in help rendering:

/reviews.apache.org/r/26688/#review56737 --- On Oct. 15, 2014, 9:46 a.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26688/

Re: Review Request 26688: Fix errors in help rendering:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56750 --- Ship it! Ship It! - Zameer Manji On Oct. 15, 2014, 10:57 a.m

Re: Review Request 26809: Add a metric to count offers that do not provide sufficent resources to launch a GC Executor

/GcExecutorLauncher.java <https://reviews.apache.org/r/26809/#comment97385> shouldn't this just be 'gc_executor_insufficient_offers'? - Zameer Manji On Oct. 16, 2014, 10:07 a.m., Joe Smith wrote: > > --- > This is an auto

Re: Review Request 26430: Remove deprecated configuration options.

src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 26802: Set a default for the error log dir

. - Zameer Manji On Oct. 16, 2014, 10:51 a.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26802/ > --

Review Request 26821: Handle resourceOffers callback asynchronsly.

/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji

Re: Review Request 26821: Handle resourceOffers callback asynchronsly.

/ Testing --- ./gradlew clean build Thanks, Zameer Manji

Re: Review Request 26430: Remove deprecated configuration options.

901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji

Re: Review Request 26821: Handle resourceOffers callback asynchronsly.

26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji

Re: Review Request 26821: Handle resourceOffers callback asynchronsly.

--- ./gradlew clean build Thanks, Zameer Manji

Re: Review Request 26821: Handle resourceOffers callback asynchronsly.

/ Testing --- ./gradlew clean build Thanks, Zameer Manji

Re: Review Request 26828: Remove info logging when users request json output

future to ensure that we don't have to do this process for every subcommand. - Zameer Manji On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.

> On Oct. 16, 2014, 1:11 p.m., Kevin Sweeney wrote: > > Is this still needed? I thought the checkstyle check was updated I was under this impression as well. - Zameer --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 26383: Health Check Disabler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review57019 --- Ship it! Ship It! - Zameer Manji On Oct. 16, 2014, 3:04 p.m

Re: Review Request 26852: Use mesos.native egg from ~kevints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/#review57098 --- Ship it! Ship It! - Zameer Manji On Oct. 16, 2014, 6:50 p.m

Re: Review Request 26881: Improve error messages in client commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57399 --- Ship it! Ship It! - Zameer Manji On Oct. 17, 2014, 10:58 a.m

Re: Review Request 26982: Make v2 job status look more like v1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/#review57614 --- Ship it! Thanks for also using the term instance. - Zameer Manji

Re: Review Request 26995: Download thrift from archive.a.o.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57655 --- Ship it! Ship It! - Zameer Manji On Oct. 21, 2014, 1:54 p.m

Review Request 27044: Make executor overhead configurable

, Zameer Manji

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

Why do we need to do this? - Zameer Manji On Oct. 22, 2014, 10:31 a.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 27047: Improve status command output ordering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27047/#review57841 --- Ship it! Ship It! - Zameer Manji On Oct. 22, 2014, 10:57 a.m

Re: Review Request 27009: Use virtualenv to build pants instead of pex.

well. - Zameer Manji On Oct. 22, 2014, 11:05 a.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

---- On Sept. 4, 2014, 4:36 p.m., Zameer Manji wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25366/ > ---

  1   2   3   4   5   >