Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-02-25 Thread Suman Karumuri


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 186
> > 
> >
> > Please give a more informative doc.  As it stands, it provides the same 
> > info as "struct JobStats".

Removed.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 191
> > 
> >
> > As we discussed offline, please remove this.

Removed.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 214
> > 
> >
> > Just to make sure it's not dropped — this should be removed.

Done.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/base/JobsTest.java, line 1
> > 
> >
> > missing license header

Added.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 1
> > 
> >
> > missing license header.  please set this up in intellij so it's 
> > automatic.

Added.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 21
> > 
> >
> > Please doc.

Done.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19
> > 
> >
> > Do you think this class scales to multiple consumers?  i.e. there's a 
> > bunch of hard-coded fields that work okay with the existing 2 callers, but 
> > we would need to plumb a lot more through for more broad usage.

I think so, since a lot of tests have a makeTask method in them and we can get 
rid of some redundant code that way.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 48
> > 
> >
> > ImmutableList.of(..)

Fixed.


> On Feb. 3, 2014, 10:40 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 188
> > 
> >
> > Please fix premature wrap, and add @param, @return javadoc fields.
> > 
> > Also, the term 'freshest' is ambiguous (and used interchangeably with 
> > 'latest' here and at a call site.  How about getLatestTransitionedTask?
> > 
> > Finally, please include a TODO in SchedulerThriftInterface to pull this 
> > method in there once the other caller is removed.

Done.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review33522
---


On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17303/
> ---
> 
> (Updated Jan. 24, 2014, 7:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-64
> https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added task stats to getJobs API so it can be used by the role page in the UI.
> Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant 
> classes so it can be used by the UI and the thrift API.
> Added tests for new code.
> Moved populateJobConfig call into ReadOnlyScheduler.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 06a19d80483b6949c9851b5d38fe34ac712aa75e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> b0caca73b46fba928fb718ab45a608dad4685a2f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 
> 912be189583419e7201e45650d18cd24a6a5a35b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.ja

Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-02-25 Thread Suman Karumuri


> On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Jobs.java, line 48
> > 
> >
> > This uses time so it should take a Clock instance for testing.

Since we got rid of mostRecentFailures logic, this code is dropped now.


> On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote:
> > src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java, line 19
> > 
> >
> > How would you feel about naming this TaskFixtures or TaskTestUtil?

Done.


> On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 192
> > 
> >
> > explicit orderings will throw RuntimeExceptions if they encounter a 
> > value not in the explicit set. It doesn't seem to me that STATUSES is 
> > exhaustive and I don't see test coverage to guarantee that in the future.

Good catch. Updated the list to be exhaustive. Added a test case to test the 
same.


> On Feb. 25, 2014, 11:11 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/base/Tasks.java, line 191
> > 
> >
> > Why the indirection? Why not call this latestActiveTask?

Updated comment to make this clear. Can't use latestActiveTask since a job may 
have just finished but it's taskConfig is not a representative task config for 
the job.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review33465
---


On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17303/
> ---
> 
> (Updated Jan. 24, 2014, 7:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-64
> https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added task stats to getJobs API so it can be used by the role page in the UI.
> Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant 
> classes so it can be used by the UI and the thrift API.
> Added tests for new code.
> Moved populateJobConfig call into ReadOnlyScheduler.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 06a19d80483b6949c9851b5d38fe34ac712aa75e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> b0caca73b46fba928fb718ab45a608dad4685a2f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 
> 912be189583419e7201e45650d18cd24a6a5a35b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17303/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build
> gradle run to test local UI.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>



Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-02-25 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review33465
---



src/main/java/org/apache/aurora/scheduler/base/Jobs.java


This uses time so it should take a Clock instance for testing.



src/main/java/org/apache/aurora/scheduler/base/Tasks.java


Unclear from name what this variable is for. Is this supposed to be 
ScheduleStatus.values()?



src/main/java/org/apache/aurora/scheduler/base/Tasks.java


Why the indirection? Why not call this latestActiveTask?



src/main/java/org/apache/aurora/scheduler/base/Tasks.java


explicit orderings will throw RuntimeExceptions if they encounter a value 
not in the explicit set. It doesn't seem to me that STATUSES is exhaustive and 
I don't see test coverage to guarantee that in the future.



src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java


How would you feel about naming this TaskFixtures or TaskTestUtil?


- Kevin Sweeney


On Jan. 23, 2014, 11:13 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17303/
> ---
> 
> (Updated Jan. 23, 2014, 11:13 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-64
> https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added task stats to getJobs API so it can be used by the role page in the UI.
> Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant 
> classes so it can be used by the UI and the thrift API.
> Added tests for new code.
> Moved populateJobConfig call into ReadOnlyScheduler.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 06a19d80483b6949c9851b5d38fe34ac712aa75e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> b0caca73b46fba928fb718ab45a608dad4685a2f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 
> 912be189583419e7201e45650d18cd24a6a5a35b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17303/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build
> gradle run to test local UI.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>



Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-02-03 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review33522
---



src/main/java/org/apache/aurora/scheduler/base/Jobs.java


missing license header.  please set this up in intellij so it's automatic.



src/main/java/org/apache/aurora/scheduler/base/Jobs.java


Please doc.



src/main/java/org/apache/aurora/scheduler/base/Tasks.java


ImmutableList.of(..)



src/main/java/org/apache/aurora/scheduler/base/Tasks.java


Please fix premature wrap, and add @param, @return javadoc fields.

Also, the term 'freshest' is ambiguous (and used interchangeably with 
'latest' here and at a call site.  How about getLatestTransitionedTask?

Finally, please include a TODO in SchedulerThriftInterface to pull this 
method in there once the other caller is removed.



src/main/thrift/org/apache/aurora/gen/api.thrift


Please give a more informative doc.  As it stands, it provides the same 
info as "struct JobStats".



src/main/thrift/org/apache/aurora/gen/api.thrift


As we discussed offline, please remove this.



src/main/thrift/org/apache/aurora/gen/api.thrift


Just to make sure it's not dropped — this should be removed.



src/test/java/org/apache/aurora/scheduler/base/JobsTest.java


missing license header



src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java


Do you think this class scales to multiple consumers?  i.e. there's a bunch 
of hard-coded fields that work okay with the existing 2 callers, but we would 
need to plumb a lot more through for more broad usage.


- Bill Farner


On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17303/
> ---
> 
> (Updated Jan. 24, 2014, 7:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-64
> https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added task stats to getJobs API so it can be used by the role page in the UI.
> Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant 
> classes so it can be used by the UI and the thrift API.
> Added tests for new code.
> Moved populateJobConfig call into ReadOnlyScheduler.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 06a19d80483b6949c9851b5d38fe34ac712aa75e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> b0caca73b46fba928fb718ab45a608dad4685a2f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 
> 912be189583419e7201e45650d18cd24a6a5a35b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17303/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build
> gradle run to test local UI.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>



Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-01-24 Thread Suman Karumuri


> On Jan. 24, 2014, 4:44 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 187
> > 
> >
> > I think pre-computing these stats restricts the freedom of an API 
> > consumer from displaying them differently.  Also, ambiguous names like 
> > 'recently' should absolutely be avoided.
> > 
> > Before we go down this road it would be good to collect real data 
> > showing that this aggregation is necessary on the server.  I don't doubt it 
> > is, but the exercise will give us a baseline to work with.  If it does 
> > prove necessary, it would be good to know what contributes to the problem 
> > (data transmission, memory, computation time, etc).
> > 
> > My intuition is to err on the side of returning more information unless 
> > it causes problems; allowing the client to make up its own aggregations.

Sent out detailed stats in an email. If we send all the task configs(6000) 
instead of summarizing them, the response size for our largest role would be 
roughly 900kb to 1.2MB through a conservative estimate. Summarizing all these 
stats on the server, the response size for the current data is 50-100 bytes. On 
the server side that is not a lot of compute power, but with several concurrent 
requests, it may saturate the network. On the client side, that is a lot of 
data and given that JS is single threaded, it will certainly cause UI hiccups 
and browser crashes. In this particular case, I feel sending summary data is 
better, since the users have the ability to query the tasks per job using 
another API and since most of the data we send is discarded in the current use 
case. 

I agree that recently is ambiguous. We can consider renaming it to 
tasksFailedInLast6Hours or dropping it entirely. I am in favor of the later 
since: 
a) We define the status of a service rather arbitrarily. For example, if I have 
a failed task, that I fixed in a subsequent deployment, the jobs status is 
still warning for the next 6 hours which is not accurate.
b) I am unsure how useful Stable/UnStable and Warning badges are in practice 
since most services rely on a stats gathering framework to check the health of 
their service.


> On Jan. 24, 2014, 4:44 p.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 214
> > 
> >
> > This is overloading the purpose of JobConfiguration.  It's currently 
> > "the configuration of a job", and i would prefer to not add use cases to 
> > that.
> > 
> > It would be much tidier to compose this information _with_ 
> > JobConfiguration objects in another struct.

Agreed.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review32720
---


On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17303/
> ---
> 
> (Updated Jan. 24, 2014, 7:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-64
> https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added task stats to getJobs API so it can be used by the role page in the UI.
> Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant 
> classes so it can be used by the UI and the thrift API.
> Added tests for new code.
> Moved populateJobConfig call into ReadOnlyScheduler.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 06a19d80483b6949c9851b5d38fe34ac712aa75e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> b0caca73b46fba928fb718ab45a608dad4685a2f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 
> 912be189583419e7201e45650d18cd24a6a5a35b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17303/diff/
> 
> 
> Testing
> ---
> 
> gradle clean bui

Re: Review Request 17303: Updated getJobs API to return task stats and latest task config

2014-01-24 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17303/#review32720
---



src/main/thrift/org/apache/aurora/gen/api.thrift


I think pre-computing these stats restricts the freedom of an API consumer 
from displaying them differently.  Also, ambiguous names like 'recently' should 
absolutely be avoided.

Before we go down this road it would be good to collect real data showing 
that this aggregation is necessary on the server.  I don't doubt it is, but the 
exercise will give us a baseline to work with.  If it does prove necessary, it 
would be good to know what contributes to the problem (data transmission, 
memory, computation time, etc).

My intuition is to err on the side of returning more information unless it 
causes problems; allowing the client to make up its own aggregations.



src/main/thrift/org/apache/aurora/gen/api.thrift


This is overloading the purpose of JobConfiguration.  It's currently "the 
configuration of a job", and i would prefer to not add use cases to that.

It would be much tidier to compose this information _with_ JobConfiguration 
objects in another struct.


- Bill Farner


On Jan. 24, 2014, 7:13 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17303/
> ---
> 
> (Updated Jan. 24, 2014, 7:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-64
> https://issues.apache.org/jira/browse/AURORA-64
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Added task stats to getJobs API so it can be used by the role page in the UI.
> Refactored code from SchedulerzRole and SchedulerzRoleTest into relevant 
> classes so it can be used by the UI and the thrift API.
> Added tests for new code.
> Moved populateJobConfig call into ReadOnlyScheduler.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 06a19d80483b6949c9851b5d38fe34ac712aa75e 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java 
> b0caca73b46fba928fb718ab45a608dad4685a2f 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/base/TaskUtil.java PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/http/SchedulerzRoleTest.java 
> 912be189583419e7201e45650d18cd24a6a5a35b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17303/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build
> gradle run to test local UI.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>