Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---

(Updated March 1, 2014, 5:11 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Updated client code to use renamed GetQuotaResult params.

ran ./build-support/jenkins/build.sh successfully.

Client should be updated to use the new non-prod consumption information. 
Opened AURORA-246 to track that change.

Pushing this change out to fix the broken build.


Bugs: AURORA-65
https://issues.apache.org/jira/browse/AURORA-65


Repository: aurora


Description
---

This call will be used by the role page in the UI.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/quota_check.py 
6e818a2ffe61be6d629bc1aed47ae0b9534cc65e 
  src/test/python/apache/aurora/client/api/test_quota_check.py 
4dff351ef031d9cdfadbcea5666f4e995a89cce2 

Diff: https://reviews.apache.org/r/17347/diff/


Testing
---

./gradlew clean build.


Thanks,

Suman Karumuri

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---

(Updated March 1, 2014, 2:36 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebased code with master.


Bugs: AURORA-65
https://issues.apache.org/jira/browse/AURORA-65


Repository: aurora


Description
---

This call will be used by the role page in the UI.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7b9f185cea77825e46ecfc588c72e146cd864a32 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
f9fc6bcb7fdc2380043cf673a4002886192c20c1 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 dc557718269064a202c3e4eb1272ff2b9f209ad9 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
08c4c2a4717a1c827f4cef6405d78e7db5046a00 

Diff: https://reviews.apache.org/r/17347/diff/


Testing
---

./gradlew clean build.


Thanks,

Suman Karumuri

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---

(Updated March 1, 2014, 2:33 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Updated code per review comment. Pushing now.


Bugs: AURORA-65
https://issues.apache.org/jira/browse/AURORA-65


Repository: aurora


Description
---

This call will be used by the role page in the UI.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7b9f185cea77825e46ecfc588c72e146cd864a32 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
3ee24c75f961af61048a78ec6c3f244361bed5bd 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 dc557718269064a202c3e4eb1272ff2b9f209ad9 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
4e6c51d9298bf6fc1935ec9080f38726f79e7959 

Diff: https://reviews.apache.org/r/17347/diff/


Testing
---

./gradlew clean build.


Thanks,

Suman Karumuri

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Suman Karumuri]

> On Feb. 28, 2014, 11:54 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
> >  line 1345
> > 
> >
> > Mind making this a different value, to prove that the implementation 
> > treats them differently?

Changed.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review35871
---


On Feb. 28, 2014, 11:32 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> ---
> 
> (Updated Feb. 28, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-65
> https://issues.apache.org/jira/browse/AURORA-65
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This call will be used by the role page in the UI.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7b9f185cea77825e46ecfc588c72e146cd864a32 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3ee24c75f961af61048a78ec6c3f244361bed5bd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  dc557718269064a202c3e4eb1272ff2b9f209ad9 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 4e6c51d9298bf6fc1935ec9080f38726f79e7959 
> 
> Diff: https://reviews.apache.org/r/17347/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review35890
---

Ship it!


Ship It!

- Kevin Sweeney


On Feb. 28, 2014, 3:32 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> ---
> 
> (Updated Feb. 28, 2014, 3:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-65
> https://issues.apache.org/jira/browse/AURORA-65
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This call will be used by the role page in the UI.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7b9f185cea77825e46ecfc588c72e146cd864a32 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3ee24c75f961af61048a78ec6c3f244361bed5bd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  dc557718269064a202c3e4eb1272ff2b9f209ad9 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 4e6c51d9298bf6fc1935ec9080f38726f79e7959 
> 
> Diff: https://reviews.apache.org/r/17347/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review35871
---

Ship it!



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java


Mind making this a different value, to prove that the implementation treats 
them differently?


- Bill Farner


On Feb. 28, 2014, 11:32 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> ---
> 
> (Updated Feb. 28, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-65
> https://issues.apache.org/jira/browse/AURORA-65
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This call will be used by the role page in the UI.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7b9f185cea77825e46ecfc588c72e146cd864a32 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 3ee24c75f961af61048a78ec6c3f244361bed5bd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  dc557718269064a202c3e4eb1272ff2b9f209ad9 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 4e6c51d9298bf6fc1935ec9080f38726f79e7959 
> 
> Diff: https://reviews.apache.org/r/17347/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/
---

(Updated Feb. 28, 2014, 11:32 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Merged Quota -> ResourceAggregate name change. Renamed fields to make more 
sense after the change.


Bugs: AURORA-65
https://issues.apache.org/jira/browse/AURORA-65


Repository: aurora


Description
---

This call will be used by the role page in the UI.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7b9f185cea77825e46ecfc588c72e146cd864a32 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
3ee24c75f961af61048a78ec6c3f244361bed5bd 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 dc557718269064a202c3e4eb1272ff2b9f209ad9 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
4e6c51d9298bf6fc1935ec9080f38726f79e7959 

Diff: https://reviews.apache.org/r/17347/diff/


Testing (updated)
---

./gradlew clean build.


Thanks,

Suman Karumuri

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Suman Karumuri]

> On Jan. 28, 2014, 3:36 a.m., Bill Farner wrote:
> > src/main/thrift/org/apache/aurora/gen/api.thrift, line 219
> > 
> >
> > This confirms my fear of the slippery slope of Quota becoming an 
> > overloaded term.  I'd love to call this something that doesn't already have 
> > an implied meaning about production=True.
> > 
> > Mind taking a detour to address this TODO?
> >  grep -R ResourceAggregate src/main/java/
> > src/main/java//org/apache/aurora/scheduler/quota/Quotas.java:  // 
> > TODO(Suman Karumuri): Rename Quota to something more meaningful (ex: 
> > ResourceAggregate)
> > 
> > It's really important to do this before we cut our first release (in 
> > the next few weeks in theory), since we need to adhere to a stable API at 
> > that point.

Done. https://reviews.apache.org/r/18546/

Will update this review, once the above review is merged.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review32946
---


On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> ---
> 
> (Updated Jan. 25, 2014, 12:48 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-65
> https://issues.apache.org/jira/browse/AURORA-65
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This call will be used by the role page in the UI.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17347/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17347/#review32946
---



src/main/thrift/org/apache/aurora/gen/api.thrift


This confirms my fear of the slippery slope of Quota becoming an overloaded 
term.  I'd love to call this something that doesn't already have an implied 
meaning about production=True.

Mind taking a detour to address this TODO?
 grep -R ResourceAggregate src/main/java/
src/main/java//org/apache/aurora/scheduler/quota/Quotas.java:  // 
TODO(Suman Karumuri): Rename Quota to something more meaningful (ex: 
ResourceAggregate)

It's really important to do this before we cut our first release (in the 
next few weeks in theory), since we need to adhere to a stable API at that 
point.


- Bill Farner


On Jan. 25, 2014, 12:48 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17347/
> ---
> 
> (Updated Jan. 25, 2014, 12:48 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-65
> https://issues.apache.org/jira/browse/AURORA-65
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This call will be used by the role page in the UI.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  cf9099f307efa23ca34634e3512d9cdbebfa82f2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 74010379baa2e47cefc228943f766c7b3a8b0d97 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  6cefdfad469a9b69a5291ad46be1df14b443472e 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 42fdca2759f15d007bee058485c237268c57597a 
> 
> Diff: https://reviews.apache.org/r/17347/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>