Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Suman Karumuri
On Jan. 28, 2014, 3:37 a.m., Bill Farner wrote: Can you also attach the JIRA issue please? Done. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32947

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Suman Karumuri
On Jan. 28, 2014, 3:32 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 384 https://reviews.apache.org/r/17430/diff/1/?file=451962#file451962line384 Thinking out loud, a helper function reduces some duplication, and

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33041 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/ --- (Updated Jan. 28, 2014, 10:17 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Suman Karumuri
On Jan. 28, 2014, 9:02 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, line 1087 https://reviews.apache.org/r/17430/diff/2/?file=453063#file453063line1087 This task needs to be different from task1 in some way,

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33074 --- Ship it! Ship It! - Bill Farner On Jan. 28, 2014, 10:17 p.m.,

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33076 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 2:17 p.m.,

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32945 ---

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review32947 --- Can you also attach the JIRA issue please? - Bill Farner On Jan.