Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Jonathan Boulle
> On Feb. 3, 2014, 6:50 p.m., Jonathan Boulle wrote: > > src/main/python/apache/aurora/client/commands/admin.py, lines 174-181 > > > > > > hmm, log.error is nonfatal, so you should probably die() in these two > > case

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33458 --- src/main/python/apache/aurora/client/commands/admin.py

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33450 --- Ship it! Looks like Mark merged this to master, it's 4abccc3. Than

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33358 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 31, 2014, 2:52 p.m.

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 7:52 p.m.) Review request for Aurora and Mark Chu-Carro

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33345 --- src/main/python/apache/aurora/client/commands/admin.py

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33344 --- Ship it! Ship It! - Mark Chu-Carroll On Jan. 31, 2014, 2:34 p.m.

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 7:34 p.m.) Review request for Aurora and Mark Chu-Carro

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/ --- (Updated Jan. 31, 2014, 6:46 p.m.) Review request for Aurora and Mark Chu-Carro

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17581/#review33297 --- Thanks a ton for the patch! Aurora leans heavily on open-sourced co