Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33750 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 5, 2014, 5:07 p.m.,

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 5, 2014, 10:07 p.m.) Review request for Aurora, Mark Chu-Carroll,

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-05 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33723 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33559 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 3, 2014, 9 p.m., D

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread David Robinson
> On Feb. 3, 2014, 4:07 p.m., Maxim Khutornenko wrote: > > src/test/python/apache/aurora/client/api/test_restarter.py, line 41 > > > > > > Mind adding a simple test with rollback_on_failure=False here? Restarter doesn'

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 3, 2014, 9 p.m.) Review request for Aurora, Mark Chu-Carroll, Max

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33429 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-02 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/ --- (Updated Feb. 3, 2014, 3:18 a.m.) Review request for Aurora, Mark Chu-Carroll,

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17645/#review33410 --- Ship it! i suggest another ack from at least maxim or mark on this