Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/ --- (Updated Feb. 13, 2014, 10:56 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Suman Karumuri
> On Feb. 13, 2014, 6:29 p.m., Suman Karumuri wrote: > > src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java, line > > 40 > > > > > > It is not logged by the library. I prefer to have this since it >

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34403 --- Ship it! LGTM mod redundant redundant logging - Kevin Sweeney On

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34399 --- Ship it! LGTM mod redundant logging. - Bill Farner On Feb. 12, 2

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Bill Farner
> On Feb. 13, 2014, 6:29 p.m., Suman Karumuri wrote: > > src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java, line > > 40 > > > > > > It is not logged by the library. I prefer to have this since it >

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34387 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java <

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34339 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java <

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34340 --- src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.jav