Re: Review Request 18546: Renamed Quota to ResourceAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35827 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 27, 2014, 8:32

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

On Feb. 28, 2014, 2:40 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, line 52 https://reviews.apache.org/r/18546/diff/2/?file=506590#file506590line52 Mind adding the ticket that tracks collapsing work? AURORA-105? Done.

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 28, 2014, 9:48 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

On Feb. 26, 2014, 6:54 p.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35718 --- Mostly minor nits aside from sneaky commenting out of asserts in

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote: Mostly minor nits aside from sneaky commenting out of asserts in tests. Thanks for the comments. Was trying to get the review out. Fixed the flaky test and merged the fix into this branch. On Feb. 27, 2014, 10:57 p.m., Bill Farner wrote:

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/ --- (Updated Feb. 28, 2014, 1:32 a.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35751 --- Ship it!

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18546/#review35756 --- Ship it!