Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/
---

(Updated March 22, 2014, 12:30 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments


Bugs: AURORA-261
https://issues.apache.org/jira/browse/AURORA-261


Repository: aurora


Description
---

Part 1: Introducing TaskState internal enum facilitate task deletion coming 
next.

The only functional change in this CR is dropping TaskStateMachine.getState(). 
Rest is ScheduleStatus to TaskState conversion.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
  src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
77380d9aaab99a9ad739bbc22251232354133c8d 

Diff: https://reviews.apache.org/r/19436/diff/


Testing
---

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko

Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38240
---



src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java


Actually, both previousState and the previousState.getStatus() could be 
nulls here. Converted previousState to Optional to avoid relying on internal 
logic (i.e. previousState.getStatus() should NOT return null under normal 
conditions) and return null if either previousState is null or 
previousState.getStatus() is null.


- Maxim Khutornenko


On March 21, 2014, 7:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 21, 2014, 7:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Introducing TaskState internal enum facilitate task deletion coming 
> next.
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

> On March 22, 2014, 12:10 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line 
> > 573
> > 
> >
> > return previousState.getStatus().orNull()

Ah, another good feature of Optional. Thanks!


> On March 22, 2014, 12:10 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java, line 
> > 140
> > 
> >
> > s/this.//

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38237
---


On March 21, 2014, 7:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 21, 2014, 7:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Introducing TaskState internal enum facilitate task deletion coming 
> next.
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38237
---

Ship it!



src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java


s/this.//



src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java


return previousState.getStatus().orNull()


- Bill Farner


On March 21, 2014, 7:42 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 21, 2014, 7:42 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Introducing TaskState internal enum facilitate task deletion coming 
> next.
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/
---

(Updated March 21, 2014, 7:42 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-261
https://issues.apache.org/jira/browse/AURORA-261


Repository: aurora


Description (updated)
---

Part 1: Introducing TaskState internal enum facilitate task deletion coming 
next.

The only functional change in this CR is dropping TaskStateMachine.getState(). 
Rest is ScheduleStatus to TaskState conversion.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
  src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
77380d9aaab99a9ad739bbc22251232354133c8d 

Diff: https://reviews.apache.org/r/19436/diff/


Testing
---

./build-support/jenkins/build.sh 


Thanks,

Maxim Khutornenko

Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

> On March 21, 2014, 5:16 p.m., Maxim Khutornenko wrote:
> > Just to make things clear, this changelist is not addressing the 
> > refactoring required to actually fix the problem. It's just the first 
> > atomic change that sets us up for the following:
> > - Persisting SANDBOX_DELETED when transitioning from terminal states.
> > - Using DELETED state to drive task deletion through StateManager.
> > - UI changes to expose SANDBOX_DELETED.
> > 
> > Given the complexity, I am trying to split the entire work into manageable 
> > chunks to make sure we get it right.
> 
> Bill Farner wrote:
> Thanks for the explanation.  I'd be more comfortable if the name were not 
> changed yet.  Even though you plan to change it soon, i'd like for the name 
> and logic to follow each other.  Just the introduction of the internal enum 
> would make the intention much more clear to me.

No objection from my side. Will revert back to UNKNOWN for now. Just means more 
diff to consume in the next phase :)


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38123
---


On March 20, 2014, 12:20 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 20, 2014, 12:20 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Renaming of UNKNOWN to SANDBOX_DELETED.
> 
> Also, introducing the TaskState internal enum to facilitate task deletion 
> coming next. 
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 4ac218b8f25be5e9e6b6243558af4258efe6e61a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 4a866b2d6041a592692812eb3472db744d21e194 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> a4e9464f7d5d3f5a640b62557c3e29f2f1566985 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> 102fe04f8d3a7142a0cd58251e16d31e8d4a433d 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 24949c043b16a35a7960ed0a40b79f0981179eae 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Bill Farner]

> On March 21, 2014, 5:16 p.m., Maxim Khutornenko wrote:
> > Just to make things clear, this changelist is not addressing the 
> > refactoring required to actually fix the problem. It's just the first 
> > atomic change that sets us up for the following:
> > - Persisting SANDBOX_DELETED when transitioning from terminal states.
> > - Using DELETED state to drive task deletion through StateManager.
> > - UI changes to expose SANDBOX_DELETED.
> > 
> > Given the complexity, I am trying to split the entire work into manageable 
> > chunks to make sure we get it right.

Thanks for the explanation.  I'd be more comfortable if the name were not 
changed yet.  Even though you plan to change it soon, i'd like for the name and 
logic to follow each other.  Just the introduction of the internal enum would 
make the intention much more clear to me.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38123
---


On March 20, 2014, 12:20 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 20, 2014, 12:20 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Renaming of UNKNOWN to SANDBOX_DELETED.
> 
> Also, introducing the TaskState internal enum to facilitate task deletion 
> coming next. 
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 4ac218b8f25be5e9e6b6243558af4258efe6e61a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 4a866b2d6041a592692812eb3472db744d21e194 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> a4e9464f7d5d3f5a640b62557c3e29f2f1566985 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> 102fe04f8d3a7142a0cd58251e16d31e8d4a433d 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 24949c043b16a35a7960ed0a40b79f0981179eae 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38123
---


Just to make things clear, this changelist is not addressing the refactoring 
required to actually fix the problem. It's just the first atomic change that 
sets us up for the following:
- Persisting SANDBOX_DELETED when transitioning from terminal states.
- Using DELETED state to drive task deletion through StateManager.
- UI changes to expose SANDBOX_DELETED.

Given the complexity, I am trying to split the entire work into manageable 
chunks to make sure we get it right. 


src/main/java/org/apache/aurora/scheduler/base/Jobs.java


There is no logical change just yet. All I do here is renaming of a state 
to set up for the next step.



src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java


Sure. This will come in the next part.



src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java


Correct. It's still coming but in the next changelist :) 


- Maxim Khutornenko


On March 20, 2014, 12:20 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 20, 2014, 12:20 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Renaming of UNKNOWN to SANDBOX_DELETED.
> 
> Also, introducing the TaskState internal enum to facilitate task deletion 
> coming next. 
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 4ac218b8f25be5e9e6b6243558af4258efe6e61a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 4a866b2d6041a592692812eb3472db744d21e194 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> a4e9464f7d5d3f5a640b62557c3e29f2f1566985 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> 102fe04f8d3a7142a0cd58251e16d31e8d4a433d 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 24949c043b16a35a7960ed0a40b79f0981179eae 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38118
---


Partial review, sorry for the delay — given the sensitive nature of this code, 
i'll need a decided hour or so to think hard about it.  Should get a more 
thorough review by EOD.


src/main/java/org/apache/aurora/scheduler/base/Jobs.java


This is a lie, right?  You need to look at the previous state.



src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java


Can you actually nuke this method, and force the caller to use StateManager 
directly?



src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java


IIRC we decided that a DELETED state was needed as well, to differentiate 
between the two.  Did you find that to be unnecessary?



src/main/thrift/org/apache/aurora/gen/api.thrift


Can you leave a TODO and/or file a ticket to remove INIT?


- Bill Farner


On March 20, 2014, 12:20 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 20, 2014, 12:20 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Renaming of UNKNOWN to SANDBOX_DELETED.
> 
> Also, introducing the TaskState internal enum to facilitate task deletion 
> coming next. 
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 4ac218b8f25be5e9e6b6243558af4258efe6e61a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 4a866b2d6041a592692812eb3472db744d21e194 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> a4e9464f7d5d3f5a640b62557c3e29f2f1566985 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> 102fe04f8d3a7142a0cd58251e16d31e8d4a433d 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 24949c043b16a35a7960ed0a40b79f0981179eae 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review38113
---


Ping, Bill?

- Maxim Khutornenko


On March 20, 2014, 12:20 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 20, 2014, 12:20 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Renaming of UNKNOWN to SANDBOX_DELETED.
> 
> Also, introducing the TaskState internal enum to facilitate task deletion 
> coming next. 
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 4ac218b8f25be5e9e6b6243558af4258efe6e61a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 4a866b2d6041a592692812eb3472db744d21e194 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> a4e9464f7d5d3f5a640b62557c3e29f2f1566985 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> 102fe04f8d3a7142a0cd58251e16d31e8d4a433d 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 24949c043b16a35a7960ed0a40b79f0981179eae 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 19436: Preserving sandbox deleted task history.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19436/#review37832
---

Ship it!


Ship It!

- Kevin Sweeney


On March 19, 2014, 5:20 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19436/
> ---
> 
> (Updated March 19, 2014, 5:20 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-261
> https://issues.apache.org/jira/browse/AURORA-261
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Part 1: Renaming of UNKNOWN to SANDBOX_DELETED.
> 
> Also, introducing the TaskState internal enum to facilitate task deletion 
> coming next. 
> 
> The only functional change in this CR is dropping 
> TaskStateMachine.getState(). Rest is ScheduleStatus to TaskState conversion.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 
> 4ac218b8f25be5e9e6b6243558af4258efe6e61a 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 3ca4ee529aaf3491118da216116b19d7c6a49d09 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 
>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
> 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 
>   src/main/python/apache/aurora/executor/gc_executor.py 
> 4a866b2d6041a592692812eb3472db744d21e194 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e64f844cbd58d92621c6c21b896a9baf0c5a5f07 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> a4e9464f7d5d3f5a640b62557c3e29f2f1566985 
>   src/test/java/org/apache/aurora/scheduler/base/TasksTest.java 
> 102fe04f8d3a7142a0cd58251e16d31e8d4a433d 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> 24949c043b16a35a7960ed0a40b79f0981179eae 
>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
> 77380d9aaab99a9ad739bbc22251232354133c8d 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
> 456634c76b9993119af2d841073c31a4a1c82ab7 
> 
> Diff: https://reviews.apache.org/r/19436/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>