Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22448/#review45419 --- Ship it! Ship It! - Maxim Khutornenko On June 11, 2014, 7:55 p.m

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread David McLaughlin
> On June 11, 2014, 6:40 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 1251 > > > > > > You might want to encapsulate this into a help

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22448/ --- (Updated June 11, 2014, 7:55 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread Maxim Khutornenko
> On June 11, 2014, 6:40 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 1244 > > > > > > How about a test that validates all tasks were

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread David McLaughlin
> On June 11, 2014, 6:40 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 1244 > > > > > > How about a test that validates all tasks were

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22448/#review45410 --- src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22448/ --- (Updated June 11, 2014, 6:32 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 22448: Add pagination to getTasksStatus

2014-06-11 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22448/#review45394 --- Ship it! Just style nits src/main/java/org/apache/aurora/schedule