Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 11:58 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49042 --- Ship it! Ship It! - Maxim Khutornenko On July 29, 2014, 9:44 p.m

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
> On July 29, 2014, 8:58 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 124 > > > > > > I thought you wanted to drop it? Hah whoops, that happened in a diffe

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 9:44 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49022 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java <

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 7:06 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
> On July 29, 2014, 6:18 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java, line 27 > > > > > > Since this isn't in a library anymore you should be fine replacing this > >

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49002 --- Ship it! src/main/java/org/apache/aurora/scheduler/http/AbortCallb