Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread Maxim Khutornenko
> On Aug. 5, 2014, 10:11 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, > > line 61 > > > > > > Bogus return values worry me, since it's conceivable for this to

Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/ --- (Updated Aug. 5, 2014, 10:25 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/#review49651 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DBJo

Re: Review Request 24334: Initial implementation of the UpdateStore (fetch and snapshot).

2014-08-05 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/#review49637 --- Ship it! lgtm. - David McLaughlin On Aug. 5, 2014, 7:41 p.m., Ma