Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Bill Farner
On Aug. 7, 2014, 11:24 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java, lines 17-18 https://reviews.apache.org/r/24465/diff/2/?file=655801#file655801line17 It's unclear to me why T is needed here. Also, this description seems

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/#review50232 --- Ship it!

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Bill Farner
On Aug. 11, 2014, 9:05 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java, lines 135-137 https://reviews.apache.org/r/24465/diff/2-3/?file=655800#file655800line135 There is still job/instance state update mix here. What I was

Re: Review Request 24465: Add a one-way job update controller.

2014-08-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/ --- (Updated Aug. 11, 2014, 9:29 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 24465: Add a one-way job update controller.

2014-08-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/#review50038 ---

Re: Review Request 24465: Add a one-way job update controller.

2014-08-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24465/ --- (Updated Aug. 7, 2014, 11:11 p.m.) Review request for Aurora, Kevin Sweeney