Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55537 --- thanks, build-support/jenkins/build.sh passed, going to merge to

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 5:55 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55371 --- Looks great- thanks!

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55370 --- Ship it! src/main/python/apache/thermos/core/helper.py

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
On Oct. 3, 2014, 6:17 p.m., Joe Smith wrote: src/test/python/apache/thermos/core/test_helper.py, line 33 https://reviews.apache.org/r/25972/diff/2/?file=713532#file713532line33 from psutil._common import puids Looks like I wasn't using this at all, so dropped entirely. - Brian

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
On Oct. 3, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/python/apache/thermos/core/helper.py, line 157 https://reviews.apache.org/r/25972/diff/2/?file=713528#file713528line157 Should we log.debug on the absence of uid from the checkpoint record? Sure, won't hurt. - Brian

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/ --- (Updated Oct. 3, 2014, 10:16 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55410 --- Ship it! Ship It! - Joe Smith On Oct. 3, 2014, 3:16 p.m., Brian

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-09-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review54470 --- src/main/python/apache/thermos/core/helper.py