Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58431
---


+1: Master (669981d) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 24, 2014, 11:08 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 11:08 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---

(Updated Oct. 24, 2014, 4:08 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Bill's feedback.


Bugs: AURORA-878
https://issues.apache.org/jira/browse/AURORA-878


Repository: aurora


Description
---

Cache the host's maintenance status with the offer. By caching the status
alongside the offer the scheduler does not need to access the attribute store
for every offer it considers for a task.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
92c843830df7a779abace38bb0ce84d4cbeb5af4 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/http/Offers.java 
b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
  src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
6534329a92bf005223fa8907cbe4a8a3a511e142 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9970948bace4c0ecbc51d6fc79270d77fb17bf87 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27100/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58426
---

Ship it!


Ship It!

- Maxim Khutornenko


On Oct. 24, 2014, 10:38 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 10:38 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58415
---

Ship it!



src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java


// TODO(wfarner): Replace this with HostAttributes for more use of this 
caching.



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java


maintenanceVeto.isPresent()


- Bill Farner


On Oct. 24, 2014, 10:38 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 10:38 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---

(Updated Oct. 24, 2014, 3:38 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Bill's feedback. The approach is different than suggested after talking with 
Bill offline.


Bugs: AURORA-878
https://issues.apache.org/jira/browse/AURORA-878


Repository: aurora


Description
---

Cache the host's maintenance status with the offer. By caching the status
alongside the offer the scheduler does not need to access the attribute store
for every offer it considers for a task.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
92c843830df7a779abace38bb0ce84d4cbeb5af4 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/http/Offers.java 
b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
  src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
6534329a92bf005223fa8907cbe4a8a3a511e142 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9970948bace4c0ecbc51d6fc79270d77fb17bf87 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27100/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Bill Farner 


> On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, 
> > line 119
> > 
> >
> > I don't understand what you mean by "matches what we do for dedicated 
> > host mismatches as well".

Here's the code snippet:

if (!ConfigurationManager.isDedicated(task) && isDedicated(slaveHost)) {
  return ImmutableSet.of(DEDICATED_HOST_VETO);
}
return ImmutableSet.builder()
.addAll(getConstraintFilter(attributeAggregate, slaveHost).apply(task))
.addAll(getResourceVetoes(offer, task))
.addAll(getMaintenanceVeto(slaveHost).asSet())
.build();

If the host is a known completely bad fit, we don't look at it further.  I 
believe the same flow could be done for maintenance veteos, but at the caller 
rather than in `SchedulingFilterImpl`.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58339
---


On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58400
---


+1: Master (5be667f) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji 


> On Oct. 24, 2014, 2:10 p.m., Maxim Khutornenko wrote:
> > It's not obvious from the diff: where do we gain perf? Can you point to the 
> > place where we don't do store calls anymore?

If you notice in `SchedulingFilterImplTest.java` many of the tests no longer 
make calls to the maintenance controller. This is a performance gain because 
the maintenance controller makes a consistent read from the AttributeStore. 
Since this read is ommitted from every time we call the scheduling filter we 
gain performance.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58374
---


On Oct. 24, 2014, 12:59 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 12:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58374
---


It's not obvious from the diff: where do we gain perf? Can you point to the 
place where we don't do store calls anymore?

- Maxim Khutornenko


On Oct. 24, 2014, 7:59 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58339
---



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java


I don't understand what you mean by "matches what we do for dedicated host 
mismatches as well".


- Zameer Manji


On Oct. 23, 2014, 6:50 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 23, 2014, 6:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---

(Updated Oct. 24, 2014, 12:59 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Bill's feedback.


Bugs: AURORA-878
https://issues.apache.org/jira/browse/AURORA-878


Repository: aurora


Description
---

Cache the host's maintenance status with the offer. By caching the status
alongside the offer the scheduler does not need to access the attribute store
for every offer it considers for a task.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
92c843830df7a779abace38bb0ce84d4cbeb5af4 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/http/Offers.java 
b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
  src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
6534329a92bf005223fa8907cbe4a8a3a511e142 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9970948bace4c0ecbc51d6fc79270d77fb17bf87 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27100/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-24 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58300
---


LGTM! Master (53f4e73) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 24, 2014, 1:50 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 24, 2014, 1:50 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---

(Updated Oct. 23, 2014, 6:50 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Rebase to appease the robot.


Bugs: AURORA-878
https://issues.apache.org/jira/browse/AURORA-878


Repository: aurora


Description
---

Cache the host's maintenance status with the offer. By caching the status
alongside the offer the scheduler does not need to access the attribute store
for every offer it considers for a task.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
92c843830df7a779abace38bb0ce84d4cbeb5af4 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/http/Offers.java 
b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
  src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
6534329a92bf005223fa8907cbe4a8a3a511e142 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9970948bace4c0ecbc51d6fc79270d77fb17bf87 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27100/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58202
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 23, 2014, 6:27 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 23, 2014, 6:27 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58198
---



src/main/java/org/apache/aurora/scheduler/async/Preemptor.java


`getOnlyElement` feels risky here, since you're getting data from two 
sources that might not be synchronized.  i suggest we handle size > 1 and break 
out of the function by not preempting.



src/main/java/org/apache/aurora/scheduler/async/Preemptor.java


s/this.//



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java


I'm tempted to suggest that we inspect the mode before calling `filter`.  I 
can't think of a reason this would be problematic.  All vetoes are collected 
(as opposed to failing on the first one) to supply an accurate pending reason, 
but the maintenance veto uses `MAX_SCORE` meaning it will trump everything else 
anyways.  This matches what we do for dedicated host mismatches as well.


- Bill Farner


On Oct. 23, 2014, 6:27 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 23, 2014, 6:27 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>