Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62408 --- Master (6d06d86) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62407 --- @ReviewBot retry - last attempt - Maxim Khutornenko On Nov. 20, 2

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62405 --- Master (6d06d86) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62402 --- Ship it! Ship It! - Bill Farner On Nov. 20, 2014, 3:01 a.m., Max

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62403 --- @ReviewBot retry - Maxim Khutornenko On Nov. 20, 2014, 3:01 a.m.,

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62323 --- Master (6d06d86) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 20, 2014, 3:01 a.m.) Review request for Aurora, Bill Farner and Z

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 19, 2014, 10:51 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 252 > > > > > > I don't have strong data to back this up, but i'm concerned about the > > performanc

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 19, 2014, 10:51 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 89 > > > > > > This should be the only dynamic one, right? Rack/host limit? Value > > constraints c

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review62256 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61586 --- Ship it! Master (8741cdb) is green with this patch. ./build-suppo

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61582 --- @ReviewBot retry - Maxim Khutornenko On Nov. 15, 2014, 12:15 a.m.

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61578 --- Master (8741cdb) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 15, 2014, 12:15 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 14, 2014, 10:46 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 64 > > > > > > Please define static and dynamic vetos in a comment here. Thanks for reminding. Meant

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61537 --- Ship it! Ship It! - Zameer Manji On Nov. 14, 2014, 2:16 p.m., Ma

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61525 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61529 --- This patch does not apply cleanly on master (8741cdb), do you need t

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 14, 2014, 10:16 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226 > > > > > > To get the data we want, some extra analysis is needed. Specifically - > > if we wan

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226 > > > > > > To get the data we want, some extra analysis is needed. Specifically - > > if we wan

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226 > > > > > > To get the data we want, some extra analysis is needed. Specifically - > > if we wan

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 14, 2014, 2:24 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/TaskVars.java, line 226 > > > > > > To get the data we want, some extra analysis is needed. Specifically - > > if we wan

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61385 --- src/main/java/org/apache/aurora/scheduler/TaskVars.java

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review61351 --- Ship it! Master (254e175) is green with this patch. ./build-suppo

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/ --- (Updated Nov. 14, 2014, 12:30 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 11, 2014, 10:04 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java, line 360 > > > > > > It's nice when boolean-returning methods have names that self-document > > w

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

> On Nov. 11, 2014, 10:04 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java, > > line 283 > > > > > > Can you do this in a SchedulingFilter decorator instead? Tha

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review60861 --- src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27705/#review60263 --- Ship it! Master (5250a94) is green with this patch. ./build-suppo