Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-12-01 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/ --- (Updated Dec. 1, 2014, 7:46 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/#review62620 --- Master (b6217df) is red with this patch.

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/#review62629 --- While you're doing this reshuffle, we really should move

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/#review62636 --- Ship it! lgtm pending green build. - Joshua Cohen On Nov. 21,

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/#review62637 --- Ship it! it also makes thermos_runner.pex 566k instead of 70MB -

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Brian Wickman
On Nov. 21, 2014, 8:30 p.m., Bill Farner wrote: While you're doing this reshuffle, we really should move apache.thermos.* to apache.aurora.thermos.*. Care to elaborate? Why this approach vs the other extreme of just pulling it out entirely. - Brian

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/#review62645 --- @ReviewBot retry - Brian Wickman On Nov. 21, 2014, 7:52 p.m.,

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/ --- (Updated Nov. 21, 2014, 10:10 p.m.) Review request for Aurora, Bhuvan

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28345/#review62664 --- Ship it! Master (91accd6) is green with this patch.

Re: Review Request 28345: Move thermos_runner out of the apache.aurora.executor package.

2014-11-21 Thread Kevin Sweeney
On Nov. 21, 2014, 12:30 p.m., Bill Farner wrote: While you're doing this reshuffle, we really should move apache.thermos.* to apache.aurora.thermos.*. Brian Wickman wrote: Care to elaborate? Why this approach vs the other extreme of just pulling it out entirely. Presumably