Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/
---

(Updated Jan. 6, 2015, 9:23 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-775
https://issues.apache.org/jira/browse/AURORA-775


Repository: aurora


Description
---

I've also done some bulk removal in `docs/client-commands.md`, which was 
essentially a regurgitation of the client's help output.


Diffs (updated)
-

  docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
  docs/client.md PRE-CREATION 
  docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
  docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
  examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
  examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
  src/main/python/apache/aurora/client/BUILD 
3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
  src/main/python/apache/aurora/client/bin/BUILD 
671bd78148788d885e50a93bdc006361297a63a2 
  src/main/python/apache/aurora/client/cli/BUILD 
e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
  src/main/python/apache/aurora/client/cli/__init__.py 
2717210543359d0ecf75244672b8d478cbb5f568 
  src/main/python/apache/aurora/client/cli/client.py 
c8768c772dfbfd642e1a7967670ad799b836a7be 
  src/main/python/apache/aurora/client/cli/config.py 
637e7acd088a33ccc7d9e8302fab5645dfb44378 
  src/test/python/apache/aurora/client/cli/test_help.py 
2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1458e7d134dfe6125c27ef38ce33aee396a33e19 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
d157bb1d3b2ca0aa6fb391336332c71b07946fe0 

Diff: https://reviews.apache.org/r/28971/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./examples/vagrant/test_tutorial.sh


Thanks,

Bill Farner

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review66914
---

Ship it!


Master (1c53b94) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 6, 2015, 9:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Jan. 6, 2015, 9:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2717210543359d0ecf75244672b8d478cbb5f568 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner 


> On Jan. 6, 2015, 9:20 p.m., Kevin Sweeney wrote:
> > docs/clientv2.md, line 180
> > 
> >
> > remove reference to "more consistent". I think this doc was initially 
> > written as a design doc to justify the client rewrite, might not be useful 
> > context for new users.

Good catch - yes, there was a lot carved out here for that reason.  Removed 
this relic.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review66912
---


On Jan. 6, 2015, 9:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Jan. 6, 2015, 9:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2717210543359d0ecf75244672b8d478cbb5f568 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review66912
---

Ship it!



docs/clientv2.md


remove reference to "more consistent". I think this doc was initially 
written as a design doc to justify the client rewrite, might not be useful 
context for new users.


- Kevin Sweeney


On Jan. 6, 2015, 1:15 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Jan. 6, 2015, 1:15 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2717210543359d0ecf75244672b8d478cbb5f568 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner 


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 192
> > 
> >
> > while at it, how about s/shard/instance/g/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 256
> > 
> >
> > missing trailing '>'

Fixed.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 320
> > 
> >
> > drop '-shards' option here

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 370
> > 
> >
> > s/config/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 392
> > 
> >
> > s/pathname/

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > docs/client-commands.md, line 406
> > 
> >
> > same here

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/BUILD, line 102
> > 
> >
> > +1 to renaming the artifact

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/BUILD, line 105
> > 
> >
> > s/aurora2/aurora

Done.


> On Dec. 16, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 38
> > 
> >
> > drop?

Thanks, restored in a way that works.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review65152
---


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/
---

(Updated Jan. 6, 2015, 9:15 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-775
https://issues.apache.org/jira/browse/AURORA-775


Repository: aurora


Description
---

I've also done some bulk removal in `docs/client-commands.md`, which was 
essentially a regurgitation of the client's help output.


Diffs (updated)
-

  docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
  docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
  docs/developing-aurora-client.md bf82d05be5007d17a5738613039eda18a06bce7c 
  examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
  examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
  src/main/python/apache/aurora/client/BUILD 
3ae2a616cb5867fbe6e496269f263b2991c0f3a3 
  src/main/python/apache/aurora/client/bin/BUILD 
671bd78148788d885e50a93bdc006361297a63a2 
  src/main/python/apache/aurora/client/cli/BUILD 
e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
  src/main/python/apache/aurora/client/cli/__init__.py 
2717210543359d0ecf75244672b8d478cbb5f568 
  src/main/python/apache/aurora/client/cli/client.py 
c8768c772dfbfd642e1a7967670ad799b836a7be 
  src/main/python/apache/aurora/client/cli/config.py 
637e7acd088a33ccc7d9e8302fab5645dfb44378 
  src/test/python/apache/aurora/client/cli/test_help.py 
2fef28222cb528d4d7b11fedbcc9ba3a083055d4 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
1458e7d134dfe6125c27ef38ce33aee396a33e19 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
d157bb1d3b2ca0aa6fb391336332c71b07946fe0 

Diff: https://reviews.apache.org/r/28971/diff/


Testing
---

./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./examples/vagrant/test_tutorial.sh


Thanks,

Bill Farner

Re: Review Request 28971: Begin dismantling client v1.

2015-01-06 Thread Bill Farner 


> On Dec. 11, 2014, 10:56 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/BUILD, line 102
> > 
> >
> > Are we going to keep the artifact name like this?

Good catch, i think we should not.  Fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review64805
---


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2014-12-15 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review65152
---



docs/client-commands.md


while at it, how about s/shard/instance/g/



docs/client-commands.md


missing trailing '>'



docs/client-commands.md


drop '-shards' option here



docs/client-commands.md


s/config/



docs/client-commands.md


s/pathname/



docs/client-commands.md


same here



src/main/python/apache/aurora/client/BUILD


+1 to renaming the artifact



src/main/python/apache/aurora/client/BUILD


s/aurora2/aurora



src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


drop?


- Maxim Khutornenko


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2014-12-11 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review64816
---

Ship it!


Master (07bc3ab) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 11, 2014, 10:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 10:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28971: Begin dismantling client v1.

2014-12-11 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28971/#review64805
---



src/main/python/apache/aurora/client/BUILD


Are we going to keep the artifact name like this?


- Zameer Manji


On Dec. 11, 2014, 2:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28971/
> ---
> 
> (Updated Dec. 11, 2014, 2:53 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-775
> https://issues.apache.org/jira/browse/AURORA-775
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some bulk removal in `docs/client-commands.md`, which was 
> essentially a regurgitation of the client's help output.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 6c929c1bae058d8dfcac3bb4220d73d8e389a568 
>   docs/clientv2.md 471d80cae8f05a52f50a1aa4635209354487863d 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 69983d0140b76c6869cd04e55d760f3e3a1e4262 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/BUILD 
> 2a66825426923fd7e5b7c70101747bc292208e19 
>   src/main/python/apache/aurora/client/bin/BUILD 
> 671bd78148788d885e50a93bdc006361297a63a2 
>   src/main/python/apache/aurora/client/cli/BUILD 
> e61cdfb5f3370ac1c5069632d4158f5ee641bc3a 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> c2eb89cae536838ac4dd46b0125a248d84f6e54c 
>   src/main/python/apache/aurora/client/cli/client.py 
> c8768c772dfbfd642e1a7967670ad799b836a7be 
>   src/main/python/apache/aurora/client/cli/config.py 
> 637e7acd088a33ccc7d9e8302fab5645dfb44378 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 1576edcaf0f59911c1c7aec42052d5ebfe41caac 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 1458e7d134dfe6125c27ef38ce33aee396a33e19 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> d157bb1d3b2ca0aa6fb391336332c71b07946fe0 
> 
> Diff: https://reviews.apache.org/r/28971/diff/
> 
> 
> Testing
> ---
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./examples/vagrant/test_tutorial.sh
> 
> 
> Thanks,
> 
> Bill Farner
> 
>