Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/#review66888
---

Ship it!


Master (c1174a7) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 5, 2015, 9:34 p.m., Issam EL ATIF wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29491/
> ---
> 
> (Updated Jan. 5, 2015, 9:34 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> [AURORA-986] RequestLoggerTest failed for Locale.FRANCE
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
> 298a34e1a23716cf63ccc02c0ebc9945490fd7bb 
> 
> Diff: https://reviews.apache.org/r/29491/diff/
> 
> 
> Testing
> ---
> 
> All tests in RequestLoggerTest pass now.
> 
> 
> Thanks,
> 
> Issam EL ATIF
> 
>

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-06 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/#review66887
---

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 5, 2015, 1:34 p.m., Issam EL ATIF wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29491/
> ---
> 
> (Updated Jan. 5, 2015, 1:34 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> [AURORA-986] RequestLoggerTest failed for Locale.FRANCE
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
> 298a34e1a23716cf63ccc02c0ebc9945490fd7bb 
> 
> Diff: https://reviews.apache.org/r/29491/diff/
> 
> 
> Testing
> ---
> 
> All tests in RequestLoggerTest pass now.
> 
> 
> Thanks,
> 
> Issam EL ATIF
> 
>

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-05 Thread Issam EL ATIF 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/
---

(Updated jan. 5, 2015, 9:34 après-midi)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Incorporate review feedback


Repository: aurora


Description
---

[AURORA-986] RequestLoggerTest failed for Locale.FRANCE


Diffs (updated)
-

  src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
298a34e1a23716cf63ccc02c0ebc9945490fd7bb 

Diff: https://reviews.apache.org/r/29491/diff/


Testing
---

All tests in RequestLoggerTest pass now.


Thanks,

Issam EL ATIF

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-05 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/#review66680
---

Ship it!


LGTM with a few nits.


src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java


move declaration to the line before the value is used



src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java


ditto


- Bill Farner


On Jan. 5, 2015, 6:36 p.m., Issam EL ATIF wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29491/
> ---
> 
> (Updated Jan. 5, 2015, 6:36 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> [AURORA-986] RequestLoggerTest failed for Locale.FRANCE
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
> 298a34e1a23716cf63ccc02c0ebc9945490fd7bb 
> 
> Diff: https://reviews.apache.org/r/29491/diff/
> 
> 
> Testing
> ---
> 
> All tests in RequestLoggerTest pass now.
> 
> 
> Thanks,
> 
> Issam EL ATIF
> 
>

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-05 Thread Issam EL ATIF 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/
---

(Updated Jan. 5, 2015, 6:36 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Adding reviewers

-wfarner


Repository: aurora


Description
---

[AURORA-986] RequestLoggerTest failed for Locale.FRANCE


Diffs
-

  src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
298a34e1a23716cf63ccc02c0ebc9945490fd7bb 

Diff: https://reviews.apache.org/r/29491/diff/


Testing
---

All tests in RequestLoggerTest pass now.


Thanks,

Issam EL ATIF

Re: Review Request 29491: [AURORA-986] RequestLoggerTest failed for Locale.FRANCE

2015-01-05 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29491/#review66679
---


Could you add some reviewers to this patch? I think adding maxim and kevints 
should be sufficent.

- Zameer Manji


On Dec. 30, 2014, 1:04 p.m., Issam EL ATIF wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29491/
> ---
> 
> (Updated Dec. 30, 2014, 1:04 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> [AURORA-986] RequestLoggerTest failed for Locale.FRANCE
> 
> 
> Diffs
> -
> 
>   src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java 
> 298a34e1a23716cf63ccc02c0ebc9945490fd7bb 
> 
> Diff: https://reviews.apache.org/r/29491/diff/
> 
> 
> Testing
> ---
> 
> All tests in RequestLoggerTest pass now.
> 
> 
> Thanks,
> 
> Issam EL ATIF
> 
>