Re: Review Request 32276: Fix error listing active updates.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/#review77161
---

Ship it!


Master (0214e70) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 20, 2015, 2:12 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32276/
> ---
> 
> (Updated March 20, 2015, 2:12 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes this error:
> ```
> $ aurora update list devcluster/vagrant/test/http_example --status active
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
> self.execute_entry(entry_point, args)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
> execute_entry
> runner(entry_point)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
> execute_pkg_resources
> runner()
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, 
> in proxy_main
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 329, in execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 306, in _execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 382, in execute
>   File "apache/aurora/client/cli/update.py", line 315, in execute
> TypeError: unhashable type: 'set'
> ```
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> 2168e99a315dd2916086100589c8345cd3a2c4ff 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> df072e9d9685a54c113d444b28d818b72218ffe6 
> 
> Diff: https://reviews.apache.org/r/32276/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 32276: Fix error listing active updates.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/
---

(Updated March 20, 2015, 2:12 a.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

Fixes this error:
```
$ aurora update list devcluster/vagrant/test/http_example --status active
Traceback (most recent call last):
  File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
self.execute_entry(entry_point, args)
  File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
execute_entry
runner(entry_point)
  File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
execute_pkg_resources
runner()
  File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, in 
proxy_main
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 329, 
in execute
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 306, 
in _execute
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 382, 
in execute
  File "apache/aurora/client/cli/update.py", line 315, in execute
TypeError: unhashable type: 'set'
```


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/update.py 
2168e99a315dd2916086100589c8345cd3a2c4ff 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
df072e9d9685a54c113d444b28d818b72218ffe6 

Diff: https://reviews.apache.org/r/32276/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 32276: Fix error listing active updates.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/#review77156
---


Master (0214e70) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 20, 2015, 1:53 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32276/
> ---
> 
> (Updated March 20, 2015, 1:53 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes this error:
> ```
> $ aurora update list devcluster/vagrant/test/http_example --status active
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
> self.execute_entry(entry_point, args)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
> execute_entry
> runner(entry_point)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
> execute_pkg_resources
> runner()
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, 
> in proxy_main
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 329, in execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 306, in _execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 382, in execute
>   File "apache/aurora/client/cli/update.py", line 315, in execute
> TypeError: unhashable type: 'set'
> ```
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> 2168e99a315dd2916086100589c8345cd3a2c4ff 
> 
> Diff: https://reviews.apache.org/r/32276/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 32276: Fix error listing active updates.

[Bill Farner]

> On March 20, 2015, 1:53 a.m., Kevin Sweeney wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 248
> > 
> >
> > You can use frozenset here as well. It's a shame thrift sets are 
> > mutable by default (which causes them to be unhashable).

Good call, done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/#review77153
---


On March 20, 2015, 1:53 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32276/
> ---
> 
> (Updated March 20, 2015, 1:53 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes this error:
> ```
> $ aurora update list devcluster/vagrant/test/http_example --status active
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
> self.execute_entry(entry_point, args)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
> execute_entry
> runner(entry_point)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
> execute_pkg_resources
> runner()
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, 
> in proxy_main
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 329, in execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 306, in _execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 382, in execute
>   File "apache/aurora/client/cli/update.py", line 315, in execute
> TypeError: unhashable type: 'set'
> ```
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> 2168e99a315dd2916086100589c8345cd3a2c4ff 
> 
> Diff: https://reviews.apache.org/r/32276/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 32276: Fix error listing active updates.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/
---

(Updated March 20, 2015, 1:53 a.m.)


Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description (updated)
---

Fixes this error:
```
$ aurora update list devcluster/vagrant/test/http_example --status active
Traceback (most recent call last):
  File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
self.execute_entry(entry_point, args)
  File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
execute_entry
runner(entry_point)
  File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
execute_pkg_resources
runner()
  File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, in 
proxy_main
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 329, 
in execute
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 306, 
in _execute
  File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 382, 
in execute
  File "apache/aurora/client/cli/update.py", line 315, in execute
TypeError: unhashable type: 'set'
```


Diffs
-

  src/main/python/apache/aurora/client/cli/update.py 
2168e99a315dd2916086100589c8345cd3a2c4ff 

Diff: https://reviews.apache.org/r/32276/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 32276: Fix error listing active updates.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/#review77153
---

Ship it!



src/main/python/apache/aurora/client/cli/update.py


You can use frozenset here as well. It's a shame thrift sets are mutable by 
default (which causes them to be unhashable).


- Kevin Sweeney


On March 19, 2015, 6:53 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32276/
> ---
> 
> (Updated March 19, 2015, 6:53 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes this error:
> ```
> $ aurora update list devcluster/vagrant/test/http_example --status active
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
> self.execute_entry(entry_point, args)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
> execute_entry
> runner(entry_point)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
> execute_pkg_resources
> runner()
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, 
> in proxy_main
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 329, in execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 306, in _execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 382, in execute
>   File "apache/aurora/client/cli/update.py", line 315, in execute
> TypeError: unhashable type: 'set'
> ```
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> 2168e99a315dd2916086100589c8345cd3a2c4ff 
> 
> Diff: https://reviews.apache.org/r/32276/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 32276: Fix error listing active updates.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/#review77152
---

Ship it!


Ship It!

- Maxim Khutornenko


On March 20, 2015, 1:46 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32276/
> ---
> 
> (Updated March 20, 2015, 1:46 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fixes this error:
> ```
> $ aurora update list devcluster/vagrant/test/http_example --status active
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 272, in execute
> self.execute_entry(entry_point, args)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 320, in 
> execute_entry
> runner(entry_point)
>   File "/usr/local/bin/aurora/.bootstrap/_pex/pex.py", line 343, in 
> execute_pkg_resources
> runner()
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/client.py", line 95, 
> in proxy_main
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 329, in execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 306, in _execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/__init__.py", line 
> 382, in execute
>   File "/usr/local/bin/aurora/apache/aurora/client/cli/update.py", line 318, 
> in execute
> TypeError: unhashable type: 'set'
> ```
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/update.py 
> 2168e99a315dd2916086100589c8345cd3a2c4ff 
> 
> Diff: https://reviews.apache.org/r/32276/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>