Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32554
---

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 22, 2014, 11:22 a.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17014/
> ---
> 
> (Updated Jan. 22, 2014, 11:22 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-18
> https://issues.apache.org/jira/browse/AURORA-18
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show an error message when a call to the thrift end point returns an invalid 
> response.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> c6706c1d2b395966921c68a83acdef06c1bb8c53 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> f1333f148970b5bc94f3ad77d077e90ebc09cf32 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 16f22a700abb7ba51559e3cfbb04d9218bf4f98a 
> 
> Diff: https://reviews.apache.org/r/17014/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> Tested with local scheduler. Scheduler shows an error message (ex: when 
> storage is not ready)
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://reviews.apache.org/media/uploaded/files/2014/01/22/64224759-0596-4c06-a0c4-feb81ee260f4__Screen_Shot_2014-01-22_at_10.49.57_AM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32520
---

Ship it!


Ship It!

- Bill Farner


On Jan. 22, 2014, 7:22 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17014/
> ---
> 
> (Updated Jan. 22, 2014, 7:22 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-18
> https://issues.apache.org/jira/browse/AURORA-18
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show an error message when a call to the thrift end point returns an invalid 
> response.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> c6706c1d2b395966921c68a83acdef06c1bb8c53 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> f1333f148970b5bc94f3ad77d077e90ebc09cf32 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 16f22a700abb7ba51559e3cfbb04d9218bf4f98a 
> 
> Diff: https://reviews.apache.org/r/17014/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> Tested with local scheduler. Scheduler shows an error message (ex: when 
> storage is not ready)
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://reviews.apache.org/media/uploaded/files/2014/01/22/64224759-0596-4c06-a0c4-feb81ee260f4__Screen_Shot_2014-01-22_at_10.49.57_AM.png
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/
---

(Updated Jan. 22, 2014, 7:22 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-18
https://issues.apache.org/jira/browse/AURORA-18


Repository: aurora


Description
---

Show an error message when a call to the thrift end point returns an invalid 
response.


Diffs
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
c6706c1d2b395966921c68a83acdef06c1bb8c53 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
f1333f148970b5bc94f3ad77d077e90ebc09cf32 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
16f22a700abb7ba51559e3cfbb04d9218bf4f98a 

Diff: https://reviews.apache.org/r/17014/diff/


Testing
---

gradle clean build.

Tested with local scheduler. Scheduler shows an error message (ex: when storage 
is not ready)


File Attachments (updated)


error message
  
https://reviews.apache.org/media/uploaded/files/2014/01/22/64224759-0596-4c06-a0c4-feb81ee260f4__Screen_Shot_2014-01-22_at_10.49.57_AM.png


Thanks,

Suman Karumuri

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Suman Karumuri]

> On Jan. 21, 2014, 11:40 p.m., Kevin Sweeney wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 11
> > 
> >
> > Could this be set to the actual error message? This implementation 
> > seems to swallow it.

I am still thinking that the error message was a stack trace based on the old 
UI and was planning to log it(future diff) instead of showing it to the user. 
This comment made me realize that we actually get a nice error message from the 
thrift end point. Showing the message now. 


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32444
---


On Jan. 22, 2014, 7:16 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17014/
> ---
> 
> (Updated Jan. 22, 2014, 7:16 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-18
> https://issues.apache.org/jira/browse/AURORA-18
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show an error message when a call to the thrift end point returns an invalid 
> response.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> c6706c1d2b395966921c68a83acdef06c1bb8c53 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> f1333f148970b5bc94f3ad77d077e90ebc09cf32 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 16f22a700abb7ba51559e3cfbb04d9218bf4f98a 
> 
> Diff: https://reviews.apache.org/r/17014/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> Tested with local scheduler. Scheduler shows an error message (ex: when 
> storage is not ready)
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/
---

(Updated Jan. 22, 2014, 7:16 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Displaying the error message now.


Bugs: AURORA-18
https://issues.apache.org/jira/browse/AURORA-18


Repository: aurora


Description
---

Show an error message when a call to the thrift end point returns an invalid 
response.


Diffs (updated)
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
c6706c1d2b395966921c68a83acdef06c1bb8c53 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
f1333f148970b5bc94f3ad77d077e90ebc09cf32 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
16f22a700abb7ba51559e3cfbb04d9218bf4f98a 

Diff: https://reviews.apache.org/r/17014/diff/


Testing
---

gradle clean build.

Tested with local scheduler. Scheduler shows an error message (ex: when storage 
is not ready)


Thanks,

Suman Karumuri

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32444
---



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js


Could this be set to the actual error message? This implementation seems to 
swallow it.


- Kevin Sweeney


On Jan. 21, 2014, 1:28 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17014/
> ---
> 
> (Updated Jan. 21, 2014, 1:28 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-18
> https://issues.apache.org/jira/browse/AURORA-18
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show an error message when a call to the thrift end point returns an invalid 
> response.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> c6706c1d2b395966921c68a83acdef06c1bb8c53 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> f1333f148970b5bc94f3ad77d077e90ebc09cf32 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 16f22a700abb7ba51559e3cfbb04d9218bf4f98a 
> 
> Diff: https://reviews.apache.org/r/17014/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> Tested with local scheduler. Scheduler shows an error message (ex: when 
> storage is not ready)
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/#review32442
---


ping.

- Suman Karumuri


On Jan. 21, 2014, 9:28 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17014/
> ---
> 
> (Updated Jan. 21, 2014, 9:28 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-18
> https://issues.apache.org/jira/browse/AURORA-18
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Show an error message when a call to the thrift end point returns an invalid 
> response.
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
> c6706c1d2b395966921c68a83acdef06c1bb8c53 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> f1333f148970b5bc94f3ad77d077e90ebc09cf32 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 16f22a700abb7ba51559e3cfbb04d9218bf4f98a 
> 
> Diff: https://reviews.apache.org/r/17014/diff/
> 
> 
> Testing
> ---
> 
> gradle clean build.
> 
> Tested with local scheduler. Scheduler shows an error message (ex: when 
> storage is not ready)
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/
---

(Updated Jan. 21, 2014, 1:28 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Fix bug link.


Bugs: AURORA-18
https://issues.apache.org/jira/browse/AURORA-18


Repository: aurora


Description
---

Show an error message when a call to the thrift end point returns an invalid 
response.


Diffs
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
c6706c1d2b395966921c68a83acdef06c1bb8c53 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
f1333f148970b5bc94f3ad77d077e90ebc09cf32 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
16f22a700abb7ba51559e3cfbb04d9218bf4f98a 

Diff: https://reviews.apache.org/r/17014/diff/


Testing
---

gradle clean build.

Tested with local scheduler. Scheduler shows an error message (ex: when storage 
is not ready)


Thanks,

Suman Karumuri

Review Request 17014: Show an error message in the UI when scheduler returns an invalid response.

[Suman Karumuri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17014/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: https://issues.apache.org/jira/browse/AURORA-18

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-18


Repository: aurora


Description
---

Show an error message when a call to the thrift end point returns an invalid 
response.


Diffs
-

  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
c6706c1d2b395966921c68a83acdef06c1bb8c53 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
f1333f148970b5bc94f3ad77d077e90ebc09cf32 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
16f22a700abb7ba51559e3cfbb04d9218bf4f98a 

Diff: https://reviews.apache.org/r/17014/diff/


Testing
---

gradle clean build.

Tested with local scheduler. Scheduler shows an error message (ex: when storage 
is not ready)


Thanks,

Suman Karumuri