Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Bill Farner]

> On Feb. 25, 2014, 2:07 p.m., Mark Chu-Carroll wrote:
> > Ship It!

Mark, as the last shipper with commit access — can you commit this?


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review35400
---


On Feb. 25, 2014, 2:53 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17877/
> ---
> 
> (Updated Feb. 25, 2014, 2:53 a.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-200
> https://issues.apache.org/jira/browse/AURORA-200
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-200: set_quota should die if given invalid arguments
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
> 
> Diff: https://reviews.apache.org/r/17877/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
> testing w/ bad arguments.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review35400
---

Ship it!


Ship It!

- Mark Chu-Carroll


On Feb. 24, 2014, 9:53 p.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17877/
> ---
> 
> (Updated Feb. 24, 2014, 9:53 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-200
> https://issues.apache.org/jira/browse/AURORA-200
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-200: set_quota should die if given invalid arguments
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
> 
> Diff: https://reviews.apache.org/r/17877/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
> testing w/ bad arguments.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Dan Norris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/
---

(Updated Feb. 25, 2014, 2:53 a.m.)


Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.


Changes
---

Converts the exception passed to die() to be a string. Results in the following:

./pants py src/main/python/apache/aurora/client/bin:aurora_admin set_quota 
example fakerole 1 10a 3gb
FATAL] Invalid size: Amount did not have a valid base: 10a.  Valid bases: kb gb 
g mb tb k m t


Bugs: AURORA-200
https://issues.apache.org/jira/browse/AURORA-200


Repository: aurora


Description
---

AURORA-200: set_quota should die if given invalid arguments


Diffs (updated)
-

  src/main/python/apache/aurora/client/commands/admin.py 
45686aec8d69f0dfa1d649a92a19ca87bd315823 

Diff: https://reviews.apache.org/r/17877/diff/


Testing
---

./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
testing w/ bad arguments.


Thanks,

Dan Norris

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Dan Norris]

> On Feb. 11, 2014, 4:33 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/commands/admin.py, line 174
> > 
> >
> > Die expects a message string, not an exception object. die('Invalid 
> > unit specification') would end up with a better error message.
> >

Oh yeah, I can see the the problem with not passing a string. I feel like the 
default exception message provides a better explanation of what was wrong with 
the argument though:

./pants py src/main/python/apache/aurora/client/bin:aurora_admin set_quota 
example role 10 a b
FATAL] Invalid size: Amount did not have a valid base: a.  Valid bases: kb gb g 
mb tb k m t


- Dan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34193
---


On Feb. 10, 2014, 7:17 p.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17877/
> ---
> 
> (Updated Feb. 10, 2014, 7:17 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-200
> https://issues.apache.org/jira/browse/AURORA-200
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-200: set_quota should die if given invalid arguments
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
> 
> Diff: https://reviews.apache.org/r/17877/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
> testing w/ bad arguments.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Mark Chu-Carroll]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34193
---



src/main/python/apache/aurora/client/commands/admin.py


Die expects a message string, not an exception object. die('Invalid unit 
specification') would end up with a better error message.



- Mark Chu-Carroll


On Feb. 10, 2014, 2:17 p.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17877/
> ---
> 
> (Updated Feb. 10, 2014, 2:17 p.m.)
> 
> 
> Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-200
> https://issues.apache.org/jira/browse/AURORA-200
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-200: set_quota should die if given invalid arguments
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
> 
> Diff: https://reviews.apache.org/r/17877/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
> testing w/ bad arguments.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Dan Norris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/
---

(Updated Feb. 10, 2014, 7:17 p.m.)


Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.


Bugs: AURORA-200
https://issues.apache.org/jira/browse/AURORA-200


Repository: aurora


Description
---

AURORA-200: set_quota should die if given invalid arguments


Diffs
-

  src/main/python/apache/aurora/client/commands/admin.py 
45686aec8d69f0dfa1d649a92a19ca87bd315823 

Diff: https://reviews.apache.org/r/17877/diff/


Testing
---

./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
testing w/ bad arguments.


Thanks,

Dan Norris

Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Jonathan Boulle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34042
---

Ship it!


Ship It!

- Jonathan Boulle


On Feb. 9, 2014, 4:34 a.m., Dan Norris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17877/
> ---
> 
> (Updated Feb. 9, 2014, 4:34 a.m.)
> 
> 
> Review request for Aurora and Jonathan Boulle.
> 
> 
> Bugs: AURORA-200
> https://issues.apache.org/jira/browse/AURORA-200
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-200: set_quota should die if given invalid arguments
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 45686aec8d69f0dfa1d649a92a19ca87bd315823 
> 
> Diff: https://reviews.apache.org/r/17877/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
> testing w/ bad arguments.
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Review Request 17877: AURORA-200: set_quota should die if given invalid arguments

[Dan Norris]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/
---

Review request for Aurora and Jonathan Boulle.


Bugs: AURORA-200
https://issues.apache.org/jira/browse/AURORA-200


Repository: aurora


Description
---

AURORA-200: set_quota should die if given invalid arguments


Diffs
-

  src/main/python/apache/aurora/client/commands/admin.py 
45686aec8d69f0dfa1d649a92a19ca87bd315823 

Diff: https://reviews.apache.org/r/17877/diff/


Testing
---

./gradlew clean build && ./pants src/test/python:all -vxs along with manual 
testing w/ bad arguments.


Thanks,

Dan Norris