Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 7, 2014, 6:21 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36547 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 5:03 p.m., M

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36427 --- Waiting for Kevin. - Maxim Khutornenko On March 4, 2014, 1:03 a.m

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36187 --- Ping, Kevin? - Maxim Khutornenko On March 4, 2014, 1:03 a.m., Max

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36073 --- Ship it! Ship It! - Bill Farner On March 4, 2014, 1:03 a.m., Max

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 4, 2014, 1:03 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36072 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 4, 2014, 12:02 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 > > > > > > Iterables.getOnlyELement is a bit of a land mine. An unsuspecting > > caller can hi

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 4, 2014, 12:02 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 > > > > > > Iterables.getOnlyELement is a bit of a land mine. An unsuspecting > > caller can hi

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
> On March 4, 2014, 12:02 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 > > > > > > Iterables.getOnlyELement is a bit of a land mine. An unsuspecting > > caller can hi

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36054 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 3, 2014, 11:26 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
> On March 1, 2014, 1:32 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 178 > > > > > > "from" is currently intended to unambiguously give a single IJobKey > > ins

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 1, 2014, 1:32 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 178 > > > > > > "from" is currently intended to unambiguously give a single IJobKey > > ins

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Bill Farner
> On March 3, 2014, 6:06 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/base/Query.java, line 387 > > > > > > To continue this conversation, I don't quite feel merging job > > (role/env/n

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35988 --- src/main/java/org/apache/aurora/scheduler/base/Query.java

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35889 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35887 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-02-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35885 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java

Review Request 18655: Added JobKey set into TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235