Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-24 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41304 --- This is on master now. - Maxim Khutornenko On April 24, 2014, 2:5

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 24, 2014, 2:55 a.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
> On April 23, 2014, 3:14 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line > > 22 > > > > > > Missing "," for the new records. That's what I get for multita

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41146 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 3:02 p.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 3:02 p.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41145 --- src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.j

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41118 --- Ship it! Ship It! - Suman Karumuri On April 23, 2014, 1:39 a.m.,

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 1:39 a.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41107 --- dist/resources/main/org/apache/aurora/scheduler/http/assets/diction

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:11 p.m.) Review request for Aurora, Suman Karumuri a

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:11 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-22 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 22, 2014, 9:10 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-21 Thread Maxim Khutornenko
> On April 9, 2014, 5:35 p.m., Suman Karumuri wrote: > > Thanks for the diff Dan. As part of the new UI roll out > > https://reviews.apache.org/r/19833/, I have removed this file from the > > server and moved this logic into the client side. I can add these changes > > as part of that diff or

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-09 Thread Suman Karumuri
> On April 9, 2014, 5:35 p.m., Suman Karumuri wrote: > > Thanks for the diff Dan. As part of the new UI roll out > > https://reviews.apache.org/r/19833/, I have removed this file from the > > server and moved this logic into the client side. I can add these changes > > as part of that diff or

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-09 Thread Dan Norris
> On April 9, 2014, 5:35 p.m., Suman Karumuri wrote: > > Thanks for the diff Dan. As part of the new UI roll out > > https://reviews.apache.org/r/19833/, I have removed this file from the > > server and moved this logic into the client side. I can add these changes > > as part of that diff or

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-09 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review39907 --- Thanks for the diff Dan. As part of the new UI roll out https://rev

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-09 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 9, 2014, 5:34 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review39901 --- src/main/resources/org/apache/aurora/scheduler/http/assets/dictiona

Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-08 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-265 https://i