Re: Review Request 20490: Add a "get version" API method.

2014-04-24 Thread Brian Wickman 
Make sure to close the reviewboard, otherwise it will continue to show up
in review dashboards.


On Thu, Apr 24, 2014 at 10:20 AM, Mark Chu-Carroll
wrote:

> It's already pushed.
>
>
> On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman  wrote:
>
>>This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/20490/
>>
>> if this merges to master after r/20583, you will need to kill the directory 
>> wrapper stuff.  if it merges before r/20583, i will have to kill the 
>> directory wrapper stuff :-)  since this goes away in twitter.common.python 
>> >=0.4.0.
>>
>>
>> - Brian Wickman
>>
>> On April 22nd, 2014, 7:59 p.m. UTC, Mark Chu-Carroll wrote:
>>   Review request for Aurora, Maxim Khutornenko and Brian Wickman.
>> By Mark Chu-Carroll.
>>
>> *Updated April 22, 2014, 7:59 p.m.*
>>  *Repository: * aurora
>> Description
>>
>> Add a "get version" API method. (This is needed for a logging-related change 
>> for twitter.)
>>
>> While I'm in there, fix a bug in "job list".
>>
>>   Testing
>>
>> ./pants src/test/python/apache/aurora/client:all
>> Build operating on targets: 
>> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 2 items
>>
>> src/test/python/apache/aurora/client/test_binding_helper.py ..
>>
>> == 2 passed in 0.39 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/test_config.py ..
>>
>> == 6 passed in 0.47 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
>>
>> == 6 passed in 0.46 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 1 items
>>
>> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>>
>> == 1 passed in 0.41 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/api/test_restarter.py ..
>>
>> == 6 passed in 0.36 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 47 items / 1 skipped
>>
>> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
>> ...
>>
>>  47 passed, 1 skipped in 3.83 seconds 
>> 
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 20 items
>>
>> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
>> src/test/python/apache/aurora/client/api/test_health_check.py 
>>
>> = 20 passed in 0.24 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 27 items
>>
>> src/test/python/apache/aurora/client/api/test_updater.py 
>> ...
>>
>> = 27 passed in 0.64 seconds 
>> ==
>>  test session starts 
>> =
>> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
>> collected 6 items
>>
>> src/test/python/apache/aurora/client/api/test_quota_check.py ..
>>
>> == 6 passed in 0.15 seconds 
>> ==
>>  test session starts

Re: Review Request 20490: Add a "get version" API method.

2014-04-24 Thread Mark Chu-Carroll 
It's already pushed.


On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman  wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
>
> if this merges to master after r/20583, you will need to kill the directory 
> wrapper stuff.  if it merges before r/20583, i will have to kill the 
> directory wrapper stuff :-)  since this goes away in twitter.common.python 
> >=0.4.0.
>
>
> - Brian Wickman
>
> On April 22nd, 2014, 7:59 p.m. UTC, Mark Chu-Carroll wrote:
>   Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated April 22, 2014, 7:59 p.m.*
>  *Repository: * aurora
> Description
>
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
>
> While I'm in there, fix a bug in "job list".
>
>   Testing
>
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
>
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/test_config.py ..
>
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
>
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
>
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
>
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_restarter.py ..
>
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
>
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
>
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
>
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
>
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
>
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
>
> = 27 passed in 0.64 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
>
> src/test/python/apache/aurora/client/api/test_quota_check.py ..
>
> == 6 passed in 0.15 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 31 items
>
> src/test/python/apache/aurora/client/api/test_sla.py 
> ...
>
> = 31 pas

Re: Review Request 20490: Add a "get version" API method.

2014-04-24 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review41335
---


if this merges to master after r/20583, you will need to kill the directory 
wrapper stuff.  if it merges before r/20583, i will have to kill the directory 
wrapper stuff :-)  since this goes away in twitter.common.python >=0.4.0.

- Brian Wickman


On April 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
> ---
> 
> (Updated April 22, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
> 
> While I'm in there, fix a bug in "job list".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0793a1ae4bd5d641ea57473705076290d77ac2b6 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 
> 
> Diff: https://reviews.apache.org/r/20490/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> = 27 passed in 0.64 seconds 
> =

Re: Review Request 20490: Add a "get version" API method.

2014-04-23 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review41149
---

Ship it!


Ship It!

- Brian Wickman


On April 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
> ---
> 
> (Updated April 22, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
> 
> While I'm in there, fix a bug in "job list".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0793a1ae4bd5d641ea57473705076290d77ac2b6 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 
> 
> Diff: https://reviews.apache.org/r/20490/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> = 27 passed in 0.64 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> colle

Re: Review Request 20490: Add a "get version" API method.

2014-04-22 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/
---

(Updated April 22, 2014, 3:59 p.m.)


Review request for Aurora, Maxim Khutornenko and Brian Wickman.


Changes
---

Fix an indent glitch. (That's what I get for trying to go back to emacs!)


Repository: aurora


Description
---

Add a "get version" API method. (This is needed for a logging-related change 
for twitter.)

While I'm in there, fix a bug in "job list".


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/main/python/apache/aurora/client/cli/__init__.py 
f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
  src/main/python/apache/aurora/client/cli/jobs.py 
0793a1ae4bd5d641ea57473705076290d77ac2b6 
  src/test/python/apache/aurora/client/cli/test_help.py 
6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 

Diff: https://reviews.apache.org/r/20490/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

== 2 passed in 0.39 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

== 6 passed in 0.47 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

== 6 passed in 0.46 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

== 1 passed in 0.41 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

== 6 passed in 0.36 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

 47 passed, 1 skipped in 3.83 seconds 

 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

= 20 passed in 0.24 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

= 27 passed in 0.64 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

== 6 passed in 0.15 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
..

Re: Review Request 20490: Add a "get version" API method.

2014-04-18 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/#review40818
---

Ship it!



src/main/python/apache/aurora/client/cli/__init__.py


Mind using 4 tabs here or aligning with previous?


- Maxim Khutornenko


On April 18, 2014, 5:30 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20490/
> ---
> 
> (Updated April 18, 2014, 5:30 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a "get version" API method. (This is needed for a logging-related change 
> for twitter.)
> 
> While I'm in there, fix a bug in "job list".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 02e061c7d485cc7f24c48c0db1b5778819961f47 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 0793a1ae4bd5d641ea57473705076290d77ac2b6 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 
> 
> Diff: https://reviews.apache.org/r/20490/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 2 items
> 
> src/test/python/apache/aurora/client/test_binding_helper.py ..
> 
> == 2 passed in 0.39 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/test_config.py ..
> 
> == 6 passed in 0.47 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_disambiguator.py ..
> 
> == 6 passed in 0.46 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 1 items
> 
> src/test/python/apache/aurora/client/api/test_job_monitor.py .
> 
> == 1 passed in 0.41 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 6 items
> 
> src/test/python/apache/aurora/client/api/test_restarter.py ..
> 
> == 6 passed in 0.36 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 47 items / 1 skipped
> 
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> ...
> 
>  47 passed, 1 skipped in 3.83 seconds 
> 
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 20 items
> 
> src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> src/test/python/apache/aurora/client/api/test_health_check.py 
> 
> = 20 passed in 0.24 seconds 
> ==
>  test session starts 
> =
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 27 items
> 
> src/test/python/apache/aurora/client/api/test_updater.py 
> ...
> 
> = 27 passed in 0.64 seconds 
> ==
>

Re: Review Request 20490: Add a "get version" API method.

2014-04-18 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/
---

(Updated April 18, 2014, 1:30 p.m.)


Review request for Aurora, Maxim Khutornenko and Brian Wickman.


Changes
---

Remove some accidental branch contamination.


Repository: aurora


Description
---

Add a "get version" API method. (This is needed for a logging-related change 
for twitter.)

While I'm in there, fix a bug in "job list".


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/main/python/apache/aurora/client/cli/__init__.py 
f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
  src/main/python/apache/aurora/client/cli/jobs.py 
0793a1ae4bd5d641ea57473705076290d77ac2b6 
  src/test/python/apache/aurora/client/cli/test_help.py 
6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 

Diff: https://reviews.apache.org/r/20490/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

== 2 passed in 0.39 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

== 6 passed in 0.47 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

== 6 passed in 0.46 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

== 1 passed in 0.41 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

== 6 passed in 0.36 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

 47 passed, 1 skipped in 3.83 seconds 

 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

= 20 passed in 0.24 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

= 27 passed in 0.64 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

== 6 passed in 0.15 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

==

Re: Review Request 20490: Add a "get version" API method.

2014-04-18 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/
---

(Updated April 18, 2014, 12:29 p.m.)


Review request for Aurora, Maxim Khutornenko and Brian Wickman.


Repository: aurora


Description
---

Add a "get version" API method. (This is needed for a logging-related change 
for twitter.)

While I'm in there, fix a bug in "job list".


Diffs
-

  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/main/python/apache/aurora/client/cli/__init__.py 
f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
  src/main/python/apache/aurora/client/cli/jobs.py 
0793a1ae4bd5d641ea57473705076290d77ac2b6 
  src/test/python/apache/aurora/client/cli/test_help.py 
6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 

Diff: https://reviews.apache.org/r/20490/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

== 2 passed in 0.39 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

== 6 passed in 0.47 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

== 6 passed in 0.46 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

== 1 passed in 0.41 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

== 6 passed in 0.36 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

 47 passed, 1 skipped in 3.83 seconds 

 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

= 20 passed in 0.24 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

= 27 passed in 0.64 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

== 6 passed in 0.15 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

= 31 passed in 0.26 seconds 
==

Re: Review Request 20490: Add a "get version" API method.

2014-04-18 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/
---

(Updated April 18, 2014, 12:29 p.m.)


Review request for Aurora.


Repository: aurora


Description
---

Add a "get version" API method. (This is needed for a logging-related change 
for twitter.)

While I'm in there, fix a bug in "job list".


Diffs
-

  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/main/python/apache/aurora/client/cli/__init__.py 
f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
  src/main/python/apache/aurora/client/cli/jobs.py 
0793a1ae4bd5d641ea57473705076290d77ac2b6 
  src/test/python/apache/aurora/client/cli/test_help.py 
6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 

Diff: https://reviews.apache.org/r/20490/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

== 2 passed in 0.39 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

== 6 passed in 0.47 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

== 6 passed in 0.46 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

== 1 passed in 0.41 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

== 6 passed in 0.36 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

 47 passed, 1 skipped in 3.83 seconds 

 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

= 20 passed in 0.24 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

= 27 passed in 0.64 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

== 6 passed in 0.15 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

= 31 passed in 0.26 seconds 
==

Review Request 20490: Add a "get version" API method.

2014-04-18 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20490/
---

Review request for Aurora.


Repository: aurora


Description
---

Add a "get version" API method. (This is needed for a logging-related change 
for twitter.)

While I'm in there, fix a bug in "job list".


Diffs
-

  src/main/python/apache/aurora/client/cli/BUILD 
02e061c7d485cc7f24c48c0db1b5778819961f47 
  src/main/python/apache/aurora/client/cli/__init__.py 
f1165a05c7c66d7a06f4733eb65ae4a7de6fad76 
  src/main/python/apache/aurora/client/cli/jobs.py 
0793a1ae4bd5d641ea57473705076290d77ac2b6 
  src/test/python/apache/aurora/client/cli/test_help.py 
6876bb78b15a676fb2eb8964a55c60d9bbdb4be7 

Diff: https://reviews.apache.org/r/20490/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Build operating on targets: 
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 2 items

src/test/python/apache/aurora/client/test_binding_helper.py ..

== 2 passed in 0.39 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/test_config.py ..

== 6 passed in 0.47 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_disambiguator.py ..

== 6 passed in 0.46 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 1 items

src/test/python/apache/aurora/client/api/test_job_monitor.py .

== 1 passed in 0.41 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_restarter.py ..

== 6 passed in 0.36 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 47 items / 1 skipped

src/test/python/apache/aurora/client/api/test_scheduler_client.py 
...

 47 passed, 1 skipped in 3.83 seconds 

 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 20 items

src/test/python/apache/aurora/client/api/test_instance_watcher.py 
src/test/python/apache/aurora/client/api/test_health_check.py 

= 20 passed in 0.24 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 27 items

src/test/python/apache/aurora/client/api/test_updater.py 
...

= 27 passed in 0.64 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 6 items

src/test/python/apache/aurora/client/api/test_quota_check.py ..

== 6 passed in 0.15 seconds 
==
 test session starts 
=
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
collected 31 items

src/test/python/apache/aurora/client/api/test_sla.py 
...

= 31 passed in 0.26 seconds 
==
 test session s