Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-30 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/
---

(Updated April 30, 2014, 7:14 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebased.


Bugs: AURORA-345
https://issues.apache.org/jira/browse/AURORA-345


Repository: aurora


Description
---

Converted INVALID_REQUEST to OK and modified returned message.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
e62f6c62452a1e1ac93baec7419580de2f40f0de 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
536927949c915363cccf074449d089314ecf6996 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
e69daa62347e0863ec6b6ee768a10707d5c7e822 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
d7dbfaa76b277b028e56ed633ea2a032935e26db 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 72171a80075d1b9739ad2578b900ab633f22 

Diff: https://reviews.apache.org/r/20732/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-30 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41861
---

Ship it!


Ship It!

- Kevin Sweeney


On April 28, 2014, 9:22 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 28, 2014, 9:22 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-30 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41860
---


Ping, Kevin.

- Maxim Khutornenko


On April 28, 2014, 4:22 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 28, 2014, 4:22 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-28 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/
---

(Updated April 28, 2014, 4:22 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-345
https://issues.apache.org/jira/browse/AURORA-345


Repository: aurora


Description
---

Converted INVALID_REQUEST to OK and modified returned message.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
e62f6c62452a1e1ac93baec7419580de2f40f0de 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
536927949c915363cccf074449d089314ecf6996 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7c557931b2ce05c7d14499954fe3b89bb5853faa 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
d7dbfaa76b277b028e56ed633ea2a032935e26db 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 c23c94807b97bcf77c2c155ee2039deebfaa090c 

Diff: https://reviews.apache.org/r/20732/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-28 Thread Maxim Khutornenko 


> On April 25, 2014, 11:34 p.m., Bill Farner wrote:
> > Overall LGTM, but i suggest we think hard before introducing the count.
> 
> Maxim Khutornenko wrote:
> Not sure I understand. What's your concern about returning the count here?
> 
> Bill Farner wrote:
> It's really only usable for display (not programmatic use), and it isn't 
> always accurate.

I am fine dropping both the count and the message for now in favor of a generic 
"Tasks killed."


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Bill Farner 


> On April 25, 2014, 11:34 p.m., Bill Farner wrote:
> > Overall LGTM, but i suggest we think hard before introducing the count.
> 
> Maxim Khutornenko wrote:
> Not sure I understand. What's your concern about returning the count here?

It's really only usable for display (not programmatic use), and it isn't always 
accurate.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Maxim Khutornenko 


> On April 25, 2014, 11:34 p.m., Bill Farner wrote:
> > Overall LGTM, but i suggest we think hard before introducing the count.

Not sure I understand. What's your concern about returning the count here? 


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41542
---

Ship it!


Overall LGTM, but i suggest we think hard before introducing the count.


src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java


The synthetic '1' is pretty ugly, perhaps enough to warrant punting on 
returning a count until we separate cron descheduling?


- Bill Farner


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Maxim Khutornenko 


> On April 25, 2014, 8:54 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java, line 81
> > 
> >
> > How would you feel about nuking this method and moving the 
> > implementation to SchedulerThriftInterface?  It's the only consumer, making 
> > this a proxy method to StateManager.

Well, this is true about all methods in SchedulerCore. I'd rather minimize the 
diff here and address the refactoring in AURORA-94.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41522
---


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/#review41522
---



src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java


How would you feel about nuking this method and moving the implementation 
to SchedulerThriftInterface?  It's the only consumer, making this a proxy 
method to StateManager.


- Bill Farner


On April 25, 2014, 8:41 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20732/
> ---
> 
> (Updated April 25, 2014, 8:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-345
> https://issues.apache.org/jira/browse/AURORA-345
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Converted INVALID_REQUEST to OK and modified returned message.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
> e62f6c62452a1e1ac93baec7419580de2f40f0de 
>   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
> 536927949c915363cccf074449d089314ecf6996 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7c557931b2ce05c7d14499954fe3b89bb5853faa 
>   
> src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
>  d7dbfaa76b277b028e56ed633ea2a032935e26db 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  c23c94807b97bcf77c2c155ee2039deebfaa090c 
> 
> Diff: https://reviews.apache.org/r/20732/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 20732: Dropping "No jobs to kill" error from killTasks.

2014-04-25 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20732/
---

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-345
https://issues.apache.org/jira/browse/AURORA-345


Repository: aurora


Description
---

Converted INVALID_REQUEST to OK and modified returned message.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
e62f6c62452a1e1ac93baec7419580de2f40f0de 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
536927949c915363cccf074449d089314ecf6996 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
7c557931b2ce05c7d14499954fe3b89bb5853faa 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
d7dbfaa76b277b028e56ed633ea2a032935e26db 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 c23c94807b97bcf77c2c155ee2039deebfaa090c 

Diff: https://reviews.apache.org/r/20732/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko