Re: Review Request 21597: Return empty list instead of failing.

2014-05-22 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/#review43799 --- Ship it! Ship It! - Brian Wickman On May 21, 2014, 4:05 p.m., Ma

Re: Review Request 21597: Return empty list instead of failing.

2014-05-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/#review43634 --- Ship it! Ship It! - Mark Chu-Carroll On May 21, 2014, 12:05 p.m.

Re: Review Request 21597: Return empty list instead of failing.

2014-05-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/ --- (Updated May 21, 2014, 4:05 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21597: Return empty list instead of failing.

2014-05-21 Thread Maxim Khutornenko
> On May 21, 2014, 1:38 a.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/base.py, line 47 > > > > > > Why are these split into multiple methods? The only place where > > "check_and_log_locked" is

Re: Review Request 21597: Return empty list instead of failing.

2014-05-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/#review43569 --- src/main/python/apache/aurora/client/base.py

Re: Review Request 21597: Return empty list instead of failing.

2014-05-19 Thread Maxim Khutornenko
> On May 18, 2014, 7:08 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/sla.py, lines 292-293 > > > > > > seems like we should have a log_response method instead of > > reimplementing here? Su

Re: Review Request 21597: Return empty list instead of failing.

2014-05-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/ --- (Updated May 19, 2014, 5:58 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21597: Return empty list instead of failing.

2014-05-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/#review43327 --- src/main/python/apache/aurora/client/api/sla.py

Review Request 21597: Return empty list instead of failing.

2014-05-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-442