Re: Review Request 21597: Return empty list instead of failing.

2014-05-22 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43799
---

Ship it!


Ship It!

- Brian Wickman


On May 21, 2014, 4:05 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> ---
> 
> (Updated May 21, 2014, 4:05 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
> https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA 
> command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> a20b5d46221981740e0b7d5f0958516560928b54 
>   src/main/python/apache/aurora/client/base.py 
> 13730fd98e36377376e498f414dfb317d5b3b114 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 86b6775e51cab1214a6cae01145f19f08cc74499 
> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 21597: Return empty list instead of failing.

2014-05-21 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43634
---

Ship it!


Ship It!

- Mark Chu-Carroll


On May 21, 2014, 12:05 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> ---
> 
> (Updated May 21, 2014, 12:05 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
> https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA 
> command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> a20b5d46221981740e0b7d5f0958516560928b54 
>   src/main/python/apache/aurora/client/base.py 
> 13730fd98e36377376e498f414dfb317d5b3b114 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 86b6775e51cab1214a6cae01145f19f08cc74499 
> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 21597: Return empty list instead of failing.

2014-05-21 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/
---

(Updated May 21, 2014, 4:05 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-442
https://issues.apache.org/jira/browse/AURORA-442


Repository: aurora


Description
---

Mistyped or unknown to scheduler hosts should not result in failing the SLA 
command.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/sla.py 
a20b5d46221981740e0b7d5f0958516560928b54 
  src/main/python/apache/aurora/client/base.py 
13730fd98e36377376e498f414dfb317d5b3b114 
  src/test/python/apache/aurora/client/api/test_sla.py 
86b6775e51cab1214a6cae01145f19f08cc74499 

Diff: https://reviews.apache.org/r/21597/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 21597: Return empty list instead of failing.

2014-05-21 Thread Maxim Khutornenko 


> On May 21, 2014, 1:38 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/base.py, line 47
> > 
> >
> > Why are these split into multiple methods? The only place where 
> > "check_and_log_locked" is used is right here.
> >

Good question. The check_and_log_locked got refactored out in 
https://reviews.apache.org/r/16310 but was never removed. Fixing it now.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43569
---


On May 19, 2014, 5:58 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> ---
> 
> (Updated May 19, 2014, 5:58 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
> https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA 
> command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> a20b5d46221981740e0b7d5f0958516560928b54 
>   src/main/python/apache/aurora/client/base.py 
> 13730fd98e36377376e498f414dfb317d5b3b114 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 86b6775e51cab1214a6cae01145f19f08cc74499 
> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 21597: Return empty list instead of failing.

2014-05-20 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43569
---



src/main/python/apache/aurora/client/base.py


Why are these split into multiple methods? The only place where 
"check_and_log_locked" is used is right here.



- Mark Chu-Carroll


On May 19, 2014, 1:58 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> ---
> 
> (Updated May 19, 2014, 1:58 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
> https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA 
> command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> a20b5d46221981740e0b7d5f0958516560928b54 
>   src/main/python/apache/aurora/client/base.py 
> 13730fd98e36377376e498f414dfb317d5b3b114 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 86b6775e51cab1214a6cae01145f19f08cc74499 
> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 21597: Return empty list instead of failing.

2014-05-19 Thread Maxim Khutornenko 


> On May 18, 2014, 7:08 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/api/sla.py, lines 292-293
> > 
> >
> > seems like we should have a log_response method instead of 
> > reimplementing here?

Sure, works for me.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43327
---


On May 17, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> ---
> 
> (Updated May 17, 2014, 12:18 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
> https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA 
> command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> a20b5d46221981740e0b7d5f0958516560928b54 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 86b6775e51cab1214a6cae01145f19f08cc74499 
> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 21597: Return empty list instead of failing.

2014-05-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/
---

(Updated May 19, 2014, 5:58 p.m.)


Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-442
https://issues.apache.org/jira/browse/AURORA-442


Repository: aurora


Description
---

Mistyped or unknown to scheduler hosts should not result in failing the SLA 
command.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/sla.py 
a20b5d46221981740e0b7d5f0958516560928b54 
  src/main/python/apache/aurora/client/base.py 
13730fd98e36377376e498f414dfb317d5b3b114 
  src/test/python/apache/aurora/client/api/test_sla.py 
86b6775e51cab1214a6cae01145f19f08cc74499 

Diff: https://reviews.apache.org/r/21597/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 21597: Return empty list instead of failing.

2014-05-18 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/#review43327
---



src/main/python/apache/aurora/client/api/sla.py


seems like we should have a log_response method instead of reimplementing 
here?


- Brian Wickman


On May 17, 2014, 12:18 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21597/
> ---
> 
> (Updated May 17, 2014, 12:18 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
> 
> 
> Bugs: AURORA-442
> https://issues.apache.org/jira/browse/AURORA-442
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mistyped or unknown to scheduler hosts should not result in failing the SLA 
> command.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/sla.py 
> a20b5d46221981740e0b7d5f0958516560928b54 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 86b6775e51cab1214a6cae01145f19f08cc74499 
> 
> Diff: https://reviews.apache.org/r/21597/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 21597: Return empty list instead of failing.

2014-05-16 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21597/
---

Review request for Aurora, Mark Chu-Carroll and Brian Wickman.


Bugs: AURORA-442
https://issues.apache.org/jira/browse/AURORA-442


Repository: aurora


Description
---

Mistyped or unknown to scheduler hosts should not result in failing the SLA 
command.


Diffs
-

  src/main/python/apache/aurora/client/api/sla.py 
a20b5d46221981740e0b7d5f0958516560928b54 
  src/test/python/apache/aurora/client/api/test_sla.py 
86b6775e51cab1214a6cae01145f19f08cc74499 

Diff: https://reviews.apache.org/r/21597/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko