subject:"Review Request 21790\: Upgrade Aurora UI to bootstrap3"

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-28 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/
---

(Updated May 28, 2014, 6:53 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

Rebased with master


Bugs: AURORA-449
https://issues.apache.org/jira/browse/AURORA-449


Repository: aurora


Description
---

Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
0.2.1 since it is more friendly to bootstrap3.
Updated our html per bootstrap migration guide.
Fixed layout issues with new CSS.
Removed the extra large glyphicons set from our code base since we are using 
svg icons from bootstrap3. 
Added a .bowerrc file to make bower usable from project root.
Updated stats image to use glyphicons from bootstrap3.
Removed dividers from breadcrumb bar since we get them for free in bootstrap3.

All the updated files are in page 1 and page 12.


Diffs
-

  .bowerrc PRE-CREATION 
  3rdparty/javascript/bootstrap-glyphicons-master/README.md 
b5182d74856bd362409508837606f8ccbddd9dad 
  3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
  
3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
 6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
  3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
  3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
  3rdparty/javascript/bower_components/bootstrap.css/README.md 
b82b70e5b9b9092935e7105257a9bb22d5950ae6 
  3rdparty/javascript/bower_components/bootstrap.css/bower.json 
977c5817368e93febe7b75d3f70fbcf6cd73a385 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css 
09e88ce3fecc2812ad729e156975e2e53f8aea22 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
 f4ede63f32e2ec803876a38efac05dd49acc4684 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
b725064aab21e434d29209d259d3892478aa9536 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
b6428e695860151f82076e87810fe2d19c2a 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
 3bf6484a29d8da269f9bc874b25493a45fae3bae 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png 
a9969993201f9cee63cf9f49217646347297b643 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
643e71cdf087886ad2909b69d9b8cee864d9ef2c 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
  3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
 PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/modal.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/popover.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/scrollspy.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tab.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tooltip.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/transition.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/less/alerts.less PRE-CREATION 
  3rdparty/java

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-28 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/
---

(Updated May 28, 2014, 6:52 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

Rebased with master


Bugs: AURORA-449
https://issues.apache.org/jira/browse/AURORA-449


Repository: aurora


Description
---

Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
0.2.1 since it is more friendly to bootstrap3.
Updated our html per bootstrap migration guide.
Fixed layout issues with new CSS.
Removed the extra large glyphicons set from our code base since we are using 
svg icons from bootstrap3. 
Added a .bowerrc file to make bower usable from project root.
Updated stats image to use glyphicons from bootstrap3.
Removed dividers from breadcrumb bar since we get them for free in bootstrap3.

All the updated files are in page 1 and page 12.


Diffs (updated)
-

  .bowerrc PRE-CREATION 
  3rdparty/javascript/bootstrap-glyphicons-master/README.md 
b5182d74856bd362409508837606f8ccbddd9dad 
  3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
  
3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
 6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
  3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
  3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
  3rdparty/javascript/bower_components/bootstrap.css/README.md 
b82b70e5b9b9092935e7105257a9bb22d5950ae6 
  3rdparty/javascript/bower_components/bootstrap.css/bower.json 
977c5817368e93febe7b75d3f70fbcf6cd73a385 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css 
09e88ce3fecc2812ad729e156975e2e53f8aea22 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
 f4ede63f32e2ec803876a38efac05dd49acc4684 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
b725064aab21e434d29209d259d3892478aa9536 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
b6428e695860151f82076e87810fe2d19c2a 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
 3bf6484a29d8da269f9bc874b25493a45fae3bae 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png 
a9969993201f9cee63cf9f49217646347297b643 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
643e71cdf087886ad2909b69d9b8cee864d9ef2c 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
  3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
 PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/modal.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/popover.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/scrollspy.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tab.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tooltip.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/transition.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/less/alerts.less PRE-CREATION 
  3rd

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43883
---

Ship it!


Ship It!

- Bill Farner


On May 23, 2014, 7:13 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 23, 2014, 7:13 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
> f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
>   3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>  PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
> PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js
>  PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/modal.j

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/
---

(Updated May 23, 2014, 7:13 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-449
https://issues.apache.org/jira/browse/AURORA-449


Repository: aurora


Description
---

Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
0.2.1 since it is more friendly to bootstrap3.
Updated our html per bootstrap migration guide.
Fixed layout issues with new CSS.
Removed the extra large glyphicons set from our code base since we are using 
svg icons from bootstrap3. 
Added a .bowerrc file to make bower usable from project root.
Updated stats image to use glyphicons from bootstrap3.
Removed dividers from breadcrumb bar since we get them for free in bootstrap3.

All the updated files are in page 1 and page 12.


Diffs
-

  .bowerrc PRE-CREATION 
  3rdparty/javascript/bootstrap-glyphicons-master/README.md 
b5182d74856bd362409508837606f8ccbddd9dad 
  3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
  
3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
 6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
  3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
  3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
  3rdparty/javascript/bower_components/bootstrap.css/README.md 
b82b70e5b9b9092935e7105257a9bb22d5950ae6 
  3rdparty/javascript/bower_components/bootstrap.css/bower.json 
977c5817368e93febe7b75d3f70fbcf6cd73a385 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css 
09e88ce3fecc2812ad729e156975e2e53f8aea22 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
 f4ede63f32e2ec803876a38efac05dd49acc4684 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
b725064aab21e434d29209d259d3892478aa9536 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
b6428e695860151f82076e87810fe2d19c2a 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
 3bf6484a29d8da269f9bc874b25493a45fae3bae 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png 
a9969993201f9cee63cf9f49217646347297b643 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
643e71cdf087886ad2909b69d9b8cee864d9ef2c 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
  3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
 PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/modal.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/popover.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/scrollspy.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tab.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tooltip.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/transition.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/less/alerts.less PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/less/

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/
---

(Updated May 23, 2014, 7:12 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

Addressed David's comments. Fixed nav bar layout issue.


Bugs: AURORA-449
https://issues.apache.org/jira/browse/AURORA-449


Repository: aurora


Description
---

Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
0.2.1 since it is more friendly to bootstrap3.
Updated our html per bootstrap migration guide.
Fixed layout issues with new CSS.
Removed the extra large glyphicons set from our code base since we are using 
svg icons from bootstrap3. 
Added a .bowerrc file to make bower usable from project root.
Updated stats image to use glyphicons from bootstrap3.
Removed dividers from breadcrumb bar since we get them for free in bootstrap3.

All the updated files are in page 1 and page 12.


Diffs (updated)
-

  .bowerrc PRE-CREATION 
  3rdparty/javascript/bootstrap-glyphicons-master/README.md 
b5182d74856bd362409508837606f8ccbddd9dad 
  3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
  
3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
 6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
  3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
  3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
  3rdparty/javascript/bower_components/bootstrap.css/README.md 
b82b70e5b9b9092935e7105257a9bb22d5950ae6 
  3rdparty/javascript/bower_components/bootstrap.css/bower.json 
977c5817368e93febe7b75d3f70fbcf6cd73a385 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css 
09e88ce3fecc2812ad729e156975e2e53f8aea22 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
 f4ede63f32e2ec803876a38efac05dd49acc4684 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
b725064aab21e434d29209d259d3892478aa9536 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
b6428e695860151f82076e87810fe2d19c2a 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
 3bf6484a29d8da269f9bc874b25493a45fae3bae 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png 
a9969993201f9cee63cf9f49217646347297b643 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
643e71cdf087886ad2909b69d9b8cee864d9ef2c 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
  3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
 PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/modal.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/popover.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/scrollspy.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tab.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tooltip.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/transition.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-23 Thread Suman Karumuri



> On May 22, 2014, 11:37 p.m., David McLaughlin wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css, line 127
> > 
> >
> > We should probably decide on a naming convention for custom CSS. I've 
> > been using camelCase for consistency but I actually prefer hyphens.

Let's use hyphens since that seems to be the standard in the css libraries also.


> On May 22, 2014, 11:37 p.m., David McLaughlin wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, 
> > line 30
> > 
> >
> > Do we have a value like columns.length we can use for this value rather 
> > than use a magic number?

Was trying to minimize the amount of code. Setting it accurately now.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43794
---


On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 22, 2014, 7:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
> f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
>   3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread Suman Karumuri



> On May 22, 2014, 7:33 p.m., David McLaughlin wrote:
> > I would have to object to the amount of new files added with this review. 
> > Is there any way to tell bower to only install the files defined in main? 
> > The vast majority of these new files are superfluous.
> 
> Suman Karumuri wrote:
> AFAICT, there is no way to install just the main files using bower. We 
> need a separate tool like https://github.com/blittle/bower-installer for that.
> 
> The typical workflow for installing client side packages seems to be via 
> grunt, which downloads packages via bower, selects the files it needs, minify 
> them and produce them as a single js/css file respectively.
> 
> I am not a fan of this approach, but this is has been the simplest 
> solution that keeps the right versions of dependencies (for example, what 
> version of jquery do I need for bootstrap3?) while making our build and 
> packaging story easier. Bower does allow us to download the files at build 
> time, but we didn't prefer that route because we will be taking a build time 
> dependency on node.js. 
> 
> However, as part of https://issues.apache.org/jira/browse/AURORA-451, I 
> will be looking at installing grunt. Once that is done, we can download npm 
> at build time just like we do with gradle. Once that is done, we can get rid 
> of all the bower_components entirely and install files at run time. 
> 
> I think for this review, we should just do what we are already doing and 
> explore the packaging story for client libraries in a separate ticket.
> 
> David McLaughlin wrote:
> What we are doing right now is just running bower manually, so why not 
> just use bower-installer?

We can use bower-installer as well. Opened 
https://issues.apache.org/jira/browse/AURORA-468 to discuss the future 
direction of this task.


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43760
---


On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 22, 2014, 7:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_compon

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43794
---

Ship it!



src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css


We should probably decide on a naming convention for custom CSS. I've been 
using camelCase for consistency but I actually prefer hyphens. 



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js


Do we have a value like columns.length we can use for this value rather 
than use a magic number?


- David McLaughlin


On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 22, 2014, 7:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
> f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
>   3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>  PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
> PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js
>  PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/b

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin



> On May 22, 2014, 7:33 p.m., David McLaughlin wrote:
> > I would have to object to the amount of new files added with this review. 
> > Is there any way to tell bower to only install the files defined in main? 
> > The vast majority of these new files are superfluous.
> 
> Suman Karumuri wrote:
> AFAICT, there is no way to install just the main files using bower. We 
> need a separate tool like https://github.com/blittle/bower-installer for that.
> 
> The typical workflow for installing client side packages seems to be via 
> grunt, which downloads packages via bower, selects the files it needs, minify 
> them and produce them as a single js/css file respectively.
> 
> I am not a fan of this approach, but this is has been the simplest 
> solution that keeps the right versions of dependencies (for example, what 
> version of jquery do I need for bootstrap3?) while making our build and 
> packaging story easier. Bower does allow us to download the files at build 
> time, but we didn't prefer that route because we will be taking a build time 
> dependency on node.js. 
> 
> However, as part of https://issues.apache.org/jira/browse/AURORA-451, I 
> will be looking at installing grunt. Once that is done, we can download npm 
> at build time just like we do with gradle. Once that is done, we can get rid 
> of all the bower_components entirely and install files at run time. 
> 
> I think for this review, we should just do what we are already doing and 
> explore the packaging story for client libraries in a separate ticket.

What we are doing right now is just running bower manually, so why not just use 
bower-installer? 


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43760
---


On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 22, 2014, 7:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
> f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
>   3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
>   3rdparty/ja

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread Suman Karumuri



> On May 22, 2014, 7:33 p.m., David McLaughlin wrote:
> > I would have to object to the amount of new files added with this review. 
> > Is there any way to tell bower to only install the files defined in main? 
> > The vast majority of these new files are superfluous.

AFAICT, there is no way to install just the main files using bower. We need a 
separate tool like https://github.com/blittle/bower-installer for that.

The typical workflow for installing client side packages seems to be via grunt, 
which downloads packages via bower, selects the files it needs, minify them and 
produce them as a single js/css file respectively.

I am not a fan of this approach, but this is has been the simplest solution 
that keeps the right versions of dependencies (for example, what version of 
jquery do I need for bootstrap3?) while making our build and packaging story 
easier. Bower does allow us to download the files at build time, but we didn't 
prefer that route because we will be taking a build time dependency on node.js. 

However, as part of https://issues.apache.org/jira/browse/AURORA-451, I will be 
looking at installing grunt. Once that is done, we can download npm at build 
time just like we do with gradle. Once that is done, we can get rid of all the 
bower_components entirely and install files at run time. 

I think for this review, we should just do what we are already doing and 
explore the packaging story for client libraries in a separate ticket. 


- Suman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43760
---


On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 22, 2014, 7:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
> f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
>   3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/README.md PRE-CRE

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/#review43760
---


I would have to object to the amount of new files added with this review. Is 
there any way to tell bower to only install the files defined in main? The vast 
majority of these new files are superfluous. 

- David McLaughlin


On May 22, 2014, 7:09 p.m., Suman Karumuri wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21790/
> ---
> 
> (Updated May 22, 2014, 7:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-449
> https://issues.apache.org/jira/browse/AURORA-449
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
> 0.2.1 since it is more friendly to bootstrap3.
> Updated our html per bootstrap migration guide.
> Fixed layout issues with new CSS.
> Removed the extra large glyphicons set from our code base since we are using 
> svg icons from bootstrap3. 
> Added a .bowerrc file to make bower usable from project root.
> Updated stats image to use glyphicons from bootstrap3.
> Removed dividers from breadcrumb bar since we get them for free in bootstrap3.
> 
> All the updated files are in page 1 and page 12.
> 
> 
> Diffs
> -
> 
>   .bowerrc PRE-CREATION 
>   3rdparty/javascript/bootstrap-glyphicons-master/README.md 
> b5182d74856bd362409508837606f8ccbddd9dad 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
> 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
>   
> 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
>  6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
>   3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
> 0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
>   3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
> b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
>   3rdparty/javascript/bower_components/bootstrap.css/README.md 
> b82b70e5b9b9092935e7105257a9bb22d5950ae6 
>   3rdparty/javascript/bower_components/bootstrap.css/bower.json 
> 977c5817368e93febe7b75d3f70fbcf6cd73a385 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css
>  09e88ce3fecc2812ad729e156975e2e53f8aea22 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
>  f4ede63f32e2ec803876a38efac05dd49acc4684 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
> b725064aab21e434d29209d259d3892478aa9536 
>   3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
> b6428e695860151f82076e87810fe2d19c2a 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
>  3bf6484a29d8da269f9bc874b25493a45fae3bae 
>   
> 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png
>  a9969993201f9cee63cf9f49217646347297b643 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
> 643e71cdf087886ad2909b69d9b8cee864d9ef2c 
>   3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
> f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
>   3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
>  PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
>  PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
> PRE-CREATION 
>   
> 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js
>  PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
> PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
>   3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
>   3rdparty/javascript/bower_

Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread Suman Karumuri


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21790/
---

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-449
https://issues.apache.org/jira/browse/AURORA-449


Repository: aurora


Description
---

Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version 
0.2.1 since it is more friendly to bootstrap3.
Updated our html per bootstrap migration guide.
Fixed layout issues with new CSS.
Removed the extra large glyphicons set from our code base since we are using 
svg icons from bootstrap3. 
Added a .bowerrc file to make bower usable from project root.
Updated stats image to use glyphicons from bootstrap3.
Removed dividers from breadcrumb bar since we get them for free in bootstrap3.

All the updated files are in page 1 and page 12.


Diffs
-

  .bowerrc PRE-CREATION 
  3rdparty/javascript/bootstrap-glyphicons-master/README.md 
b5182d74856bd362409508837606f8ccbddd9dad 
  3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css 
4a6b1ef28e2081414eff47d5056a82d6f268b9a1 
  
3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css
 6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c 
  3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png 
0b858192e32cc3690ba3e9d71743c5ba64ec40fc 
  3rdparty/javascript/bower_components/bootstrap.css/.bower.json 
b20efca9a93e1f22472dde7c96f45269e7b9ef3e 
  3rdparty/javascript/bower_components/bootstrap.css/README.md 
b82b70e5b9b9092935e7105257a9bb22d5950ae6 
  3rdparty/javascript/bower_components/bootstrap.css/bower.json 
977c5817368e93febe7b75d3f70fbcf6cd73a385 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css 
09e88ce3fecc2812ad729e156975e2e53f8aea22 
  
3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css
 f4ede63f32e2ec803876a38efac05dd49acc4684 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css 
b725064aab21e434d29209d259d3892478aa9536 
  3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css 
b6428e695860151f82076e87810fe2d19c2a 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png
 3bf6484a29d8da269f9bc874b25493a45fae3bae 
  
3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png 
a9969993201f9cee63cf9f49217646347297b643 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js 
643e71cdf087886ad2909b69d9b8cee864d9ef2c 
  3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js 
f9cbdae7c50d68635a3c8de0d35c29290fb1624b 
  3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff
 PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js
 PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js 
PRE-CREATION 
  
3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js 
PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/modal.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/popover.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/scrollspy.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tab.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/tooltip.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/js/transition.js PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/less/alerts.less PRE-CREATION 
  3rdparty/javascript/bower_components/bootstrap/less/badges.less PRE-CREATION 
  3rdparty

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

Review Request 21790: Upgrade Aurora UI to bootstrap3

12 matches

Site Navigation

Mail list logo

Footer information