Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- (Updated July 23, 2014, 5:10 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review48448 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 6:33 p.m., Bi

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review48074 --- Kevin - ping? - Bill Farner On July 2, 2014, 1:33 a.m., Bill Farn

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review47192 --- Ship it! Ship It! - Maxim Khutornenko On July 2, 2014, 1:33 a.m.

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-01 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- (Updated July 2, 2014, 1:33 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-01 Thread Bill Farner
> On June 27, 2014, 3:10 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 17-20 > > > > > > Add UNIQUE constraint just to be defensive from the schema s

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-01 Thread Bill Farner
> On June 27, 2014, 11:56 p.m., Kevin Sweeney wrote: > > How would you feel about taking this opportunity to move the framework ID > > to a command-line flag instead. This has always been a scary thing - you > > almost always want a set, immutable framework ID generated when you > > initially

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-06-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review46929 --- How would you feel about taking this opportunity to move the framewo

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-06-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review46863 --- src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sq

Review Request 23107: Database-backed implementation of SchedulerStore.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-555 https://issue