Re: Review Request 25953: Allow optional initial and desired states.

2014-09-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/ --- (Updated Sept. 23, 2014, 9:10 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25953: Allow optional initial and desired states.

2014-09-23 Thread Maxim Khutornenko
> On Sept. 23, 2014, 8:48 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, > > line 87 > > > > > > You should include a precondition check for desiredState being

Re: Review Request 25953: Allow optional initial and desired states.

2014-09-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/#review54328 --- Ship it! LGTM with a few minor changes. src/main/java/org/apache/

Review Request 25953: Allow optional initial and desired states.

2014-09-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25953/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-741 https://issues.