Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/ --- (Updated Sept. 30, 2014, 10:08 p.m.) Review request for Aurora and Maxim Khutor

Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/ --- (Updated Sept. 30, 2014, 9:53 p.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-30 Thread Bill Farner
> On Sept. 30, 2014, 4:51 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1431 > > > > > > This needs to be OK response. Reverted. - Bill

Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/#review54984 --- Ship it! src/main/java/org/apache/aurora/scheduler/thrift/Schedule

Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/ --- (Updated Sept. 30, 2014, 3:09 a.m.) Review request for Aurora and Maxim Khutorn

Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-29 Thread Bill Farner
> On Sept. 30, 2014, 1:38 a.m., Maxim Khutornenko wrote: > > Not quite obvious from the diff: why was not it enough to check the noop > > condition in the controller only? `SchedulerThriftInterface` would get a `JobDiff`, and use that to build `IJobUpdateInstructions`. `JobUpdateControllerImp

Re: Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/#review54934 --- Not quite obvious from the diff: why was not it enough to check the

Review Request 26158: Perform job update no-op detection in SchedulerThriftInterface.

2014-09-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26158/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-769 https://i