Re: Review Request 26430: Remove deprecated configuration options.

2014-10-16 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---

(Updated Oct. 16, 2014, 2:09 p.m.)


Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Changes
---

Rebase on top of master.


Bugs: AURORA-333
https://issues.apache.org/jira/browse/AURORA-333


Repository: aurora


Description
---

This removes several long deprecated configuration options from aurora.

The features removed are automatically filling out environment, cron_policy, 
daemon, health_check_interval_secs, recipes and the PackerObject.


Diffs (updated)
-

  docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 865742171c11fbe5cf1469a69dd7258ec1be28c2 
  src/main/python/apache/aurora/client/binding_helper.py 
6d6a06785c6840e4345e304eb4e242682676ac66 
  src/main/python/apache/aurora/client/config.py 
e440f587d100ce46b2df85ccc663912c615051ef 
  src/main/python/apache/aurora/config/recipes.py 
68b5d252f87a592d4c2f7d52525163829bea2cc9 
  src/main/python/apache/aurora/config/schema/base.py 
f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
  src/main/python/apache/aurora/config/thrift.py 
288fb40f65629c8fd4eb7d92c8bf02369237de3b 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8794731f4b3f1033588bdfa33c292e4796319a2a 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 ee9587582bd7c45a446e8afe28930c18a97d2792 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
d3c90416e48e25d83f28f966b21c018ee2a1ac27 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
cdd29ea2b6fc92b967571028d299260556e16d42 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1835843f1795b0530874ec561582df17acfbce65 
  src/test/python/apache/aurora/client/cli/util.py 
967b5dcdab76f0581f6d2a518409c30de0800f27 
  src/test/python/apache/aurora/client/commands/util.py 
663f2f4a16113a36826943b7238cad900ae0dcd2 
  src/test/python/apache/aurora/client/test_config.py 
901c3378ed59c44b7e2dea239f186193f1f66355 
  src/test/python/apache/aurora/config/test_thrift.py 
fd28313df2cfd5a9c7d00f6d329518b4caabacb2 

Diff: https://reviews.apache.org/r/26430/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Zameer Manji

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-16 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review56984
---


Patch failed to apply. Needs rebasing.

- Maxim Khutornenko


On Oct. 16, 2014, 6:21 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 16, 2014, 6:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are automatically filling out environment, cron_policy, 
> daemon, health_check_interval_secs, recipes and the PackerObject.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  865742171c11fbe5cf1469a69dd7258ec1be28c2 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> d3c90416e48e25d83f28f966b21c018ee2a1ac27 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/cli/util.py 
> 967b5dcdab76f0581f6d2a518409c30de0800f27 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/client/test_config.py 
> 901c3378ed59c44b7e2dea239f186193f1f66355 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-16 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review56978
---

Ship it!


- Maxim Khutornenko


On Oct. 16, 2014, 6:21 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 16, 2014, 6:21 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian 
> Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are automatically filling out environment, cron_policy, 
> daemon, health_check_interval_secs, recipes and the PackerObject.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  865742171c11fbe5cf1469a69dd7258ec1be28c2 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> d3c90416e48e25d83f28f966b21c018ee2a1ac27 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/cli/util.py 
> 967b5dcdab76f0581f6d2a518409c30de0800f27 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/client/test_config.py 
> 901c3378ed59c44b7e2dea239f186193f1f66355 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-16 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---

(Updated Oct. 16, 2014, 11:21 a.m.)


Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Changes
---

Drop markcc add maxim


Bugs: AURORA-333
https://issues.apache.org/jira/browse/AURORA-333


Repository: aurora


Description
---

This removes several long deprecated configuration options from aurora.

The features removed are automatically filling out environment, cron_policy, 
daemon, health_check_interval_secs, recipes and the PackerObject.


Diffs
-

  docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 865742171c11fbe5cf1469a69dd7258ec1be28c2 
  src/main/python/apache/aurora/client/binding_helper.py 
6d6a06785c6840e4345e304eb4e242682676ac66 
  src/main/python/apache/aurora/client/config.py 
e440f587d100ce46b2df85ccc663912c615051ef 
  src/main/python/apache/aurora/config/recipes.py 
68b5d252f87a592d4c2f7d52525163829bea2cc9 
  src/main/python/apache/aurora/config/schema/base.py 
f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
  src/main/python/apache/aurora/config/thrift.py 
288fb40f65629c8fd4eb7d92c8bf02369237de3b 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8794731f4b3f1033588bdfa33c292e4796319a2a 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 ee9587582bd7c45a446e8afe28930c18a97d2792 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
d3c90416e48e25d83f28f966b21c018ee2a1ac27 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
cdd29ea2b6fc92b967571028d299260556e16d42 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1835843f1795b0530874ec561582df17acfbce65 
  src/test/python/apache/aurora/client/cli/util.py 
967b5dcdab76f0581f6d2a518409c30de0800f27 
  src/test/python/apache/aurora/client/commands/util.py 
663f2f4a16113a36826943b7238cad900ae0dcd2 
  src/test/python/apache/aurora/client/test_config.py 
901c3378ed59c44b7e2dea239f186193f1f66355 
  src/test/python/apache/aurora/config/test_thrift.py 
fd28313df2cfd5a9c7d00f6d329518b4caabacb2 

Diff: https://reviews.apache.org/r/26430/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Zameer Manji

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-15 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review56751
---

Ship it!


Ship It!

- Brian Wickman


On Oct. 8, 2014, 10:29 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 8, 2014, 10:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are automatically filling out environment, cron_policy, 
> daemon, health_check_interval_secs, recipes and the PackerObject.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  865742171c11fbe5cf1469a69dd7258ec1be28c2 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> d3c90416e48e25d83f28f966b21c018ee2a1ac27 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/cli/util.py 
> 967b5dcdab76f0581f6d2a518409c30de0800f27 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/client/test_config.py 
> 901c3378ed59c44b7e2dea239f186193f1f66355 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-14 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review56565
---


Ping Pong

- Zameer Manji


On Oct. 8, 2014, 3:29 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 8, 2014, 3:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are automatically filling out environment, cron_policy, 
> daemon, health_check_interval_secs, recipes and the PackerObject.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  865742171c11fbe5cf1469a69dd7258ec1be28c2 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> d3c90416e48e25d83f28f966b21c018ee2a1ac27 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/cli/util.py 
> 967b5dcdab76f0581f6d2a518409c30de0800f27 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/client/test_config.py 
> 901c3378ed59c44b7e2dea239f186193f1f66355 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-13 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review56417
---


Pinging Mark and Wickman to this review.

- Zameer Manji


On Oct. 8, 2014, 3:29 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 8, 2014, 3:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are automatically filling out environment, cron_policy, 
> daemon, health_check_interval_secs, recipes and the PackerObject.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  865742171c11fbe5cf1469a69dd7258ec1be28c2 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> d3c90416e48e25d83f28f966b21c018ee2a1ac27 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/cli/util.py 
> 967b5dcdab76f0581f6d2a518409c30de0800f27 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/client/test_config.py 
> 901c3378ed59c44b7e2dea239f186193f1f66355 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-08 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review55885
---

Ship it!


Ship It!

- Kevin Sweeney


On Oct. 8, 2014, 3:29 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 8, 2014, 3:29 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are automatically filling out environment, cron_policy, 
> daemon, health_check_interval_secs, recipes and the PackerObject.
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  865742171c11fbe5cf1469a69dd7258ec1be28c2 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8794731f4b3f1033588bdfa33c292e4796319a2a 
>   
> src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
>  ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
> d3c90416e48e25d83f28f966b21c018ee2a1ac27 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cdd29ea2b6fc92b967571028d299260556e16d42 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 1835843f1795b0530874ec561582df17acfbce65 
>   src/test/python/apache/aurora/client/cli/util.py 
> 967b5dcdab76f0581f6d2a518409c30de0800f27 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/client/test_config.py 
> 901c3378ed59c44b7e2dea239f186193f1f66355 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-08 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---

(Updated Oct. 8, 2014, 3:29 p.m.)


Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.


Bugs: AURORA-333
https://issues.apache.org/jira/browse/AURORA-333


Repository: aurora


Description (updated)
---

This removes several long deprecated configuration options from aurora.

The features removed are automatically filling out environment, cron_policy, 
daemon, health_check_interval_secs, recipes and the PackerObject.


Diffs
-

  docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 865742171c11fbe5cf1469a69dd7258ec1be28c2 
  src/main/python/apache/aurora/client/binding_helper.py 
6d6a06785c6840e4345e304eb4e242682676ac66 
  src/main/python/apache/aurora/client/config.py 
e440f587d100ce46b2df85ccc663912c615051ef 
  src/main/python/apache/aurora/config/recipes.py 
68b5d252f87a592d4c2f7d52525163829bea2cc9 
  src/main/python/apache/aurora/config/schema/base.py 
f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
  src/main/python/apache/aurora/config/thrift.py 
288fb40f65629c8fd4eb7d92c8bf02369237de3b 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8794731f4b3f1033588bdfa33c292e4796319a2a 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 ee9587582bd7c45a446e8afe28930c18a97d2792 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
d3c90416e48e25d83f28f966b21c018ee2a1ac27 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
cdd29ea2b6fc92b967571028d299260556e16d42 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1835843f1795b0530874ec561582df17acfbce65 
  src/test/python/apache/aurora/client/cli/util.py 
967b5dcdab76f0581f6d2a518409c30de0800f27 
  src/test/python/apache/aurora/client/commands/util.py 
663f2f4a16113a36826943b7238cad900ae0dcd2 
  src/test/python/apache/aurora/client/test_config.py 
901c3378ed59c44b7e2dea239f186193f1f66355 
  src/test/python/apache/aurora/config/test_thrift.py 
fd28313df2cfd5a9c7d00f6d329518b4caabacb2 

Diff: https://reviews.apache.org/r/26430/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Zameer Manji

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-08 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---

(Updated Oct. 8, 2014, 3:29 p.m.)


Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.


Changes
---

Brian's feedback.


Bugs: AURORA-333
https://issues.apache.org/jira/browse/AURORA-333


Repository: aurora


Description
---

This removes several long deprecated configuration options from aurora.

The features removed are cron_policy, daemon, health_check_interval_secs, 
recipes and the PackerObject


Diffs (updated)
-

  docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 865742171c11fbe5cf1469a69dd7258ec1be28c2 
  src/main/python/apache/aurora/client/binding_helper.py 
6d6a06785c6840e4345e304eb4e242682676ac66 
  src/main/python/apache/aurora/client/config.py 
e440f587d100ce46b2df85ccc663912c615051ef 
  src/main/python/apache/aurora/config/recipes.py 
68b5d252f87a592d4c2f7d52525163829bea2cc9 
  src/main/python/apache/aurora/config/schema/base.py 
f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
  src/main/python/apache/aurora/config/thrift.py 
288fb40f65629c8fd4eb7d92c8bf02369237de3b 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
8794731f4b3f1033588bdfa33c292e4796319a2a 
  
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
 ee9587582bd7c45a446e8afe28930c18a97d2792 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
d3c90416e48e25d83f28f966b21c018ee2a1ac27 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
cdd29ea2b6fc92b967571028d299260556e16d42 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
1835843f1795b0530874ec561582df17acfbce65 
  src/test/python/apache/aurora/client/cli/util.py 
967b5dcdab76f0581f6d2a518409c30de0800f27 
  src/test/python/apache/aurora/client/commands/util.py 
663f2f4a16113a36826943b7238cad900ae0dcd2 
  src/test/python/apache/aurora/client/test_config.py 
901c3378ed59c44b7e2dea239f186193f1f66355 
  src/test/python/apache/aurora/config/test_thrift.py 
fd28313df2cfd5a9c7d00f6d329518b4caabacb2 

Diff: https://reviews.apache.org/r/26430/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Zameer Manji

Re: Review Request 26430: Remove deprecated configuration options.

2014-10-08 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review55870
---



src/main/python/apache/aurora/client/config.py


default environments are also deprecated and should be removed.



src/main/python/apache/aurora/config/thrift.py


cron_policy shouldn't be empty right?  since it's a Default() field.



src/main/python/apache/aurora/config/thrift.py


same -- service is a Default(Boolean, False) so has_service() should never 
be false.


- Brian Wickman


On Oct. 8, 2014, 12:05 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26430/
> ---
> 
> (Updated Oct. 8, 2014, 12:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-333
> https://issues.apache.org/jira/browse/AURORA-333
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This removes several long deprecated configuration options from aurora.
> 
> The features removed are cron_policy, daemon, health_check_interval_secs, 
> recipes and the PackerObject
> 
> 
> Diffs
> -
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   src/main/python/apache/aurora/client/binding_helper.py 
> 6d6a06785c6840e4345e304eb4e242682676ac66 
>   src/main/python/apache/aurora/client/config.py 
> e440f587d100ce46b2df85ccc663912c615051ef 
>   src/main/python/apache/aurora/config/recipes.py 
> 68b5d252f87a592d4c2f7d52525163829bea2cc9 
>   src/main/python/apache/aurora/config/schema/base.py 
> f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
>   src/main/python/apache/aurora/config/thrift.py 
> 288fb40f65629c8fd4eb7d92c8bf02369237de3b 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 38ffdb86c5f577ebf3a482128588331a63af15d1 
>   src/test/python/apache/aurora/client/cli/util.py 
> ff7eda20dbba073c8b24fbe3f4389292aab2d128 
>   src/test/python/apache/aurora/client/commands/util.py 
> 663f2f4a16113a36826943b7238cad900ae0dcd2 
>   src/test/python/apache/aurora/config/test_thrift.py 
> fd28313df2cfd5a9c7d00f6d329518b4caabacb2 
> 
> Diff: https://reviews.apache.org/r/26430/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 26430: Remove deprecated configuration options.

2014-10-07 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---

Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.


Bugs: AURORA-333
https://issues.apache.org/jira/browse/AURORA-333


Repository: aurora


Description
---

This removes several long deprecated configuration options from aurora.

The features removed are cron_policy, daemon, health_check_interval_secs, 
recipes and the PackerObject


Diffs
-

  docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
  src/main/python/apache/aurora/client/binding_helper.py 
6d6a06785c6840e4345e304eb4e242682676ac66 
  src/main/python/apache/aurora/client/config.py 
e440f587d100ce46b2df85ccc663912c615051ef 
  src/main/python/apache/aurora/config/recipes.py 
68b5d252f87a592d4c2f7d52525163829bea2cc9 
  src/main/python/apache/aurora/config/schema/base.py 
f12634f103c3eb20e43f37c25d9b0fc3e3d228ec 
  src/main/python/apache/aurora/config/thrift.py 
288fb40f65629c8fd4eb7d92c8bf02369237de3b 
  src/test/python/apache/aurora/client/cli/test_status.py 
38ffdb86c5f577ebf3a482128588331a63af15d1 
  src/test/python/apache/aurora/client/cli/util.py 
ff7eda20dbba073c8b24fbe3f4389292aab2d128 
  src/test/python/apache/aurora/client/commands/util.py 
663f2f4a16113a36826943b7238cad900ae0dcd2 
  src/test/python/apache/aurora/config/test_thrift.py 
fd28313df2cfd5a9c7d00f6d329518b4caabacb2 

Diff: https://reviews.apache.org/r/26430/diff/


Testing
---

./build-support/jenkins/build.sh


Thanks,

Zameer Manji