Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review57164 --- Ship it! Ship It! - Joe Smith On Oct. 17, 2014, 8:48 a.m., Maxim

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/ --- (Updated Oct. 17, 2014, 3:48 p.m.) Review request for Aurora, Joe Smith and Bri

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Maxim Khutornenko
> On Oct. 15, 2014, 7:04 p.m., Joe Smith wrote: > > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 206 > > > > > > mock_wait.assert_called_once_with Added. - Maxim

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Maxim Khutornenko
> On Oct. 15, 2014, 6:08 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 41 > > > > > > minor nit: > > Amount(5, Time.MINUTES) Done. - Maxim

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review56774 --- src/test/python/apache/aurora/client/commands/test_maintenance.py <

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-15 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review56752 --- Ship it! src/main/python/apache/aurora/admin/host_maintenance.py <

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review56437 --- Ping, Joe, Brian. - Maxim Khutornenko On Oct. 10, 2014, 10 p.m.,

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/ --- (Updated Oct. 10, 2014, 10 p.m.) Review request for Aurora, Joe Smith and Brian

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-10 Thread Maxim Khutornenko
> On Oct. 9, 2014, 12:08 a.m., Tobias Weingartner wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, lines 87-88 > > > > > > Will this abort aurora_admin? > > > > If so, writing these to the fa

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-10 Thread Maxim Khutornenko
> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 52 > > > > > > Is this provided so external modules can interact with the maintenance? Correct. Just a g

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Tobias Weingartner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review55909 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review55899 --- src/main/python/apache/aurora/admin/host_maintenance.py

Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/ --- Review request for Aurora, Joe Smith and Brian Wickman. Bugs: AURORA-820 ht