Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review57164
---

Ship it!


Ship It!

- Joe Smith


On Oct. 17, 2014, 8:48 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 17, 2014, 8:48 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/
---

(Updated Oct. 17, 2014, 3:48 p.m.)


Review request for Aurora, Joe Smith and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-820
https://issues.apache.org/jira/browse/AURORA-820


Repository: aurora


Description
---

Throttling status check calls now at a predefined 5 second interval with a max 
timeout of 5 minutes.


Diffs (updated)
-

  src/main/python/apache/aurora/admin/host_maintenance.py 
9c2a9f77109791da574e1624d27b6b7096a2678e 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 
40228df59e43bc6034f2dc651c166a0c4b78aea8 
  src/test/python/apache/aurora/client/commands/test_maintenance.py 
d86aaf677804301fa5ddf1f76dba552f4fafb8c3 

Diff: https://reviews.apache.org/r/26458/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Maxim Khutornenko 


> On Oct. 15, 2014, 7:04 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 206
> > 
> >
> > mock_wait.assert_called_once_with

Added.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review56774
---


On Oct. 10, 2014, 10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 10, 2014, 10 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Maxim Khutornenko 


> On Oct. 15, 2014, 6:08 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 41
> > 
> >
> > minor nit:
> > Amount(5, Time.MINUTES)

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review56752
---


On Oct. 10, 2014, 10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 10, 2014, 10 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-15 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review56774
---



src/test/python/apache/aurora/client/commands/test_maintenance.py


mock_wait.assert_called_once_with


- Joe Smith


On Oct. 10, 2014, 3 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 10, 2014, 3 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-15 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review56752
---

Ship it!



src/main/python/apache/aurora/admin/host_maintenance.py


minor nit:
Amount(5, Time.MINUTES)


- Brian Wickman


On Oct. 10, 2014, 10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 10, 2014, 10 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-13 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review56437
---


Ping, Joe, Brian.

- Maxim Khutornenko


On Oct. 10, 2014, 10 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 10, 2014, 10 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
>   src/test/python/apache/aurora/client/commands/test_maintenance.py 
> d86aaf677804301fa5ddf1f76dba552f4fafb8c3 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-10 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/
---

(Updated Oct. 10, 2014, 10 p.m.)


Review request for Aurora, Joe Smith and Brian Wickman.


Changes
---

CR comments.


Bugs: AURORA-820
https://issues.apache.org/jira/browse/AURORA-820


Repository: aurora


Description
---

Throttling status check calls now at a predefined 5 second interval with a max 
timeout of 5 minutes.


Diffs (updated)
-

  src/main/python/apache/aurora/admin/host_maintenance.py 
9c2a9f77109791da574e1624d27b6b7096a2678e 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 
40228df59e43bc6034f2dc651c166a0c4b78aea8 
  src/test/python/apache/aurora/client/commands/test_maintenance.py 
d86aaf677804301fa5ddf1f76dba552f4fafb8c3 

Diff: https://reviews.apache.org/r/26458/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-10 Thread Maxim Khutornenko 


> On Oct. 9, 2014, 12:08 a.m., Tobias Weingartner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, lines 87-88
> > 
> >
> > Will this abort aurora_admin?
> > 
> > If so, writing these to the failed set is more desirable, along with 
> > continuing.

Good suggestion. Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55909
---


On Oct. 8, 2014, 9:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 8, 2014, 9:40 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-10 Thread Maxim Khutornenko 


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 52
> > 
> >
> > Is this provided so external modules can interact with the maintenance?

Correct. Just a general approach we follow elsewhere.


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, lines 63-67
> > 
> >
> > move out to its own method?

Done.


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 88
> > 
> >
> > Maybe just raise a normal exception instead? :)
> > 
> > (and maybe log which hosts weren't moved?)

Returning not_drained instead.


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/test/python/apache/aurora/admin/test_host_maintenance.py, line 55
> > 
> >
> > can you assert on how many times this was called?

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55899
---


On Oct. 8, 2014, 9:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 8, 2014, 9:40 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Tobias Weingartner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55909
---



src/main/python/apache/aurora/admin/host_maintenance.py


Will this abort aurora_admin?

If so, writing these to the failed set is more desirable, along with 
continuing.


- Tobias Weingartner


On Oct. 8, 2014, 9:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 8, 2014, 9:40 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Joe Smith 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55899
---



src/main/python/apache/aurora/admin/host_maintenance.py


Is this provided so external modules can interact with the maintenance?



src/main/python/apache/aurora/admin/host_maintenance.py


move out to its own method?



src/main/python/apache/aurora/admin/host_maintenance.py


Maybe just raise a normal exception instead? :)

(and maybe log which hosts weren't moved?)



src/test/python/apache/aurora/admin/test_host_maintenance.py


can you assert on how many times this was called?


- Joe Smith


On Oct. 8, 2014, 2:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> ---
> 
> (Updated Oct. 8, 2014, 2:40 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
> https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Throttling status check calls now at a predefined 5 second interval with a 
> max timeout of 5 minutes.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 9c2a9f77109791da574e1624d27b6b7096a2678e 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 40228df59e43bc6034f2dc651c166a0c4b78aea8 
> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/
---

Review request for Aurora, Joe Smith and Brian Wickman.


Bugs: AURORA-820
https://issues.apache.org/jira/browse/AURORA-820


Repository: aurora


Description
---

Throttling status check calls now at a predefined 5 second interval with a max 
timeout of 5 minutes.


Diffs
-

  src/main/python/apache/aurora/admin/host_maintenance.py 
9c2a9f77109791da574e1624d27b6b7096a2678e 
  src/test/python/apache/aurora/admin/test_host_maintenance.py 
40228df59e43bc6034f2dc651c166a0c4b78aea8 

Diff: https://reviews.apache.org/r/26458/diff/


Testing
---

./pants src/test/python:all


Thanks,

Maxim Khutornenko