---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71520
---
src/test/python/apache/thermos/monitoring/test_resource.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71523
---
Tried to merge but got a conflict. Could you re-merge this with
On Feb. 6, 2015, 3:11 p.m., Brian Wickman wrote:
In practice I've found that this helps catch issues sooner than later, as we'll
see missing dependencies from the main target (which I've done before).
Happy to move away if you disagree though (I know it's a tradeoff)
- Joe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71522
---
Ship it!
Ship It!
- Brian Wickman
On Feb. 6, 2015, 10 p.m., Joe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
(Updated Feb. 6, 2015, 3:55 p.m.)
Review request for Aurora and Brian Wickman.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71510
---
Out of curiosity, why this test now? I sort of see this code on
On Feb. 6, 2015, 1:55 p.m., Brian Wickman wrote:
Out of curiosity, why this test now? I sort of see this code on its
deathbed as soon Mesos will have disk enforcement built in.
This test is from October (and just revived). Until we remove this code, it
should have test coverage.
- Joe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
(Updated Feb. 5, 2015, 9:16 p.m.)
Review request for Aurora and Kevin Sweeney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
(Updated Feb. 5, 2015, 9:18 p.m.)
Review request for Aurora and Kevin Sweeney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
(Updated Feb. 5, 2015, 9:16 p.m.)
Review request for Aurora and Kevin Sweeney.
On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote:
src/test/python/apache/thermos/monitoring/test_resource.py, line 64
https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64
patching a private method assumes intimate knowledge of the class under
test and suggests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71378
---
Ship it!
Master (5059040) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review62604
---
update or discard?
- Kevin Sweeney
On Oct. 24, 2014, 5:12 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review58668
---
src/test/python/apache/thermos/monitoring/test_resource.py
On Oct. 27, 2014, 12:46 p.m., Kevin Sweeney wrote:
src/test/python/apache/thermos/monitoring/test_resource.py, line 64
https://reviews.apache.org/r/27182/diff/1/?file=733141#file733141line64
patching a private method assumes intimate knowledge of the class under
test and suggests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
16 matches
Mail list logo
