Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Bill Farner]

> On Nov. 3, 2014, 11:40 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/async/KillRetry.java, lines 84-85
> > 
> >
> > Since you're not using atomic CAS operations here you don't gain 
> > anything by using an `AtomicLong` over a `volatile` here.

I could, though i tend to generally favor AtomicLong as a general replacement 
for `volatile long`.  Fewer tools.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59680
---


On Nov. 3, 2014, 10:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 10:46 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59680
---

Ship it!



src/main/java/org/apache/aurora/scheduler/async/KillRetry.java


Since you're not using atomic CAS operations here you don't gain anything 
by using an `AtomicLong` over a `volatile` here.


- Kevin Sweeney


On Nov. 3, 2014, 2:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 2:46 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59671
---

Ship it!


Master (9ef905a) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Nov. 3, 2014, 10:46 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 10:46 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/
---

(Updated Nov. 3, 2014, 10:46 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-910
https://issues.apache.org/jira/browse/AURORA-910


Repository: aurora


Description
---

Retry Driver.killTask periodically until the task changes states.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
df7e56a955fef21d48e75797bb5761453ae1e57a 
  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 
748aac83db7c470dc7aed7936e629400c3e6c2d8 
  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
1688a339a1a9c4072d7f834963cb5ccad6fe0736 

Diff: https://reviews.apache.org/r/27467/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Ben Mahler]

> On Nov. 3, 2014, 10:17 p.m., Kevin Sweeney wrote:
> > It seems like exponential backoff is warranted here - in the case that the 
> > master is completely overloaded there may be confirmation status updates in 
> > the queue that we haven't seen yet.
> > 
> > Also, do you know off hand what the behavior of the mesos API is to a 
> > killTask that the master has forgotten about/we've already acked? Will it 
> > send a TASK_LOST?
> 
> Bill Farner wrote:
> > It seems like exponential backoff is warranted here
> 
> Sure, at least getting a `BackoffStrategy` indirection there is useful.

> do you know off hand what the behavior of the mesos API is to a killTask that 
> the master has forgotten about/we've already acked?

The master _may_ send TASK_LOST in that case, but only when the task is 
definitely lost. This might go away in the future in favor of just relying on 
the reconciliation path.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59655
---


On Nov. 3, 2014, 9:25 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 9:25 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Bill Farner]

> On Nov. 3, 2014, 10:17 p.m., Kevin Sweeney wrote:
> > It seems like exponential backoff is warranted here - in the case that the 
> > master is completely overloaded there may be confirmation status updates in 
> > the queue that we haven't seen yet.
> > 
> > Also, do you know off hand what the behavior of the mesos API is to a 
> > killTask that the master has forgotten about/we've already acked? Will it 
> > send a TASK_LOST?

> It seems like exponential backoff is warranted here

Sure, at least getting a `BackoffStrategy` indirection there is useful.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59655
---


On Nov. 3, 2014, 9:25 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 9:25 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Kevin Sweeney]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59655
---


It seems like exponential backoff is warranted here - in the case that the 
master is completely overloaded there may be confirmation status updates in the 
queue that we haven't seen yet.

Also, do you know off hand what the behavior of the mesos API is to a killTask 
that the master has forgotten about/we've already acked? Will it send a 
TASK_LOST?

- Kevin Sweeney


On Nov. 3, 2014, 1:25 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 1:25 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59645
---


Master (c03cea5) is red with this patch.
  ./build-support/jenkins/build.sh

  pants build (options) [spec] (build args)
  pants build (options) [spec]... -- (build args)

Options:
  --version show program's version number and exit
  --no-pantsrc  Specifies that pantsrc files should be ignored.
  --log-exitLog an exit message on success or failure.
  -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
  -i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use.  Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used.  Multiple constraints may be
added.  They will be ORed together.
  -v, --verbose Show verbose output.
  -f, --fastRun tests in a single chroot.

Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.

- Aurora ReviewBot


On Nov. 3, 2014, 9:25 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 3, 2014, 9:25 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Bill Farner]

> On Nov. 3, 2014, 5:59 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 178
> > 
> >
> > Does not read right, s/of/if/?

Thanks, fixed.


> On Nov. 3, 2014, 5:59 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/async/KillRetry.java, line 81
> > 
> >
> > How about a stat counter here as well?

Good call, done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59591
---


On Nov. 1, 2014, 5:48 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 1, 2014, 5:48 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/
---

(Updated Nov. 3, 2014, 9:25 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-910
https://issues.apache.org/jira/browse/AURORA-910


Repository: aurora


Description
---

Retry Driver.killTask periodically until the task changes states.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
df7e56a955fef21d48e75797bb5761453ae1e57a 
  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 
748aac83db7c470dc7aed7936e629400c3e6c2d8 
  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
1688a339a1a9c4072d7f834963cb5ccad6fe0736 

Diff: https://reviews.apache.org/r/27467/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59591
---

Ship it!



src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java


Does not read right, s/of/if/?



src/main/java/org/apache/aurora/scheduler/async/KillRetry.java


How about a stat counter here as well?


- Maxim Khutornenko


On Nov. 1, 2014, 5:48 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 1, 2014, 5:48 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/#review59478
---

Ship it!


Master (9186f2e) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Nov. 1, 2014, 5:48 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27467/
> ---
> 
> (Updated Nov. 1, 2014, 5:48 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-910
> https://issues.apache.org/jira/browse/AURORA-910
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Retry Driver.killTask periodically until the task changes states.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> df7e56a955fef21d48e75797bb5761453ae1e57a 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java
>  748aac83db7c470dc7aed7936e629400c3e6c2d8 
>   src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
> 1688a339a1a9c4072d7f834963cb5ccad6fe0736 
> 
> Diff: https://reviews.apache.org/r/27467/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 27467: Retry Driver.killTask periodically until the task changes states.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27467/
---

Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-910
https://issues.apache.org/jira/browse/AURORA-910


Repository: aurora


Description
---

Retry Driver.killTask periodically until the task changes states.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
df7e56a955fef21d48e75797bb5761453ae1e57a 
  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/async/JobUpdateHistoryPrunerTest.java 
748aac83db7c470dc7aed7936e629400c3e6c2d8 
  src/test/java/org/apache/aurora/scheduler/async/KillRetryTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java 
1688a339a1a9c4072d7f834963cb5ccad6fe0736 

Diff: https://reviews.apache.org/r/27467/diff/


Testing
---


Thanks,

Bill Farner