Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62696
---


On master now.

- Maxim Khutornenko


On Nov. 21, 2014, 10:50 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62694
---

Ship it!


Ship It!

- Maxim Khutornenko


On Nov. 21, 2014, 10:50 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62681
---

Ship it!


Ship It!

- Joshua Cohen


On Nov. 21, 2014, 10:50 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62673
---

Ship it!


Master (ecc3fbc) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 21, 2014, 10:50 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

(Updated Nov. 21, 2014, 2:50 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Appease Robot.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62666
---


Master (91accd6) is red with this patch.
  ./build-support/jenkins/build.sh

:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift
:checkPython
:generateSources
:compileGeneratedJavaNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJavaNote: Writing 
file:/jenkins/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain
:compileTestJava
:processTestResources
:testClasses
:checkstyleTest[ant:checkstyle] 
/jenkins/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java:108:
 'org.apache.aurora.scheduler.ResourceSlot.EXECUTOR_OVERHEAD_CPUS' should be 
separated from previous imports.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at: 
> file:///jenkins/workspace/AuroraBot/dist/reports/checkstyle/test.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 57.435 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 21, 2014, 10:16 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

(Updated Nov. 21, 2014, 2:16 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Feedback.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 406
> > 
> >
> > +1 on moving it closer to its only consumer. That's a general guideline 
> > we follow everywhere.
> 
> Zameer Manji wrote:
> I really think it should belong with the Resources class because it is 
> equally as useful as .sum in my opinion. If you disagree I will move it 
> closer to the consumer.
> 
> Maxim Khutornenko wrote:
> You can always move it there when there is a use case. Until then, it's 
> better follow our style any open up only those things that are used in more 
> than one place.

Done.


> On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 196
> > 
> >
> > This is only used in tests outside of this class. Consider reverting to 
> > private.
> 
> Zameer Manji wrote:
> I think using this constant in tests makes the tests a bit simplier. I 
> have added a '@VisibleForTesting' annotation to signifiy this.
> 
> Maxim Khutornenko wrote:
> Using @VisibleForTesting is rather an exception when you want to reuse 
> the complex definition. You already re-define SOME_EXECUTOR_OVERHEAD for test 
> purposes, why not do the same for NO_EXECUTOR_OVERHEAD?

Done.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---


On Nov. 21, 2014, 12:34 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 12:34 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62658
---



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


Vinod, Mesos Committer, pointed out that if we allocate 0 resources for the 
executor and the task resources are small than what is required for the 
executor to run then we will instantly have a LOST_TASK.

In addition the 100MB comes from observing thermos in the wild and seeing a 
p99 memory usage of 100MB. I am unsure if the mesos.so really contributes to 
the memory usage. I am confident the python interpreter contributes a lot to 
the 100MB requirement.


- Zameer Manji


On Nov. 21, 2014, 12:34 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 12:34 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62634
---


Master (b6217df) is red with this patch.
  ./build-support/jenkins/build.sh

:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift
:checkPython
:generateSources
:compileGeneratedJavaNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:69:
 'org.apache.aurora.scheduler.ResourceSlot.EXECUTOR_OVERHEAD_CPUS' should be 
separated from previous imports.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 30.289 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 21, 2014, 8:34 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 8:34 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Maxim Khutornenko]

> On Nov. 21, 2014, 6:41 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 196
> > 
> >
> > This is only used in tests outside of this class. Consider reverting to 
> > private.
> 
> Zameer Manji wrote:
> I think using this constant in tests makes the tests a bit simplier. I 
> have added a '@VisibleForTesting' annotation to signifiy this.

Using @VisibleForTesting is rather an exception when you want to reuse the 
complex definition. You already re-define SOME_EXECUTOR_OVERHEAD for test 
purposes, why not do the same for NO_EXECUTOR_OVERHEAD?


> On Nov. 21, 2014, 6:41 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 406
> > 
> >
> > +1 on moving it closer to its only consumer. That's a general guideline 
> > we follow everywhere.
> 
> Zameer Manji wrote:
> I really think it should belong with the Resources class because it is 
> equally as useful as .sum in my opinion. If you disagree I will move it 
> closer to the consumer.

You can always move it there when there is a use case. Until then, it's better 
follow our style any open up only those things that are used in more than one 
place.


> On Nov. 21, 2014, 6:41 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 94
> > 
> >
> > Why not MIN_EXECUTOR_RESOURCES? We normally abstract out from the 
> > process framework concept in the scheduler code.
> 
> Zameer Manji wrote:
> These minimum values are for thermos. Another executor might require more 
> resources to function.

Did not we want to eliminate it completely though but Mesos did not let us do 
that? I suggest we just use a default and abstract MIN_EXECUTOR_RESOURCES and 
address the real need to differentiate when/if it comes up. Also, when 
https://reviews.apache.org/r/28345/ lands, the 100MB will become more like 0.5 
MB, so it clearly feels like an arbitrary Mesos workaround rather than a true 
MIN enforcement.


> On Nov. 21, 2014, 6:41 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, 
> > lines 166-173
> > 
> >
> > Unless I am missing something, all you need to do here is to make sure 
> > neither containerResources nor executorResources is less than min. Can you 
> > do something like:
> > finalTaskResources = Resources.maxElements(containerResources, 
> > MIN_TASK_RESOURCES);
> > 
> > and replace ".addAllResources(MIN_THERMOS_RESOURCES.toResourceList())" 
> > with
> > .addAllResources(Resources.maxElements(executorOverhead, 
> > MIN_THERMOS_RESOURCES))?
> 
> Zameer Manji wrote:
> I would always like to allocate MIN_THERMOS_RESOURCES for the executor. 
> What you are proposing will make it possible to allocate more CPU or RAM. 
> This is a change in behaviour from before where we were always allocated a 
> fixed amount for the executor.
> 
> I can change it to this if you insist but I prefer to allocate a fixed 
> amount for the executor.

Valid point. Though given the randomness of the applied MIN requirement I am 
not sure how important it is. I would go with a more readable and simple 
approach here. Your call.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---


On Nov. 21, 2014, 8:34 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 8:34 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

(Updated Nov. 21, 2014, 12:34 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Appease checkstyle/robot.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
65c4b526c89a4d5607af4424ebe49bb48e296ae9 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
d6febb8998e05257cabe8d193cefa0b6c79f197e 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62631
---


Master (b6217df) is red with this patch.
  ./build-support/jenkins/build.sh

:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain[ant:checkstyle] 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:193:
 Line is longer than 100 characters (found 114).
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///x1/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 14.203 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 21, 2014, 8:28 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 8:28 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

(Updated Nov. 21, 2014, 12:28 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Review feedback.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
65c4b526c89a4d5607af4424ebe49bb48e296ae9 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
d6febb8998e05257cabe8d193cefa0b6c79f197e 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, 
> > lines 166-173
> > 
> >
> > Unless I am missing something, all you need to do here is to make sure 
> > neither containerResources nor executorResources is less than min. Can you 
> > do something like:
> > finalTaskResources = Resources.maxElements(containerResources, 
> > MIN_TASK_RESOURCES);
> > 
> > and replace ".addAllResources(MIN_THERMOS_RESOURCES.toResourceList())" 
> > with
> > .addAllResources(Resources.maxElements(executorOverhead, 
> > MIN_THERMOS_RESOURCES))?

I would always like to allocate MIN_THERMOS_RESOURCES for the executor. What 
you are proposing will make it possible to allocate more CPU or RAM. This is a 
change in behaviour from before where we were always allocated a fixed amount 
for the executor.

I can change it to this if you insist but I prefer to allocate a fixed amount 
for the executor.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 
> > 94
> > 
> >
> > Why not MIN_EXECUTOR_RESOURCES? We normally abstract out from the 
> > process framework concept in the scheduler code.

These minimum values are for thermos. Another executor might require more 
resources to function.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 406
> > 
> >
> > +1 on moving it closer to its only consumer. That's a general guideline 
> > we follow everywhere.

I really think it should belong with the Resources class because it is equally 
as useful as .sum in my opinion. If you disagree I will move it closer to the 
consumer.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:41 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 196
> > 
> >
> > This is only used in tests outside of this class. Consider reverting to 
> > private.

I think using this constant in tests makes the tests a bit simplier. I have 
added a '@VisibleForTesting' annotation to signifiy this.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:10 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, 
> > lines 170-171
> > 
> >
> > It doesn't look like there's a test case for this scenario, can you add 
> > one?

"testExecutorInfoNoOverhead" does this with the ram property.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62574
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 21, 2014, 10:10 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > lines 407-414
> > 
> >
> > Inline this?

Inlining causes the constructor call to be unreadable.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62574
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Maxim Khutornenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62575
---



src/main/java/org/apache/aurora/scheduler/ResourceSlot.java


tabbing is off



src/main/java/org/apache/aurora/scheduler/configuration/Resources.java


This is only used in tests outside of this class. Consider reverting to 
private.



src/main/java/org/apache/aurora/scheduler/configuration/Resources.java


+1 on moving it closer to its only consumer. That's a general guideline we 
follow everywhere.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


Not related to your change but consider renaming it to something different 
(e.g. ExecutorSettings) to avoid naming collision with the thrift object.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


"-100MB" looks like negative resource and is confusing.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


Why not MIN_EXECUTOR_RESOURCES? We normally abstract out from the process 
framework concept in the scheduler code.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


Any justification for the min resources chosen similar to the above?



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


Convert to // for inline comments.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


Unless I am missing something, all you need to do here is to make sure 
neither containerResources nor executorResources is less than min. Can you do 
something like:
finalTaskResources = Resources.maxElements(containerResources, 
MIN_TASK_RESOURCES);

and replace ".addAllResources(MIN_THERMOS_RESOURCES.toResourceList())" with
.addAllResources(Resources.maxElements(executorOverhead, 
MIN_THERMOS_RESOURCES))?


- Maxim Khutornenko


On Nov. 21, 2014, 5:01 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 5:01 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Joshua Cohen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62574
---



src/main/java/org/apache/aurora/scheduler/ResourceSlot.java


Can you delegate to from(double, Amount, Amount, 
int) here?

return from(task.getNumCpus(), Amount.of(task.getRamMb(), Data.MB), 
Amount.of(task.getDiskMb(), Data.MB), task.getRequestedPorts().size());



src/main/java/org/apache/aurora/scheduler/ResourceSlot.java


Mind fixing this indent while you're here?



src/main/java/org/apache/aurora/scheduler/configuration/Resources.java


Inline this?



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


That's a poor font choice, RB. the tilde looks like a minus sign!



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


This isn't javadoc.



src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java


It doesn't look like there's a test case for this scenario, can you add one?



src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java


nit: move closing paren to previous line.


- Joshua Cohen


On Nov. 21, 2014, 5:01 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 5:01 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62531
---

Ship it!


Master (ada97bd) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 21, 2014, 5:01 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 5:01 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62528
---


@ReviewBot retry

- Zameer Manji


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62526
---


Master (ada97bd) is red with this patch.
  ./build-support/jenkins/build.sh

  pants build (options) [spec] (build args)
  pants build (options) [spec]... -- (build args)

Options:
  --version show program's version number and exit
  --no-pantsrc  Specifies that pantsrc files should be ignored.
  --log-exitLog an exit message on success or failure.
  -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
Number of seconds to wait for http connections.
  -i INTERPRETERS, --interpreter=INTERPRETERS
Constrain what Python interpreters to use.  Uses
Requirement format from pkg_resources, e.g.
'CPython>=2.6,<3' or 'PyPy'. By default, no
constraints are used.  Multiple constraints may be
added.  They will be ORed together.
  -v, --verbose Show verbose output.
  -f, --fastRun tests in a single chroot.

Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 21, 2014, 5:01 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 21, 2014, 5:01 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

> On Nov. 20, 2014, 6:29 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/Resources.java, 
> > line 401
> > 
> >
> > Consider moving this to where it's called, as there is only one 
> > non-test call site.

I prefer to keep it with the rest of the utility methods of Resources.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62511
---


On Nov. 20, 2014, 9:01 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 20, 2014, 9:01 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

(Updated Nov. 20, 2014, 9:01 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Add missing tags.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
65c4b526c89a4d5607af4424ebe49bb48e296ae9 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
d6febb8998e05257cabe8d193cefa0b6c79f197e 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62511
---

Ship it!



src/main/java/org/apache/aurora/scheduler/configuration/Resources.java


Missing @param, @return tags.



src/main/java/org/apache/aurora/scheduler/configuration/Resources.java


Consider moving this to where it's called, as there is only one non-test 
call site.


- Bill Farner


On Nov. 18, 2014, 11:33 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 18, 2014, 11:33 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/#review62060
---

Ship it!


Master (c44aa5c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 18, 2014, 11:33 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28193/
> ---
> 
> (Updated Nov. 18, 2014, 11:33 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-928
> https://issues.apache.org/jira/browse/AURORA-928
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Mesos rejects tasks and executors that are zero sized. This patch 
> reconfigures Aurora to ensure no zero sized tasks and executors are created.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
> 65c4b526c89a4d5607af4424ebe49bb48e296ae9 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
> d6febb8998e05257cabe8d193cefa0b6c79f197e 
>   
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
> 953c1edb6802d8983ab324aa56361e5c8fbe2e68 
> 
> Diff: https://reviews.apache.org/r/28193/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Review Request 28193: Prevent Aurora from creating zero sized Executor tasks.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28193/
---

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Bugs: AURORA-928
https://issues.apache.org/jira/browse/AURORA-928


Repository: aurora


Description
---

Mesos rejects tasks and executors that are zero sized. This patch reconfigures 
Aurora to ensure no zero sized tasks and executors are created.


Diffs
-

  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/configuration/Resources.java 
65c4b526c89a4d5607af4424ebe49bb48e296ae9 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
bb227fd86f7c4c692f6ae2aef1c15a94913354b7 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 
d6febb8998e05257cabe8d193cefa0b6c79f197e 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 
953c1edb6802d8983ab324aa56361e5c8fbe2e68 

Diff: https://reviews.apache.org/r/28193/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji