Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Bill Farner
On Dec. 3, 2014, 2:06 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 56 https://reviews.apache.org/r/28607/diff/2/?file=780608#file780608line56 This can be further simplified (unless you are concerned about

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- (Updated Dec. 3, 2014, 6:23 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63700 --- Ship it! Master (8959b49) is green with this patch.

Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63596 --- Ship it! Master (c86ca6d) is green with this patch.

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63598 ---

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 52 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line52 minor nit: you might want to have it outside the synchronized

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 58 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line58 Would it make sense to do it conditionally, i.e.: ```java

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
On Dec. 2, 2014, 11:09 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterState.java, line 58 https://reviews.apache.org/r/28607/diff/1/?file=780416#file780416line58 Would it make sense to do it conditionally, i.e.: ```java

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/ --- (Updated Dec. 3, 2014, 1:39 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63632 --- Ship it! Master (552ae93) is green with this patch.

Re: Review Request 28607: Add a caching ClusterState implementation.

2014-12-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28607/#review63637 --- Ship it!